From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Simon Trimmer" <simont@opensource.cirrus.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] firmware: cs_dsp: Remove usage of GFP_DMA
Date: Thu, 13 Feb 2025 15:06:59 +0000 [thread overview]
Message-ID: <1e251815-5d58-436b-9120-e88f75a7ecaa@sirena.org.uk> (raw)
In-Reply-To: <e93d1b72-43da-4e96-9523-e1bbf3853031@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On Thu, Feb 13, 2025 at 02:28:06PM +0000, Richard Fitzgerald wrote:
> On 11/02/2025 5:21 pm, Richard Fitzgerald wrote:
> > > Not tested on real hardware.
> > > This came up while porting kunit to mips64.
> > > Apparently GFP_DMA does not work there, but IMO the usage of GFP_DMA by
> I would say that is a bug in mips64 that should be fixed in mips64.
> It is not reasonable to expect generic drivers to have special cases for
> platforms that don't handle GFP_DMA.
What specifically is the issue? If it's a build time issue I'd
definitely agree that we should just be able to assume that platforms at
least build. IIRC there is a Kconfig you can depend on for DMA but it
seems more trouble than it's worth to fix all users.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-02-13 15:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 17:03 Thomas Weißschuh
2025-02-11 17:03 ` [PATCH 1/2] " Thomas Weißschuh
2025-02-11 17:03 ` [PATCH 2/2] firmware: cs_dsp: Remove bounce buffer in cs_dsp_coeff_write_ctrl_raw() Thomas Weißschuh
2025-02-11 17:21 ` [PATCH 0/2] firmware: cs_dsp: Remove usage of GFP_DMA Richard Fitzgerald
2025-02-12 13:12 ` Thomas Weißschuh
2025-02-13 14:28 ` Richard Fitzgerald
2025-02-13 15:06 ` Mark Brown [this message]
2025-02-13 15:16 ` Thomas Weißschuh
2025-02-19 16:26 ` Richard Fitzgerald
2025-02-20 9:52 ` Charles Keepax
2025-02-20 10:29 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e251815-5d58-436b-9120-e88f75a7ecaa@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®