From: Lars-Peter Clausen <lars@metafoo.de>
To: Moritz Fischer <mdf@kernel.org>
Cc: "Michal Simek" <michal.simek@xilinx.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Devicetree List" <devicetree@vger.kernel.org>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Julia Cartwright" <julia@ni.com>
Subject: Re: [PATCH v2] ARM: zynq: Add #io-channel-cells to (x)adc node for iio-hwmon
Date: Thu, 16 Mar 2017 22:23:13 +0100 [thread overview]
Message-ID: <1e25520c-acbf-6512-3070-77e3c852e4f8@metafoo.de> (raw)
In-Reply-To: <CAJYdmeMg+DtwwbXOM7hPC4ejvkYkR94fcoyvTpx86RSKSswFMg@mail.gmail.com>
On 03/16/2017 06:54 PM, Moritz Fischer wrote:
> Hi Lars,
>
> On Thu, Mar 16, 2017 at 9:51 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:
>> On 03/16/2017 05:45 PM, Michal Simek wrote:
>>> On 16.3.2017 17:39, Moritz Fischer wrote:
>>>> On Thu, Mar 16, 2017 at 9:16 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>>>>> Hi,
>>>>>
>>>>> On 8.3.2017 21:11, Moritz Fischer wrote:
>>>>>> Fix
>>>>>>
>>>>>> OF: /iio_hwmon: could not get #io-channel-cells for
>>>>>> /amba/adc@f8007100
>>>>>> OF: /iio_hwmon: could not get #io-channel-cells for
>>>>>> /amba/adc@f8007100
>>>>>> OF: /iio_hwmon: could not get #io-channel-cells for
>>>>>> /amba/adc@f8007100
>>>>>>
>>>>>> by adding the #io-channel-cells property.
>>>>>>
>>>>>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>>>>>> Cc: Michal Simek <michal.simek@xilinx.com>
>>>>>> Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
>>>>>> Cc: Julia Cartwright <julia@ni.com>
>>>>>> Cc: linux-kernel@vger.kernel.org
>>>>>> Cc: devicetree@vger.kernel.org
>>>>>> ---
>>>>>>
>>>>>> Changes from v1:
>>>>>> - fix messed up commit message
>>>>>> ---
>>>>>> arch/arm/boot/dts/zynq-7000.dtsi | 1 +
>>>>>> 1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>>>>>> index f3ac9bf..98233a8 100644
>>>>>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>>>>>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>>>>>> @@ -72,6 +72,7 @@
>>>>>> interrupts = <0 7 4>;
>>>>>> interrupt-parent = <&intc>;
>>>>>> clocks = <&clkc 12>;
>>>>>> + #io-channel-cells = <1>;
>>>>>> };
>>>>>>
>>>>>> can0: can@e0008000 {
>>>>>>
>>>>>
>>>>> I think it will be good to the next step too.
>>>>> It means also add iio-hwmon node too.
>>>>>
>>>>> What do you think?
>>>>
>>>> I hadn't put it in there since dts is supposed to describe hw,
>>>> but obviously putting the actual hwmon in there makes it more useful.
>>>
>>> I had one discussion about this with Grant in past and it is common
>>> mistake. It is simplification of purpose of dts.
>>>
>>
>> If the iio-hwmon binding had gone through review it would have been rejected.
>>
>>>>
>>>> I can resubmit with the hwmon node in there.
>>>
>>> If you grep kernel tree you will see that others are using it too.
>>> Also there is accepted binding for that that's why I can't see big
>>> problem with it.
>>
>> Since this is an application specific binding I wouldn't put it in the
>> generic DT include file. It's a bit like adding a gpio-key binding for each
>> of the GPIOs just in case somebody wants to use it.
>
> So is your suggestion to move the whole thing from .dtsi -> .dts?
The #io-channels-cells can go into the dtsi, that's a sensible thing to do.
The number of cells is part of the binding specification for the XADC and
wont change.
The hwmon bridge on the other hand I wouldn't put into any default
devicetree. In my opinion is should only used if and only if there are
legacy applications on a specific system that need to use the hwmon interface.
next prev parent reply other threads:[~2017-03-16 21:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 20:11 Moritz Fischer
2017-03-16 16:16 ` Michal Simek
2017-03-16 16:39 ` Moritz Fischer
2017-03-16 16:45 ` Michal Simek
2017-03-16 16:51 ` Lars-Peter Clausen
2017-03-16 17:54 ` Moritz Fischer
2017-03-16 21:23 ` Lars-Peter Clausen [this message]
2017-03-16 18:06 ` Michal Simek
2017-03-16 21:20 ` Lars-Peter Clausen
2017-03-17 6:46 ` Michal Simek
2017-03-20 15:33 ` Michal Simek
2017-03-20 15:34 ` Lars-Peter Clausen
2017-04-07 7:11 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e25520c-acbf-6512-3070-77e3c852e4f8@metafoo.de \
--to=lars@metafoo.de \
--cc=devicetree@vger.kernel.org \
--cc=julia@ni.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®