mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: Build failure due commit 9217e566bdee
Date: Wed, 4 Apr 2018 10:00:39 +0200	[thread overview]
Message-ID: <1e269233-162c-0f40-6815-328c28c2a093@topic.nl> (raw)
In-Reply-To: <76f98816-9f0a-3eb7-e00e-82cf5935afd6@linux.intel.com>

On 04-04-18 09:22, Jarkko Nikula wrote:
> Hi
> 
> Today's head and linux-next doesn't compile due commit 9217e566bdee ("of_net: 
> Implement of_get_nvmem_mac_address helper"):
> 
> drivers/of/of_net.o: In function `of_get_nvmem_mac_address':
> .../drivers/of/of_net.c:100: undefined reference to `of_nvmem_cell_get'
> .../drivers/of/of_net.c:104: undefined reference to `nvmem_cell_read'
> .../drivers/of/of_net.c:106: undefined reference to `nvmem_cell_put'
> Makefile:1033: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> Builds if I set CONFIG_NVMEM=y from CONFIG_NVMEM=m or revert above commit.
> 


I've been looking into it, but haven't come up with a proper solution.

The issue is that OF_NET now requires NVMEM as either not-present or built-in, 
but cannot support it as module.

I don't know if that requirement can be expressed. I think having nvnmem_core 
as a module doesn't make much sense anyway, but that's not up to me.

Moving the code from of to nvmem seems weird, but would solve it.



Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

      reply	other threads:[~2018-04-04  9:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04  7:22 Jarkko Nikula
2018-04-04  8:00 ` Mike Looijmans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e269233-162c-0f40-6815-328c28c2a093@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®