From: Markus Elfring <Markus.Elfring@web.de>
To: Frank Li <Frank.li@oss.nxp.com>,
sashiko-reviews@lists.linux.dev, dmaengine@vger.kernel.org
Cc: Frank Li <Frank.Li@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: dmaengine: dw: Use devm_clk_get_optional_enabled() in dw_probe()
Date: Thu, 19 Nov 2026 19:09:19 +0100 [thread overview]
Message-ID: <1e2fe486-f497-4263-b759-5876f2f5bd2d@web.de> (raw)
In-Reply-To: <av804gPG5A8_8UkG@SMW015318>
>> Do you find these two function calls really not equivalent to another known function call?
>> https://elixir.bootlin.com/linux/v7.4-rc1/source/include/linux/clk.h#L680-L699
>
> What's your point?
I wonder why the cleanup procedure would need to be different after the proposed refactoring
for the implementation of the function “dw_probe”.
https://elixir.bootlin.com/linux/v7.4-rc1/source/drivers/dma/dw/platform.c#L24-L92
> Sashiko just remind you need remove
> clk unprepare at error path
It got the impression that this function call would be still relevant
(behind the label “err_dw_dma_probe”) according to a failed statement “ret = data->probe(chip);”.
> and remove() function
Do you expect more functionality from a devm_clk_get_optional_enabled() call
than from the combination of devm_clk_get_optional() and clk_prepare_enable() so far?
Regards,
Markus
>> …
>>>> --
>>>> Sashiko AI review · https://sashiko.dev/#/patchset/8e3534b7-ae64-4c1f-819d-0ba390737b84@web.de?part=1
prev parent reply other threads:[~2026-11-19 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 16:06 [PATCH] " Markus Elfring
2026-11-19 17:16 ` Andy Shevchenko
2026-11-19 17:27 ` Markus Elfring
2026-11-19 17:36 ` Andy Shevchenko
[not found] ` <sashiko-outbox-223487@kernel.org>
[not found] ` <av8pd_aQFFSSMkDg@SMW015318>
2026-11-19 17:22 ` [PATCH] " Markus Elfring
2026-11-19 17:41 ` Frank Li
2026-11-19 18:09 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e2fe486-f497-4263-b759-5876f2f5bd2d@web.de \
--to=markus.elfring@web.de \
--cc=Frank.Li@kernel.org \
--cc=Frank.li@oss.nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®