From: Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>
To: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Jeff Johnson <jjohnson@kernel.org>,
"Karthikeyan Periyasamy" <quic_periyasa@quicinc.com>,
Kalle Valo <kvalo@kernel.org>,
Harshitha Prem <quic_hprem@quicinc.com>
Cc: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
<linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH ath-next v4 4/9] wifi: ath12k: fix ATH12K_FLAG_REGISTERED flag handling
Date: Tue, 8 Apr 2025 15:22:54 +0530 [thread overview]
Message-ID: <1e31fe1c-333b-b841-5419-1c8be9a762dc@quicinc.com> (raw)
In-Reply-To: <20250408-fix_reboot_issues_with_hw_grouping-v4-4-95e7bf048595@oss.qualcomm.com>
On 4/8/2025 11:36 AM, Aditya Kumar Singh wrote:
> Commit a5686ae820fa ("wifi: ath12k: move ATH12K_FLAG_REGISTERED handling to
> ath12k_mac_register()") relocated the setting of the ATH12K_FLAG_REGISTERED
> flag to the ath12k_mac_register() function. However, this function only
> accesses the first device (ab) via ag->ab[0], resulting in the flag being
> set only for the first device in the group. Similarly,
> ath12k_mac_unregister() only unsets the flag for the first device. The flag
> should actually be set for all devices in the group to avoid issues during
> recovery.
>
> Hence, move setting and clearing of this flag in the function
> ath12k_core_hw_group_start() and ath12k_core_hw_group_stop() respectively.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Fixes: a5686ae820fa ("wifi: ath12k: move ATH12K_FLAG_REGISTERED handling to ath12k_mac_register()")
> Signed-off-by: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
next prev parent reply other threads:[~2025-04-08 9:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 6:06 [PATCH ath-next v4 0/9] wifi: ath12k: fixes for rmmod and recovery issues with hardware grouping Aditya Kumar Singh
2025-04-08 6:06 ` [PATCH ath-next v4 1/9] wifi: ath12k: fix SLUB BUG - Object already free in ath12k_reg_free() Aditya Kumar Singh
2025-04-08 9:50 ` Vasanthakumar Thiagarajan
2025-04-08 6:06 ` [PATCH ath-next v4 2/9] wifi: ath12k: add reference counting for core attachment to hardware group Aditya Kumar Singh
2025-04-08 9:51 ` Vasanthakumar Thiagarajan
2025-04-08 6:06 ` [PATCH ath-next v4 3/9] wifi: ath12k: fix failed to set mhi state error during reboot with hardware grouping Aditya Kumar Singh
2025-04-08 9:52 ` Vasanthakumar Thiagarajan
2025-04-08 6:06 ` [PATCH ath-next v4 4/9] wifi: ath12k: fix ATH12K_FLAG_REGISTERED flag handling Aditya Kumar Singh
2025-04-08 9:52 ` Vasanthakumar Thiagarajan [this message]
2025-04-08 6:06 ` [PATCH ath-next v4 5/9] wifi: ath12k: fix firmware assert during reboot with hardware grouping Aditya Kumar Singh
2025-04-08 9:53 ` Vasanthakumar Thiagarajan
2025-04-08 6:06 ` [PATCH ath-next v4 6/9] wifi: ath12k: fix ath12k_core_pre_reconfigure_recovery() with grouping Aditya Kumar Singh
2025-04-08 9:55 ` Vasanthakumar Thiagarajan
2025-04-08 6:06 ` [PATCH ath-next v4 7/9] wifi: ath12k: handle ath12k_core_restart() with hardware grouping Aditya Kumar Singh
2025-04-08 9:56 ` Vasanthakumar Thiagarajan
2025-04-08 6:06 ` [PATCH ath-next v4 8/9] wifi: ath12k: handle ath12k_core_reset() " Aditya Kumar Singh
2025-04-08 9:58 ` Vasanthakumar Thiagarajan
2025-04-08 6:06 ` [PATCH ath-next v4 9/9] wifi: ath12k: reset MLO global memory during recovery Aditya Kumar Singh
2025-04-08 10:00 ` Vasanthakumar Thiagarajan
2025-04-12 4:24 ` [PATCH ath-next v4 0/9] wifi: ath12k: fixes for rmmod and recovery issues with hardware grouping Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e31fe1c-333b-b841-5419-1c8be9a762dc@quicinc.com \
--to=quic_vthiagar@quicinc.com \
--cc=aditya.kumar.singh@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_hprem@quicinc.com \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®