From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3FE7C433F5 for ; Fri, 25 Feb 2022 01:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236648AbiBYB7Z (ORCPT ); Thu, 24 Feb 2022 20:59:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236630AbiBYB7Y (ORCPT ); Thu, 24 Feb 2022 20:59:24 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 768247DA86 for ; Thu, 24 Feb 2022 17:58:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645754333; x=1677290333; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=AiMLReOXdbxwCJYEkuxwFgwJdr/KRPlox84ap13k0a8=; b=aQbkLOajP2N7fOgLET6uTd9JC4oqVuZKNdkEI33MtXLDgTJfvScH5WY/ QieC1V6wrTLMVyHoEiEMc89NggDF4z02okvpb6pDs5T4JFfH0bZio6Z0L jEtp2sw4nVj5nGz53msQ+ccDwBynjnlb0jUTuGZW9d2xXlnQUamy1h6N1 dMsmlR4d+ugKDZ3GyaIIU+vkGH6pYdzYIIDnUuzBRFMBKG3CC8Ru1L1QE YYo8q6T9StpKloHW2wJ2gEEyXd+ULrlJo4grWzcBk+mFBjHKLGAsAMuAJ jTH00opBNzXwTiLLsBYpYxkfYqdToYjlIq7+vROQAxW9sIHXpgTH1N5zM w==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="315617120" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="315617120" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 17:58:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="533386135" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by orsmga007.jf.intel.com with ESMTP; 24 Feb 2022 17:58:50 -0800 Message-ID: <1e320de0-3dd7-936f-a9d4-8686687b0675@linux.intel.com> Date: Fri, 25 Feb 2022 09:57:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Kevin Tian , Ashok Raj , Liu Yi L , Jacob Pan , Robin Murphy , Christoph Hellwig , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/11] iommu/vt-d: Fix indentation of goto labels Content-Language: en-US To: Jason Gunthorpe References: <20220214025704.3184654-1-baolu.lu@linux.intel.com> <20220214025704.3184654-9-baolu.lu@linux.intel.com> <20220224130822.GK6413@nvidia.com> From: Lu Baolu In-Reply-To: <20220224130822.GK6413@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/22 9:08 PM, Jason Gunthorpe wrote: > On Mon, Feb 14, 2022 at 10:57:01AM +0800, Lu Baolu wrote: >> Remove blanks before goto labels. >> >> Signed-off-by: Lu Baolu >> drivers/iommu/intel/iommu.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > It would be better to rework this function to not have the goto > spaghetti in the first place.. Looks like putting the > 'for_each_active_dev_scope' into another function would do the trick. Good idea. Let me revisit this later. > > Anyhow, this is more consistent with kernel style: > > Reviewed-by: Jason Gunthorpe > > Jason Best regards, baolu