From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793972439; b=4ZV6eUjlVheS1cymRUymmKQgL/yzWp+GOLfq5SKN4HKpF+bvszGpOV984nMq+9rIxcng 6YeB9AkpoGW34SV4QShqh0k2Q/L3pY7ijCk/zSPw1hbTKjDN4Mmhzb2tqeRwyiJd78g6D 5KVkpiPDgYpUiP9hY6vcMBfP4TnZqnC5kqAtMXTeXrDeP8Ha5/N296aEwtxgWjvtbR4KT LMftVoJNZvHHP1BA948VVhIqSj55l5tyi9dtIiRJigZoRyqlsJsjoyJlEkfC7T2nlGbPw twGknm6GWBkmIALq0DbiEVwz5XYlHjPAobw0KvV9bceAHYWxVvzijtruvW/rqhCVRhg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793972439; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Authority-Analysis:X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=GDCcjK22s0dpHL/t9oPLo+bDI5LKQyG+roTno8WQGAY=; b=Yt/KNeJrNttV7VQ106bQHKEBIjcUNIdKU9RATmm5Bf9piREtL2fqUKS+Knu3FM/oq/Bl 3NTCR/i4po6vJsKlsSpJWI9veYpbRNKX83Gvuzz5FLethI3cKvqtSBnHGI39HVZZJkuTI HCsvOLnznMLHb9TqL9JH7fhFeOrEGCypPAa2ktm7K/eNzhur62MgmsuMSQpmHzNcE8Ms0 SPYDZIOWSkGXl/tJPBU7H9N+FmOBeAWeNkIqq0zeZZwR05szx5k5/EURS9WAO+VsPUMPq JsCdEBr31q12qKVrEn2hJQZe7TPrLlFLgrtyBYW/wIJ6ilEu+CVJzmMYBklaq612Trw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mt21uQwH; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=PwIpTiIW; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 551D2606A329 for ; Fri, 6 Nov 2026 13:40:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 551D2606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mt21uQwH; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=PwIpTiIW Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A6APLwv527324 for ; Fri, 6 Nov 2026 13:40:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GDCcjK22s0dpHL/t9oPLo+bDI5LKQyG+roTno8WQGAY=; b=mt21uQwH60jZV5YW bmP8efFpPjP5ibdMaideJXA1mUJKEe2ENerXsynsr0DD+DuxPZeEvQ7ENDmjz9wD dVk+4Lcw6/2YyzReaW+ztxb+6XVhqvQgwyx/DkdCWobxvYkwgZy/nw1wnPZH2tDm kISJQSojSv+jL9sQP9oTMVlv757YeREFCcCJ/2R3gcWNeiD2Lgd9f0g0nIE6azfe D9fzMwya7PVB4RgOiXaJ5419mGvRKlQKdFy4efXoqwZaw1PuPfFxuln7olNuGMW9 xuPl4KrTSugyBOPvK7GBE2GFbJKGUgV9Ot4L90AGBGLtpjIXKZ7LZno4xJu7chzG Onc5sg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hs3p9tytv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Nov 2026 13:40:37 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-93e629c7b16so15684085a.1 for ; Fri, 06 Nov 2026 05:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793972436; x=1794577236; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GDCcjK22s0dpHL/t9oPLo+bDI5LKQyG+roTno8WQGAY=; b=PwIpTiIWw8FIUerBBkwWbF6MBvu8kbY7uFo22a1BtDQ6A2dVoNuQNxUbMrHLVQTayv Imcu1jkUFlsGD6gZFl3eZHEtRd4xwYRxRleGCIKoe89HJR5aqY8qOTsbSEgUTCatzKPR ozV94ZZNc26HS7SsJWvhvpKS/ZhqsCIXPlpDSxHjTV5lSPBbFufsKiMBwh6YHwF4eUT5 sXnmUdAyFkXeAZ73o3TbkHjfMzqzQy7TX59tTK46dYAqH3vl9Sp7Ovsi2xJXy07Jy2IZ p7smqCvIzOOQgfSlgHF584hXQ5MpfS8Aaa/+Pm/Z1wXSIKWBeupjVGcpXqrgQFcNnEBi 18lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793972436; x=1794577236; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GDCcjK22s0dpHL/t9oPLo+bDI5LKQyG+roTno8WQGAY=; b=UPIQCRM97ujTP++rqhEaODViYil/EfiPlpqupbbJKnHqZ5OTXcpJRsN2Vr4mR09tl0 CkBsfiPohB5sr7Y4YC+ODD9jiXyf8qwcOHowS3508ZqBknnUKc+0J/qYxa+Ttn8o0Bug UTN3zWXw7jhDFvH8+0imHBnjCQONfuIq39+q5CHlVjjHVWduEV7TJGLL8iNtO5jVDhdY Lmo6oPMIm41oeByijNW9RpoSJSWLHDcafkRXCr1HGEg9nmmajKN6rsO+6bh7bZEZVP7E vAmIOy/HBbXZ96aDKSDlPq/gDjX6DqPDzKrfX39uZ3MeHABAVCxtsjzJimVpvmQdbPON p71A== X-Forwarded-Encrypted: i=1; AKwUvByHzNoFCXi28+0ivNOYHej0DZJDl2JxjQSBPpFdSWFynWO9gl6Rnw4Y0O3W6aXiEw7S9npGJikXeVEJOw4=@vger.kernel.org X-Gm-Message-State: APuU4Z/t6BHlGRq51tSm2bbzqdcT6JrVCXm2xiblIE8mP6ETH6JpGVv5 pvDI6IYN9KgFLqIzVNoOYrxGDKo1xFh41CkXLF7p2okMwPbHinT/SCcw8OzIkr3cc53rpAMwM7s Q+Hnnb/sZ2XZgtfrHSDB9QDTpU/Xc3/9dNCV9oXYYw1Wfy+Qr7nPauPGSzdLYH1IS/ws= X-Gm-Gg: AYBFou3lpyJZ4cXsV69PIzVkm+ykKWlSf5rg1cOTDVa3RRjka2oL7qJnrMh/tew76cw EwrO9/lPaNzUWwXtWATnFL8UyrjwxQDCE7LMFPxOQsdzaPlONCO8ERUeD4un5t38Q8MS3+y87cm iVPP5Dbp9+JYish8AJsctgIdQBCUAgUNsRyuoHtylJD7/9JW3OfOP+DeTYOHBqClOfRP5awku/C lQfrltKXwxLgxN0wEnIZea6hVijmea2KPXzs9fI8MfABImLEqaJyVRvR7bbum/epafD/FfQGzsT tJroFeoQkIxsNnVgblgRFCNth9w5QWRrM9PyeG/LoSIfB3Ek+PPbcEptiZNj7YyJQRTzay43gtb 72xWfsA3L3OId/YAnyYf+M2D+dSOFIJX1JondzE4ptuWWCZBngIfjL6now90to4VpBasJrA== X-Received: by 2002:a05:620a:2055:b0:92e:6485:f640 with SMTP id af79cd13be357-945f357ff62mr327791585a.4.1793972436437; Fri, 06 Nov 2026 05:40:36 -0800 (PST) X-Received: by 2002:a05:620a:2055:b0:92e:6485:f640 with SMTP id af79cd13be357-945f357ff62mr327788885a.4.1793972435896; Fri, 06 Nov 2026 05:40:35 -0800 (PST) Received: from [192.168.226.72] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c4d35673731sm79647366b.44.2026.11.06.05.40.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2026 05:40:35 -0800 (PST) Message-ID: <1e3638fd-ed06-457f-bc8d-1f541caf4c50@oss.qualcomm.com> Date: Fri, 6 Nov 2026 14:40:33 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pinctrl: qcom: fix a use-after-free bug in system shutdown path To: Bartosz Golaszewski , Bartosz Golaszewski , Bjorn Andersson , Linus Walleij , Stephen Boyd , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20261105-pinctrl-qcom-uaf-v1-1-c9cbc0a93161@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20261105-pinctrl-qcom-uaf-v1-1-c9cbc0a93161@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA2MDA1NCBTYWx0ZWRfXzpy+cFf3nk/8 vKgyvxQzUQBtdiZhaBPS3Kmw+SSyXoRZWyaUdAq0X2lqe8ggSAOFFfKUNOFYVKpogt6nFrieuwM fYmlFyBy8CFl3q8ompkQ4+D5OdsXZ98= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA2MDA1NCBTYWx0ZWRfX2BRvUtXg/lOQ 82sVmx8XpGVFLH+ox+lQvuHAZxmG1ExDhl1x7R/0GrkTcqJmLmPbH3U1gExZMT3cwLLNtcaRjEA UPIKZjpcuqxBZ40YMJsaitrThmDEn1y4GKsPQR75gCQu6ONu9noq3H0hJ6byDv3ZFukYmTaLwlu 9ofN9tv3pVTIrO15QAITiba5/AIDXyOs7ZjFVQBpvmWtSCMfd0YxxfriNNyLmh34a74PGnla1F0 xmBWQJ+Ns5ffSm5OKNHFh02W5SV2nq07FJI5PXiMqUF9gVDtWXJbrJr8oaYMd65eGfGgSQvRzMc LSpoNAecHoIm/WCqwqKrcPH5DcJB0HjG5yVcbvfZTIKIWszdCd6NDX91mqdlsluiRuDNvFXqyOG 5J2dOFKSq/Emy+yvxO7dwdT8tamlKgMJX7duDPL2v87k1VmlfmK/yvfyO5oMHYIZ1u17qzsxbWB rJSZmhybEsrhnjLtwHQ== X-Proofpoint-ORIG-GUID: YVrwpqyusu0HoyaCrchsSrEJ7BHKo5qv X-Authority-Analysis: v=2.4 cv=f6Pdl+yM c=1 sm=1 tr=0 ts=6aedd8d5 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=c92rfblmAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=a_ps4GQ-2PcO9Fe_iXEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=GvGzcOZaWPEFPQC_NcjD:22 X-Proofpoint-GUID: YVrwpqyusu0HoyaCrchsSrEJ7BHKo5qv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-06_03,2026-11-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611060054 On 11/5/26 5:09 PM, Bartosz Golaszewski wrote: > msm_pinctrl_probe() allocates the pctrl structure via devm_kzalloc() and > unconditionally populates the global variables poweroff_pctrl and > pm_power_off. > > If msm_pinctrl_probe() subsequently fails, devres resources - including > the memory allocated for pctrl - are automatically freed. However, the > global pointers are never cleared, resulting in a use-after-free during > kernel_power_off(). > > Schedule a devres action clearing the global pointers that runs before > the pctrl memory is freed. > > Cc: stable@vger.kernel.org > Closes: https://sashiko.dev/#/bug/linux-0c3a18a4-3de8-489b-abc9-e9e3a8641ed2 > Fixes: ad64498762dd ("pinctrl: qcom: Hook pm_power_down for shutdown support") > Signed-off-by: Bartosz Golaszewski > --- Reviewed-by: Konrad Dybcio Konrad