From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751511AbdHJIIv (ORCPT ); Thu, 10 Aug 2017 04:08:51 -0400 Received: from mout.web.de ([212.227.17.11]:58403 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbdHJIIs (ORCPT ); Thu, 10 Aug 2017 04:08:48 -0400 To: alsa-devel@alsa-project.org, "Gustavo A. R. Silva" , Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ASoC: spear: Delete an error message for a failed memory allocation in two functions Message-ID: <1e377ebe-822c-fca6-d2cd-c27a84ae1566@users.sourceforge.net> Date: Thu, 10 Aug 2017 10:07:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:4U1hDf0ED76t7rUQO8aO9Ex9tc+RW6ZsIk3t1w9cK0/Soi+vVPo hvy/dd5adciXOFpRbop5qGxMBXSjVdvd7DgZHFSDddgkCE0+/XZCV32PeqZNwQko7T0tLdx E5f8EYXOEx9tLz9miPjVKtAxCDQpSMeMFSfSUbq+vS4BuOqK7HeTG4zneBfkATqtaGncooE A47V5cCvyyy8BUcS6gVuw== X-UI-Out-Filterresults: notjunk:1;V01:K0:50jFNWj5Vk0=:gI2qNGay4YI50+djAswQrW O/8PveDL03/QSIJ2yUB3YqzH2OTQ0wzuq268wUpBDWJVDuoXrkclNiQEBzospXDkYeLbBzH4s XuwJBuF3Db8X3wscUq2xNaiMwGGRGhFW3c/LoXAyREAX2W02TVX5+h1k8d2hGLc3Mv9T5dZZ5 gUhwOQxEwM6sHWjeQXUjpyFF5BIhLYGP2c15U3dOm1ePsXRntsN+Vzwfripqo+Mvg/A34//vG MAqISkkmnOpSp/ZhJYFgpl7bHKPBoZab3cHWZYNXFMAHaID4ywu7GpPNxubHDM5vVcErw3t6b EUcBhBXc5h0N50Qgp9l37vOJFI/A3qWnSII9GtKuvJE8d3sRCHzsXX5z+acKPvZcFl1tth6aM HLpTmBhGaEzNB01c5A3N1OfZ5lrZhQPoF6PtjovIhhV9eqiozouEy7OZHuSIFPLNyx1QB4vYU GX2vKMlQ71PtnRljL+CjDSDa/Bupoee6mmnUMQ9SnIg9qv6Eqn9lUe/D7y6U+jtzhfSI725Iz B5T9OPx66qyozSyjxqQgPrW3r6xRtVWKGhQkbchQyBkJb59cvSFHn9bp7GAi2uSWFx8Pzi3QO F0FKhaga5ABRJkpVE0x3lgjPFCvcV3REF92PI/EXME8ff4uli9B98r+I0oUMz5SWwgYnlk7KR +yCiAqMVcHO2HtztQROrbzDqYTcFZ6o8nozT2npwF4GaWIGqkVwT3T2KQB2cDJH5wKxTnrzba /ZztYK2fz4kO9t9r0nzbAhq2MUAAuLwBZ9RJiue9kNC1O3I5MeLddNRKxQHpX4/rHk5S9O0TF xNIVNQef21P2DUK930L3fZufJcpUNRfiRCfdAXHVm9aVtn6tEc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 10 Aug 2017 09:50:51 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- sound/soc/spear/spdif_in.c | 4 +--- sound/soc/spear/spdif_out.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/spear/spdif_in.c b/sound/soc/spear/spdif_in.c index 7f32527fc3c8..01b28e59b4c0 100644 --- a/sound/soc/spear/spdif_in.c +++ b/sound/soc/spear/spdif_in.c @@ -216,10 +216,8 @@ static int spdif_in_probe(struct platform_device *pdev) return -EINVAL; host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL); - if (!host) { - dev_warn(&pdev->dev, "kzalloc fail\n"); + if (!host) return -ENOMEM; - } host->io_base = io_base; host->irq = platform_get_irq(pdev, 0); diff --git a/sound/soc/spear/spdif_out.c b/sound/soc/spear/spdif_out.c index 0a72d52d533e..58d5843811f9 100644 --- a/sound/soc/spear/spdif_out.c +++ b/sound/soc/spear/spdif_out.c @@ -282,10 +282,8 @@ static int spdif_out_probe(struct platform_device *pdev) int ret; host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL); - if (!host) { - dev_warn(&pdev->dev, "kzalloc fail\n"); + if (!host) return -ENOMEM; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); host->io_base = devm_ioremap_resource(&pdev->dev, res); -- 2.13.4