From: "Christian König" <christian.koenig@amd.com>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
Rob Clark <robdclark@chromium.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Gustavo Padovan <gustavo@padovan.org>,
"open list:SYNC FILE FRAMEWORK" <linux-media@vger.kernel.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dma-buf/dma-fence: Add dma_fence_init_noref()
Date: Mon, 13 Mar 2023 08:13:58 +0100 [thread overview]
Message-ID: <1e3d4830-4797-8cc2-5882-02de44424ec7@amd.com> (raw)
In-Reply-To: <20230311173513.1080397-2-robdclark@gmail.com>
Am 11.03.23 um 18:35 schrieb Rob Clark:
> From: Rob Clark <robdclark@chromium.org>
>
> Add a way to initialize a fence without touching the refcount. This is
> useful, for example, if the fence is embedded in a drm_sched_job. In
> this case the refcount will be initialized before the job is queued.
> But the seqno of the hw_fence is not known until job_run().
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Well that approach won't work. The fence can only be initialized in the
job_run() callback because only then the sequence number can be determined.
Regards,
Christian.
> ---
> drivers/dma-buf/dma-fence.c | 43 ++++++++++++++++++++++++++++---------
> include/linux/dma-fence.h | 2 ++
> 2 files changed, 35 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 74e36f6d05b0..97c05a465cb4 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -989,28 +989,27 @@ void dma_fence_describe(struct dma_fence *fence, struct seq_file *seq)
> EXPORT_SYMBOL(dma_fence_describe);
>
> /**
> - * dma_fence_init - Initialize a custom fence.
> + * dma_fence_init_noref - Initialize a custom fence without initializing refcount.
> * @fence: the fence to initialize
> * @ops: the dma_fence_ops for operations on this fence
> * @lock: the irqsafe spinlock to use for locking this fence
> * @context: the execution context this fence is run on
> * @seqno: a linear increasing sequence number for this context
> *
> - * Initializes an allocated fence, the caller doesn't have to keep its
> - * refcount after committing with this fence, but it will need to hold a
> - * refcount again if &dma_fence_ops.enable_signaling gets called.
> - *
> - * context and seqno are used for easy comparison between fences, allowing
> - * to check which fence is later by simply using dma_fence_later().
> + * Like &dma_fence_init but does not initialize the refcount. Suitable
> + * for cases where the fence is embedded in another struct which has it's
> + * refcount initialized before the fence is initialized. Such as embedding
> + * in a &drm_sched_job, where the job is created before knowing the seqno
> + * of the hw_fence.
> */
> void
> -dma_fence_init(struct dma_fence *fence, const struct dma_fence_ops *ops,
> - spinlock_t *lock, u64 context, u64 seqno)
> +dma_fence_init_noref(struct dma_fence *fence, const struct dma_fence_ops *ops,
> + spinlock_t *lock, u64 context, u64 seqno)
> {
> BUG_ON(!lock);
> BUG_ON(!ops || !ops->get_driver_name || !ops->get_timeline_name);
> + BUG_ON(!kref_read(&fence->refcount));
>
> - kref_init(&fence->refcount);
> fence->ops = ops;
> INIT_LIST_HEAD(&fence->cb_list);
> fence->lock = lock;
> @@ -1021,4 +1020,28 @@ dma_fence_init(struct dma_fence *fence, const struct dma_fence_ops *ops,
>
> trace_dma_fence_init(fence);
> }
> +EXPORT_SYMBOL(dma_fence_init_noref);
> +
> +/**
> + * dma_fence_init - Initialize a custom fence.
> + * @fence: the fence to initialize
> + * @ops: the dma_fence_ops for operations on this fence
> + * @lock: the irqsafe spinlock to use for locking this fence
> + * @context: the execution context this fence is run on
> + * @seqno: a linear increasing sequence number for this context
> + *
> + * Initializes an allocated fence, the caller doesn't have to keep its
> + * refcount after committing with this fence, but it will need to hold a
> + * refcount again if &dma_fence_ops.enable_signaling gets called.
> + *
> + * context and seqno are used for easy comparison between fences, allowing
> + * to check which fence is later by simply using dma_fence_later().
> + */
> +void
> +dma_fence_init(struct dma_fence *fence, const struct dma_fence_ops *ops,
> + spinlock_t *lock, u64 context, u64 seqno)
> +{
> + kref_init(&fence->refcount);
> + dma_fence_init_noref(fence, ops, lock, context, seqno);
> +}
> EXPORT_SYMBOL(dma_fence_init);
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index d54b595a0fe0..f617c78a2e0a 100644
> --- a/include/linux/dma-fence.h
> +++ b/include/linux/dma-fence.h
> @@ -279,6 +279,8 @@ struct dma_fence_ops {
> void (*set_deadline)(struct dma_fence *fence, ktime_t deadline);
> };
>
> +void dma_fence_init_noref(struct dma_fence *fence, const struct dma_fence_ops *ops,
> + spinlock_t *lock, u64 context, u64 seqno);
> void dma_fence_init(struct dma_fence *fence, const struct dma_fence_ops *ops,
> spinlock_t *lock, u64 context, u64 seqno);
>
next prev parent reply other threads:[~2023-03-13 7:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 17:35 [PATCH 0/2] drm/msm: Get rid of fence allocation in job_run() Rob Clark
2023-03-11 17:35 ` [PATCH 1/2] dma-buf/dma-fence: Add dma_fence_init_noref() Rob Clark
2023-03-13 7:13 ` Christian König [this message]
2023-03-13 7:31 ` Christian König
2023-03-11 17:35 ` [PATCH 2/2] drm/msm: Embed the hw_fence in msm_gem_submit Rob Clark
2023-03-13 7:19 ` Christian König
2023-03-13 14:45 ` Rob Clark
2023-03-13 16:15 ` Christian König
2023-03-13 16:43 ` Rob Clark
2023-03-13 19:21 ` [Linaro-mm-sig] " Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e3d4830-4797-8cc2-5882-02de44424ec7@amd.com \
--to=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®