From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 780FC3191A4 for ; Mon, 5 Jan 2026 16:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767631357; cv=none; b=j0uvJYhIO8BNXMQX9fb9Fxv4pLb2ACZzTnDqcxo3du2p5A0kmp8/efwRMpRcRM3UWThcF80OK4aakDbsKeKYv5xznJFpwA+USFQpmeH18f9skSznKwHpCa5jtctMpE5qAoTRAcT1VXkAa4f6q7xDTmCg1xOKoWB2p4bT970qG0U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767631357; c=relaxed/simple; bh=mkKV52rS9V/rVv9HyoagJL76fIzkWWOwWt6N6RN//C8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lmD8Z5wVW1gCXottsrzVnS9bkbcLeA90xubQpZlVrDjWfrT79cX7uYVJ87HvYeRv6M1K5OWBf/WtohXHa0FkXE9fj+XI2MR/ywYkxUwsyvNa7GFLOVfmuU6mhvCJ0IzDI/XnFw1hgOvJhtoKgHhDRZwKIFm/YHG/aGEiZnxYGRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TeMahRM8; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TeMahRM8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767631353; x=1799167353; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mkKV52rS9V/rVv9HyoagJL76fIzkWWOwWt6N6RN//C8=; b=TeMahRM8v6YGkY4/hk6ixTAWNnOYHqh20J/gYVnQGISWX7w8yWgIdRHl ufxrG+Vu25adAFvFlkox3RwXMjPw1weslh542jFXUlZkwAPwaa+hxWIQd umeCYP7CcLAS3CX62OW6Lmlm/PtKtdbLj806N/oHfP+pnrpxI+efxc4+e OrHZsFekVrldt+eAKq+GrUHRhuA2eKBGIi960mpGMHwdQUF7qrxEUGYT2 X5wwEpG182/Rn05Q+keNRaIdOTThq8xapUhmh3dhVdGchvjXH2CApkwrn 3XyPmIf5ZwaPpmq9ZVp/uRsubOFbp7bv1kffGIktglYaPeWmEfksUpE4f w==; X-CSE-ConnectionGUID: 5sYj+XpIQ16Ue3HgmJXFsA== X-CSE-MsgGUID: xZwZ/ScQSFOZKKqV7d5xlw== X-IronPort-AV: E=McAfee;i="6800,10657,11662"; a="79633142" X-IronPort-AV: E=Sophos;i="6.21,203,1763452800"; d="scan'208";a="79633142" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2026 08:42:32 -0800 X-CSE-ConnectionGUID: mBVz3cx9TjqjZ7q0DOXE/g== X-CSE-MsgGUID: ancu7yLDR2ia5xjF6dXRyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,203,1763452800"; d="scan'208";a="206912963" Received: from vverma7-desk1.amr.corp.intel.com (HELO [10.125.109.45]) ([10.125.109.45]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2026 08:42:31 -0800 Message-ID: <1e3f6c31-366e-41d7-8692-32c031383530@intel.com> Date: Mon, 5 Jan 2026 09:42:30 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] ntb/ntb_tool: correct sscanf format for u64 and size_t in tool_peer_mw_trans_write To: yangqixiao , jdmason@kudzu.us Cc: allenbh@gmail.com, linux-kernel@vger.kernel.org References: <20251230124656.4709-1-yangqixiao@inspur.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20251230124656.4709-1-yangqixiao@inspur.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/30/25 5:46 AM, yangqixiao wrote: > The sscanf() call in tool_peer_mw_trans_write() uses "%lli:%zi" to parse > user input into 'u64 addr' and 'size_t wsize'. This is incorrect: > > - "%lli" expects a signed long long *, but 'addr' is u64 (unsigned). > Input like "0x8000000000000000" is misinterpreted as negative, > leading to corrupted address values. > > - "%zi" expects a signed ssize_t *, but 'wsize' is size_t (unsigned). > Input of "-1" is successfully parsed and stored as SIZE_MAX > (e.g., 0xFFFFFFFFFFFFFFFF), which may cause buffer overflows > or infinite loops in subsequent memory operations. > > Fix by using format specifiers that match the actual variable types: > - "%llu" for u64 (supports hex/decimal, standard for kernel u64 parsing) > - "%zu" for size_t (standard and safe; rejects negative input) > > Signed-off-by: yangqixiao Reviewed-by: Dave Jiang > --- > drivers/ntb/test/ntb_tool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c > index 641cb7e05a47..06881047f5bc 100644 > --- a/drivers/ntb/test/ntb_tool.c > +++ b/drivers/ntb/test/ntb_tool.c > @@ -936,7 +936,7 @@ static ssize_t tool_peer_mw_trans_write(struct file *filep, > > buf[buf_size] = '\0'; > > - n = sscanf(buf, "%lli:%zi", &addr, &wsize); > + n = sscanf(buf, "%llu:%zu", &addr, &wsize); > if (n != 2) > return -EINVAL; >