From: "Jürgen Groß" <jgross@suse.com>
To: Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
x86@kernel.org, pjt@google.com, mbenes@suze.cz,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 6/6] objtool,x86: Rewrite retpoline thunk calls
Date: Sun, 21 Feb 2021 06:45:54 +0100 [thread overview]
Message-ID: <1e498602-5319-6f12-b33e-d40a7735d316@suse.com> (raw)
In-Reply-To: <20210220223221.GB4746@worktop.programming.kicks-ass.net>
[-- Attachment #1.1.1: Type: text/plain, Size: 768 bytes --]
On 20.02.21 23:32, Peter Zijlstra wrote:
> On Sat, Feb 20, 2021 at 06:41:01PM +0100, Borislav Petkov wrote:
>>> - if we had negative alternatives objtool doesn't need to actually
>>> rewrite code in this case. It could simply emit alternative entries
>>> and call it a day.
>>
>> I don't mind the negative alt per se - I mind the implementation I saw.
>> I'm sure we can come up with something nicer, like, for example, struct
>> alt_instr.flags to denote that this feature is a NOT feature.
>
> So you don't like the ~ or - on cpuid? ISTR we talked about
> alt_instr::flags before, but Google isn't playing ball today so I can't
> seem to find it.
If you want I can cook up a patch and include it in my paravirt
cleanup series.
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-02-21 5:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 20:43 [RFC][PATCH 0/6] objtool: Optimize !retpoline Peter Zijlstra
2021-02-19 20:43 ` [RFC][PATCH 1/6] objtool: Correctly handle retpoline thunk calls Peter Zijlstra
2021-02-19 20:43 ` [RFC][PATCH 2/6] objtool: Fix static_call list generation Peter Zijlstra
2021-02-19 20:43 ` [RFC][PATCH 3/6] objtool: Rework rebuild_reloc logic Peter Zijlstra
2021-02-19 20:43 ` [RFC][PATCH 4/6] objtool: Add elf_create_undef_symbol() Peter Zijlstra
2021-02-19 20:43 ` [RFC][PATCH 5/6] objtool: Allow archs to rewrite retpolines Peter Zijlstra
2021-02-19 20:43 ` [RFC][PATCH 6/6] objtool,x86: Rewrite retpoline thunk calls Peter Zijlstra
2021-02-19 21:55 ` Josh Poimboeuf
2021-02-19 22:01 ` Peter Zijlstra
2021-02-20 0:39 ` Borislav Petkov
2021-02-20 16:48 ` Peter Zijlstra
2021-02-20 17:41 ` Borislav Petkov
2021-02-20 22:28 ` Peter Zijlstra
2021-02-20 22:51 ` Peter Zijlstra
2021-02-21 9:54 ` Borislav Petkov
2021-02-20 22:32 ` Peter Zijlstra
2021-02-21 5:45 ` Jürgen Groß [this message]
2021-02-21 9:44 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e498602-5319-6f12-b33e-d40a7735d316@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suze.cz \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®