From: Thomas Zimmermann <tzimmermann@suse.de>
To: Alex Williamson <alex.williamson@redhat.com>, "mb@lab.how" <mb@lab.how>
Cc: kvm@vger.kernel.org, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kraxel@redhat.com, lersek@redhat.com
Subject: Re: [PATCH 2/2] vfio/pci: Remove console drivers
Date: Mon, 5 Dec 2022 10:00:20 +0100 [thread overview]
Message-ID: <1e4d62cf-8893-0bff-51f5-5a2e419ed5a0@suse.de> (raw)
In-Reply-To: <20221204175142.658d5c37.alex.williamson@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 3118 bytes --]
Hi
Am 05.12.22 um 01:51 schrieb Alex Williamson:
> On Sat, 3 Dec 2022 17:12:38 -0700
> "mb@lab.how" <mb@lab.how> wrote:
>
>> Hi,
>>
>> I hope it is ok to reply to this old thread.
>
> It is, but the only relic of the thread is the subject. For reference,
> the latest version of this posted is here:
>
> https://lore.kernel.org/all/20220622140134.12763-4-tzimmermann@suse.de/
>
> Which is committed as:
>
> d17378062079 ("vfio/pci: Remove console drivers")
>
>> Unfortunately, I found a
>> problem only now after upgrading to 6.0.
>>
>> My setup has multiple GPUs (2), and I depend on EFIFB to have a working console.
Which GPUs do you have?
>> pre-patch behavior, when I bind the vfio-pci to my secondary GPU both
>> the passthrough and the EFIFB keep working fine.
>> post-patch behavior, when I bind the vfio-pci to the secondary GPU,
>> the EFIFB disappears from the system, binding the console to the
>> "dummy console".
The efifb would likely use the first GPU. And vfio-pci should only
remove the generic driver from the second device. Are you sure that
you're not somehow using the first GPU with vfio-pci.
>> Whenever you try to access the terminal, you have the screen stuck in
>> whatever was the last buffer content, which gives the impression of
>> "freezing," but I can still type.
>> Everything else works, including the passthrough.
>
> This sounds like the call to aperture_remove_conflicting_pci_devices()
> is removing the conflicting driver itself rather than removing the
> device from the driver. Is it not possible to unbind the GPU from
> efifb before binding the GPU to vfio-pci to effectively nullify the
> added call?
>
>> I can only think about a few options:
>>
>> - Is there a way to have EFIFB show up again? After all it looks like
>> the kernel has just abandoned it, but the buffer is still there. I
>> can't find a single message about the secondary card and EFIFB in
>> dmesg, but there's a message for the primary card and EFIFB.
>> - Can we have a boolean controlling the behavior of vfio-pci
>> altogether or at least controlling the behavior of vfio-pci for that
>> specific ID? I know there's already some option for vfio-pci and VGA
>> cards, would it be appropriate to attach this behavior to that option?
>
> I suppose we could have an opt-out module option on vfio-pci to skip
> the above call, but clearly it would be better if things worked by
> default. We cannot make full use of GPUs with vfio-pci if they're
> still in use by host console drivers. The intention was certainly to
> unbind the device from any low level drivers rather than disable use of
> a console driver entirely. DRM/GPU folks, is that possibly an
> interface we could implement? Thanks,
When vfio-pci gives the GPU device to the guest, which driver driver is
bound to it?
Best regards
Thomas
>
> Alex
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2022-12-05 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 0:12 mb
2022-12-05 0:51 ` Alex Williamson
2022-12-05 9:00 ` Thomas Zimmermann [this message]
[not found] ` <CAEdEoBYZa9cg0nq=P7EDsDS9m2EKYrd8M8ucqi8U0Csj0mtjDg@mail.gmail.com>
2022-12-05 10:11 ` Thomas Zimmermann
2022-12-05 21:50 ` mb
2023-01-02 10:33 ` Shawn Michaels
-- strict thread matches above, loose matches on Subject: below --
2022-06-06 17:53 [PATCH 0/2] Improve vfio-pci primary GPU assignment behavior Alex Williamson
2022-06-06 17:53 ` [PATCH 2/2] vfio/pci: Remove console drivers Alex Williamson
2022-06-08 11:11 ` Thomas Zimmermann
2022-06-08 14:04 ` Alex Williamson
2022-06-09 9:13 ` Thomas Zimmermann
2022-06-09 21:41 ` Alex Williamson
2022-06-09 21:44 ` Alex Williamson
2022-06-10 7:03 ` Thomas Zimmermann
2022-06-10 14:30 ` Alex Williamson
2022-06-08 15:37 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e4d62cf-8893-0bff-51f5-5a2e419ed5a0@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lab.how \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®