From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2069.outbound.protection.outlook.com [40.107.243.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D36E78F2D for ; Thu, 19 Dec 2024 06:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.243.69 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734588509; cv=fail; b=kFJBl/Wf8ZY36KDt5FlgHueuxBK0Jlnx0ApKFhKhkwIKnDCpmMS66ZXWUjy1VomP1X5hrFCtb8E1pk4NNUvYCL03wDB50/gQODH0RyeXfiabR7joT2ty5nO3MTuVvlCqWLWdPz0piLYhTOCuVvQmeNWQS2xGezq7ijmREKoANFs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734588509; c=relaxed/simple; bh=+07xfBlqJ80Yx6mu6SWvtXAWBxcAWBY9YOrnP7qjcto=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=bLFG03InySBiQgzREtzg3nYfVKo3T6X4pCKR7vRWCP7ttNK2qwRyy9aZYMII++O0RMHRExApSjzqAgCThDF/7KZXR0ikdAwS0gOUTESqVTiVcihIHEtwkwK0+RrR/hNjm+vXYkDNCCGFO9MN3l4lZFu7j6UCuvP3gVk09qe7Nsc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=0szMrA8r; arc=fail smtp.client-ip=40.107.243.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="0szMrA8r" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k8gBO4kd+6l26pc6RBnFPn7KV9MLHODstEMkkdLtzaxz+L7i0gWQVDJi+d5HVgMjtZF8kZq1/bRqWv9+y1lNav0Zl4LYtxvOgM0zC5+b23EbXQcHB0CgehhR827OcW9pR5V+2W4MVlwygDlHZRRX4pCpPBblFY/KW1ff3QK/dd6GpfVvn8SfFWa8DOCCuYArJwx3We0CNAUs1VPEi3CJk9V+UOGCElwTmE5Eo25vU4noGZKxJkgEy2bEbfnFLVKaEWsPHTj2QSSGl4i+DXM3TT2tJdQFBhgUvBOofiItfDchYmQ3NFOGKZuvjlbAZQw2YpBCGFKcyOFfTX5HS3Bd+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgKAwzNixq5AFc8Qhyl5TLJKQuIgbxRpbeKhFJ7CudE=; b=pXEMgW7GQ5Q0KEJiY1s5JKLytyzxVqjxqctMzRdiLvZZPsJzLT/43qKAIKemBPP8vuCS9u0wFmdrpK5JbOR2h8QIvdsycjCqsRY84jo2vb1XGzS/KeOhkBWFradlu2KVjJbjMRLdAh+dZfZInH3FPj1Nn9U9Z/yW/qUaQCtblaACj9TynZcfT2QTTbak7x8SNJzUe6MJadPRcQW6IrNpLP9cvULcDPy+V7E+fTa3XpTltRAbJZEhkHapFlnzbPHI1PonXEFShYzNSuyWxMV5drAT+xTR2NL9en050cqt7VbDVibMt2slPncFqYf9Wy42hFj3BYSrI41fBRS60lnGFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zgKAwzNixq5AFc8Qhyl5TLJKQuIgbxRpbeKhFJ7CudE=; b=0szMrA8rP/MFuBbG3WETbqjE+2x3mnkbgAhU63RunT90ObbO2+iNHTClMtCoucr+To206gUajgMjI+sSOpuGVEdfI2OJxOfJHImrbPlhx94kHnY27Kx/qwIeiuewUBbjvogeKloz4r27lXvBOww2KaBWRAjVNQDZSoLjCoOmO3o= Received: from SA1P222CA0142.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c2::24) by SA1PR12MB9247.namprd12.prod.outlook.com (2603:10b6:806:3af::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.16; Thu, 19 Dec 2024 06:08:24 +0000 Received: from SA2PEPF0000150A.namprd04.prod.outlook.com (2603:10b6:806:3c2:cafe::8a) by SA1P222CA0142.outlook.office365.com (2603:10b6:806:3c2::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8251.24 via Frontend Transport; Thu, 19 Dec 2024 06:08:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SA2PEPF0000150A.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8251.15 via Frontend Transport; Thu, 19 Dec 2024 06:08:23 +0000 Received: from [10.136.33.103] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 19 Dec 2024 00:08:18 -0600 Message-ID: <1e4f3521-7253-44e1-bd63-616a18ea89df@amd.com> Date: Thu, 19 Dec 2024 11:38:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] sched: Report the different kinds of imbalances in /proc/schedstat To: Peter Zijlstra CC: , , , , , , , , , , , , , , , , , References: <20241218043629.1142651-1-swapnil.sapkal@amd.com> <20241218043629.1142651-4-swapnil.sapkal@amd.com> <20241218114003.GL11133@noisy.programming.kicks-ass.net> Content-Language: en-US From: "Sapkal, Swapnil" In-Reply-To: <20241218114003.GL11133@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF0000150A:EE_|SA1PR12MB9247:EE_ X-MS-Office365-Filtering-Correlation-Id: b2288f36-d805-4e65-f139-08dd1ff38bad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|7416014|376014|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RXhhR0h3ck9VdTFtSFpGRnVnYzJOQVMvVFZlbWpaN1lqYUIxWW0zM0Nac0hy?= =?utf-8?B?a2NvWU9mYVpRUEMwYWdMbElkeGU2ZTFLUXByMFAxWlQ0WUNQZEx2Vzd3S2p6?= =?utf-8?B?aHNMMHYrem9EK014OXh6dHVzVXZ5VHdJNUM3bkY5Z3R6YlNWR081dGRvbzZE?= =?utf-8?B?MkdrbUV3ZENZbHVMZmsyQnBxMjliaTNDY3AzQXlwN2F1dVpCUzNXV0kvSzJp?= =?utf-8?B?bE5nbWNYUG5ZZ2luZmlyZ1Q0SDE4TE1FWlNETlEyOWlLVkh4d3RHRkM0bzcw?= =?utf-8?B?V2ZLaHVEdDFVM3YwaHByUkNzQW9ncXgzVVIzR1JtYmNKVU9hVk1nclNQR0Rl?= =?utf-8?B?UnlvN3B1eVNkYlMybkhQZjVOOW03dzlDQXdQeENqb3ZNSnlDYjV2YlpGZ0Zy?= =?utf-8?B?bzdVQis5VzFCOTh6dktiNmNkeG5ta1BOcTlJVWxTb05kZTZhcnFyM2Y5Vndx?= =?utf-8?B?UWl1NmY1bDR6U2FMK0VZVldpdWVydk16dzhpUFpySWRTT291KzlabTBPM3R3?= =?utf-8?B?UXN6RVBXeFJvT3FuRHhrdHpoa2tjblJBU3daWTNNZ3lESUVuL2RDTzU2c3NX?= =?utf-8?B?c3hmWUJxWGpaUFV0ZXdiKzZSUzhEbExyd3ZWMkJkYkd0a0VPWmJFRFhmZDZl?= =?utf-8?B?RmlEcWMvR05pWGxuTnRoZmVTc0JJMzhkOWpYTE1Obk1lL1hSTGt1M1p6b3J5?= =?utf-8?B?WUhMVUxubHBuMGZ4UlVYanZKdXdMUXM3cEF4cnZEbW9PMlpWSFNSN0d5Nndh?= =?utf-8?B?TDFEU1A2a1VZd0E5dm53d0lVeWZnTnZKUlB6aXFVNTNvUmVzVzU1SHVjOGY2?= =?utf-8?B?UXk5cWE3ZzZLVHpvR2Fqb2lsSUlTcld1dDNuRTg1QjVDb1BiZVNESFE3bGIw?= =?utf-8?B?MVIwb0o1OGVyM1p2SUl6V2lvL25ZbU5HQ0U1bi9jNFkvNkVzcklDM3JOQ1pw?= =?utf-8?B?cnRqd0JkbkJoYkJUazVueXJvTTFlSVNjZ3dCeGVrakVxVkxIVnJZVUhOWnZ5?= =?utf-8?B?SHVVVlBTYk03YU9DTzV3ZUtWVndlQ1c0TzhzTmpXMDUrTjBtR0VoVjUyMno5?= =?utf-8?B?ZUNlcElzS21KTjVVcGdaQ3BWcTBvN0p3aERkZDJMcHZ3dkNMMUsxei8vMk1Y?= =?utf-8?B?c0ZmZkxSak1hdU1CUDBqZGZUR2tObTNoNXAxcXdONG9qZVNwelpLTHQ1MlEz?= =?utf-8?B?VkJqelJiSmVYVDlaL0hNZWFWVjljSGpIUDF4dzdJenBSMlhOTDNLRkJmWW5Y?= =?utf-8?B?MHFTNm1MUUVGeGc0dy96TEZxdjNXMC84bEJTYTVJR0RtR1pLNTByL2FDZlFH?= =?utf-8?B?aGFmSHovUVlQMTdIaTFnRTJxTzdKb2NsOGF1Wmw2R1pKQ2ZqTzlEQVgrNEsz?= =?utf-8?B?Z3kycGdTclo4MU5pejhKNzNFQm5Qd0JIV1Q5TlBHTmFQaDhnaks3N1gzNURr?= =?utf-8?B?S205dFYwUU9lSmltU3BHbGxKWjlxbkxKTUphbGViazhQalZ2cy9tSTBxczZ6?= =?utf-8?B?Q0JBSTBuOHRPKzNOeWFRZmVGeUgweXRoak84bk1Ybnk0VUJ5YzBEWStSdkNn?= =?utf-8?B?K1JnU2l6WHBZYm1JQndBemIyREhxRFpMUTJJYUpjQldSMHI3bFdMWlE3ZlRl?= =?utf-8?B?akVMRWM2MUdzMzVidVRKQjRzMEdNMSs1WC92T3QxNXdzWXQvS2IvMVVpSXBx?= =?utf-8?B?NDNNdVV5N1RLeFJCd0lzWUorUWxhdnEzV292QURmbmFMK0pDZlMreVdwQnRJ?= =?utf-8?B?N2xsQzdqcUVXendqN1VDMjNkQ253YXA3UEhiWFBKNHVRSTNYUmZCWWtKa0Iy?= =?utf-8?B?aVJEZlVUcGo3MTBvdUhISTVIM2VBV2gxczFuazlPRTduVGRYRFU3aEU3VUpV?= =?utf-8?B?SnVjWURRdlNYVE9hVnFoV0xnUGVyRmdEcHMrb1RJQW1NNVZpZ21rdVBBOE9w?= =?utf-8?B?eStQZDlLTi9HZjJvZTNlekpPZGQxUUZSY2owSHVCTkJKeEJ2Vm0rZzhMTWxC?= =?utf-8?Q?yLnFeeGPoZicqXQj/SXZjHX7tkUpTA=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(7416014)(376014)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2024 06:08:23.6487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b2288f36-d805-4e65-f139-08dd1ff38bad X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF0000150A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB9247 Hello Peter, Thanks for the review. On 12/18/2024 5:10 PM, Peter Zijlstra wrote: > On Wed, Dec 18, 2024 at 04:36:26AM +0000, Swapnil Sapkal wrote: > >> +static void update_lb_imbalance_stat(struct lb_env *env, struct sched_domain *sd, >> + enum cpu_idle_type idle) >> +{ >> + switch (env->migration_type) { >> + case migrate_load: >> + schedstat_add(sd->lb_imbalance_load[idle], env->imbalance); >> + break; >> + case migrate_util: >> + schedstat_add(sd->lb_imbalance_util[idle], env->imbalance); >> + break; >> + case migrate_task: >> + schedstat_add(sd->lb_imbalance_task[idle], env->imbalance); >> + break; >> + case migrate_misfit: >> + schedstat_add(sd->lb_imbalance_misfit[idle], env->imbalance); >> + break; >> + } >> +} > > > Can you please write that like: > > if (!schedstat_enabled()) > return; > > switch () { > case ... > __schedstat_add(); > } > > It makes no sense to have 4 copies of schedstat_enabled() inside the > switch statement -- esp. since afaik the compilers aren't able to CSE > static keys :/ This makes sense. I will update this change in v2. -- Thanks and Regards, Swapnil