From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7795E340401 for ; Mon, 1 Jun 2026 06:26:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780295184; cv=none; b=Z8TM12T+3u5zHmv21oevHfWQlRyfdo+wsXN4nyXD5MHpHUt9EILqWKcyWkd6jSgbX0E9N/zM0rdIAUs/vfw+/o0wh4lRRRdDDccgKQoQwmTXNCLyNx1l4Xab8uxCdr5719bq2BZnSTVvmNPoR2haU1VgeLw5ANPREbNT9WKDJ/s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780295184; c=relaxed/simple; bh=3+mbuSOPINRIL9Kin6A2TyWfF8smoqgqWi2QxpvIA04=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c1W3vwXSTX4q2SpBsWUxK1Yn2pE8bNPAdXsDdtkS9KqZyT/ed24Rd6Bq+jHoPOrwAMWxkQWYnvXZo7J67rDWb4SgQtbaSzMiElGiTM3lNdAJ/2pOuTRUj2ONnzlD31ZZFGX8n+PFN4i20IaaRNMyYqUp6JXTRRPAm2L5W8kNavQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=UDWGUBrq; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="UDWGUBrq" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 88BA0267F; Sun, 31 May 2026 23:26:16 -0700 (PDT) Received: from [10.164.18.45] (unknown [10.164.18.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E34D03F905; Sun, 31 May 2026 23:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1780295181; bh=3+mbuSOPINRIL9Kin6A2TyWfF8smoqgqWi2QxpvIA04=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UDWGUBrqwtsm4H1kD96qnayD0Gt/6wSVCIxG5vO5Csj9ooOqWdtqv2TeXpxpgnnkD JaX1+6lMgNLdmd3e7hD13QzppuwXLD7Jmq9oTWar6RVvfw6ik0y113eW97KQYI2P0g dygsfiUREkcoUVD64lZgCrEQV8KPI7LXd7k6GL/w= Message-ID: <1e50b8f4-22ae-4ff7-aac9-fa3242bb23ca@arm.com> Date: Mon, 1 Jun 2026 11:56:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC V2 01/14] mm: Abstract printing of pxd_val() To: David Laight , Dave Hansen Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Ryan Roberts , Mark Rutland , Lorenzo Stoakes , Andrew Morton , David Hildenbrand , Mike Rapoport , Linu Cherian , Usama Arif , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20260513044547.4128549-1-anshuman.khandual@arm.com> <20260513044547.4128549-2-anshuman.khandual@arm.com> <74f66e30-ab3d-4352-89ef-1bccc7e9daeb@intel.com> <20260521104206.1c7d3fe0@pumpkin> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20260521104206.1c7d3fe0@pumpkin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/05/26 3:12 PM, David Laight wrote: > On Tue, 19 May 2026 07:28:17 -0700 > Dave Hansen wrote: > >> On 5/12/26 21:45, Anshuman Khandual wrote: >>> if (!p4d_present(p4d) || p4d_leaf(p4d)) { >>> - pr_alert("pgd:%08llx p4d:%08llx\n", pgdv, p4dv); >>> + pr_alert("pgd:%" __PRIpxx " p4d:%" __PRIpxx "\n", >>> + __PRIpxx_args(pgdv), __PRIpxx_args(p4dv)); >>> return; >>> } >> >> That's not the most readable result. Could a printk() format specifier >> make this nicer? Maybe use "%pT"? >> >> pr_alert("pgd:%pT p4d:%pT\n", &pgd, &p4d); >> >> I _think_ it could even get rid of the p??v variables. >> > > Adding another %p variant that is only used in a few places just makes > it all harder to read. > Perhaps a local helper that lets you do: > char pdgv_buf[??]: > pr_alert("... %s ...", ... fmt_pdgv(pdgv_buf, pdgv) ...) > might be a reasonable compromise. But will not that also create a similar code churn as adding %p variant ? As mentioned earlier a draft implementation could be found here. https://lore.kernel.org/all/1d694f9d-4f40-428b-aa28-9d6e0febd54c@arm.com/