From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76724379C22 for ; Fri, 22 May 2026 19:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779477987; cv=none; b=L1gJ1qpmeqaHzv63J1p9sCroNSEQKRpdYAsftafQ/OLBIM5b76UlwAGnB8INFJPtBYRev2EHeD27FsLw1DAmwA+Aaj7L81PT6lHAzvbOmIDff3L+BQDiz1uG96qMp23uaXFNRVwCgzOxwlJUtl1PrV7p0/BFQOZQLFrDbqSaG7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779477987; c=relaxed/simple; bh=wYqSJYotgMtie8NqUqcfDaB+2/iM5ldwntrcWEsF+A4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=efQo+NiFgXFdvS/DsDQpVZh4ilCzznGlb9M37zacRRnFQUuI7DOO3m9xDmmaQvQ/ajHQwrfRuFO518c/BcrMJqtYdzu5MKwDX2cDjHmd4PI4KQ3Sh/pHjSLicoTsseg2KvvqOSl+qjOgMYjP324f5snZNETYmcsBmjOnn0t3sgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GP6PT/Ft; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HHuxchNt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GP6PT/Ft"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HHuxchNt" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MFv9hR3005107 for ; Fri, 22 May 2026 19:26:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +61W1UOtIsgDmPVeff6jHolvzf9011GZ05wsL11zWSw=; b=GP6PT/FtYTQcfpYy th0UN83zLAZ6yKe3BkkIhAFlKGrFCMJUk5uTpyJz7RfWVSOG9fXmxqh0ud2F/Y6v rhyjg7S0B1YE95T3OpjR1kKQifJ8WkJwJgJ9lcsmkkgq2ZtMDuZjd/YIblIdVIcj VCwBmq81cwfzEXWYZ79rVhZ4pHsfB0ttf+nyxnHH/5mHR7dDWvLCY66xC+409f5c mIpd1ldoXyAMatROf2XyWBN9OFExdWjENbvEPY0YiXrnTwZj3FNnFzgKBTcDGAfz HSpT/wGwlCEoBwpl+48tQO2rVfZyQwrCyCtvg6NrsO0bINB9BUgv/u65px08WINX huGXhA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eafrtbkv8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 19:26:25 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b458add85aso83293455ad.2 for ; Fri, 22 May 2026 12:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779477985; x=1780082785; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+61W1UOtIsgDmPVeff6jHolvzf9011GZ05wsL11zWSw=; b=HHuxchNtoQ0l1Bkxnyjfg8nuOE4UIOX8B1cTNHu+biclxjiprP2KkEyCtFkN2J5Ogi nM+/j03Vzn1KTv9facVmmhfuSuffgjtZpfSmvJmXPxKl4sVi7qpidGcX5sp3FHW0jHV0 SHeE780cVTFIvvRfdCEQj0qre9Xpir5P1HLB0T0sBMfi1smHxNuffcxW/oXZkNsxveR6 opZ5DQozULl3pIuoNMIwChGHiMawZBIzYSKCE5RY4rN2KLu7nhoSNzSTG6gnvSTnTfDS MRGeqiTjPwOwfIx77Cem2DBacNm4MY6BzXBmAn+DGlWra4WE6tskhvKo0+LWe7h0TMZG CEjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779477985; x=1780082785; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+61W1UOtIsgDmPVeff6jHolvzf9011GZ05wsL11zWSw=; b=lYYK1Y/oDUTci2+sZN6K0OyvCcaQS8OM8phxBSkIaTpuWLVA6WRCqv4WS05rTDc259 d2UZwD56Cw+K1Z1QFoCPAOo3E6uLKwOJYaM8FxAsFRizhqo3Ey62aJGY7Fwv2KSCFVGc JkHTSMV9O1ZdXMjSmejn7hft7kss1u7/jbyEkRvCWnMlf0kCh+UU9nWpvlDQhdwxf0tn 6+ryXXjmHv8In4UllkpZ5FgavIsSHpf/oxVuW0v3SFci/1RPWhN6TA2l/eGeHuhtAbkh EcRmrJf/2e5FX9ajuYAWQ1FR6eTQTr1LzV7PQtwxXwfJKBTrkbf7xp4pKe6/w820n1wW YvhA== X-Forwarded-Encrypted: i=1; AFNElJ+nr+iY2CJXUaBaMOXQ/aQiz9YQz/0vs+himLpWcK899xzQBICWeM7F2/K832/ME0VT8XUtFIT0VFF81Pg=@vger.kernel.org X-Gm-Message-State: AOJu0YyPIgXbDD3HM2a5EKJ9/WQ84xMJm5W1Vlj6ItFLXC1zVWxYTX0Y I4BANump5XdIXTf1+q19CAN70e2tnKo5vunajyPamPNEZTFjBsrQ7g/vcjwm+E/8I3wdjermZ3C K53Vf9Fo3+rq7eVGKzKM1d80tUsXH+rhHnGIRVj1HkyCsYy+UgNG/uZ6CFaU66+25jAA= X-Gm-Gg: Acq92OHSwfS53jL/Hk4IyQyNOwY6AoCjkB5SKDgh8rNqZKaRN+5s0dJzWCI8KrW4LkV 7LvfOK2drDay3aEg6928a7tgyV37fLzrCERZ2xmuXTCiJMI/qkDekWH89iNq4feNoyTT+jpYFx6 gqB+7h8/DxB04Gt6j0I3Geo7v2tmaRCDmP9RNEqMX4zmkemcEi7JecF0TpXVSZKpXdW145kFYHR IUmoVyskYp/fMK0a7ow1ejW2uh3A+J1bndp5GHiIK8zyu4w7kAZ72BGxkR5lYla38zNjMUSDQtC IYBk7puRgA1e95LdUAQPZz8iMFKmo0qhVY5t6jOKkDBkEn1bQfKCahwNrjk8KFG8jUA9tgncP6G kz0zslJhJpLc58jd/qsyWO5IalGt7t+W03aX2vF9oesc2xEAr7Q== X-Received: by 2002:a17:902:e785:b0:2b4:5f96:184d with SMTP id d9443c01a7336-2beb05a4873mr50117205ad.5.1779477984883; Fri, 22 May 2026 12:26:24 -0700 (PDT) X-Received: by 2002:a17:902:e785:b0:2b4:5f96:184d with SMTP id d9443c01a7336-2beb05a4873mr50116935ad.5.1779477984437; Fri, 22 May 2026 12:26:24 -0700 (PDT) Received: from [192.168.1.6] ([223.230.21.136]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb56ca7fcsm24750295ad.27.2026.05.22.12.26.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 12:26:24 -0700 (PDT) Message-ID: <1e54db48-e618-4525-abf9-ee65d0a1b71d@oss.qualcomm.com> Date: Sat, 23 May 2026 00:56:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Konrad Dybcio , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com References: <20260522073324.e18bb240b6f6@oss.qualcomm.com> <20260522130459.3411038-1-ajay.nandam@oss.qualcomm.com> <9e8c0351-0168-4d94-8610-cf2cc2f030f0@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <9e8c0351-0168-4d94-8610-cf2cc2f030f0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=JN0LdcKb c=1 sm=1 tr=0 ts=6a10ade1 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=dyxLLOf8pC0bdfPLpLFr6A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=UFEU4FUi6niC1vJbelAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDE5MyBTYWx0ZWRfX8DyCCb1BSOwi D2jqw5PhEYewVpv1sJtAFwxgc2knTsbxKbXhvNhYSFyPkvEry22pI5501jMDXWszyWa3wTU0dXg /ycMB1Ffe+U1j9v8iQWywx68DMXUy0b3VW3fBO7Sbodatm324MY+duD48QC3F3qJqjPuHc9DExT wHb1hzY6LrVRFzBxfV8kTDatC6Tp2F3/lzD0aGPgShFacmlgG53vVlHnEPjWw5UTlRb4Tffkjpu yTwJWfu/UT5BCSauN1AUGqrHqIC7LZf88aW8zaru2AtdkYxd0ZNWVG8sGLFMCrwzC0hPKj8qxGo CkfB8eOOLuyFjhjpgk5YycqqA/JcNx6Z+1ZPbGyJxCR/j6zqjVzmcmg1e0zvdDOPaJuYnm6ulgO S57dPBk+t+TvYn7e2gHIyc2HHxGOh6WPNdb5a2m1egjecXXRegqOQlDpu9up72V0BLOk1nwS/Zc UZAQmeMWZX49dffz6xA== X-Proofpoint-GUID: ceHZ3IfK3cfkYpJaj8T5mTqGXmW1zKar X-Proofpoint-ORIG-GUID: ceHZ3IfK3cfkYpJaj8T5mTqGXmW1zKar X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_05,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220193 On 5/22/2026 6:55 PM, Konrad Dybcio wrote: > On 5/22/26 3:04 PM, Ajay Kumar Nandam wrote: >> Convert the LPASS WSA macro codec driver to use the PM clock framework >> for runtime power management. >> >> The driver now relies on pm_clk helpers and runtime PM instead of >> manually enabling and disabling macro, dcodec, mclk, npl, and fsgen >> clocks. Runtime suspend and resume handling is delegated to the PM >> core via pm_clk_suspend() and pm_clk_resume(), while existing runtime >> PM callbacks continue to manage regcache state. >> >> This ensures clocks are enabled only when the WSA macro is active, >> improves power efficiency on LPASS platforms supporting LPI/island >> modes, and aligns the driver with common ASoC runtime PM patterns used >> across Qualcomm LPASS codec drivers. >> >> Keep the SWR gate runtime-PM reference from SWR clock enable until >> disable so autosuspend does not gate clocks while SWR is prepared. >> >> Add a PM dependency for SND_SOC_LPASS_WSA_MACRO so PM clock helpers are >> available when this driver is built. >> >> Suggested-by: Mark Brown > > You added this tag, but was the entire content of this patch sparked > by Mark's suggestion? Apologies for not including the Reviewed-by tag earlier — that was an oversight on my end. Thanks Ajay Kumar > > Konrad