From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF52C7EE23 for ; Wed, 7 Jun 2023 15:09:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241245AbjFGPJT (ORCPT ); Wed, 7 Jun 2023 11:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241203AbjFGPJQ (ORCPT ); Wed, 7 Jun 2023 11:09:16 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7EC910CE; Wed, 7 Jun 2023 08:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686150556; x=1717686556; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dkmBvMVEaR9WNW+FaDgHJkj5zFLkk93xq/0IXE9EB+g=; b=MUffKpnwGQiDtCmRZi0aPpyVYMgc24omjp7rpIKBn9Ga4PJD6wlp1dt6 bxhe1l5EzWZR25HziAp19BbbsnPykFfhI5JySryuHebDCkYgO+NF2c/VK 5QPiExBBAkC+PpxeXg/fcbdJ4tKXyehkUqLbcm/4upnMHJbhzlZqur5rJ 59/NUFEA64EchBlM1HszA/2g77RCYR8207MA9Ht9VIFjERdYryiqFPeCt Lz0OobH6ZVVWuIBTY3OFAl4LZ7ZCCRjE560DFWNZT/qTq88t1U4koMayZ np4L8GdS6kG5uKa+BrFWnATqEarfxyndIz78RPkHQKFjehCxBWbMTpU5K w==; X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="337376317" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="337376317" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:08:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10734"; a="687032427" X-IronPort-AV: E=Sophos;i="6.00,224,1681196400"; d="scan'208";a="687032427" Received: from vsmyers-mobl2.amr.corp.intel.com (HELO [10.212.146.233]) ([10.212.146.233]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2023 08:08:48 -0700 Message-ID: <1e58e3df-ae9a-607c-cfc3-4f3d033ed531@intel.com> Date: Wed, 7 Jun 2023 08:08:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v11 06/20] x86/virt/tdx: Handle SEAMCALL running out of entropy error Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <9b3582c9f3a81ae68b32d9997fcd20baecb63b9b.1685887183.git.kai.huang@intel.com> From: Dave Hansen In-Reply-To: <9b3582c9f3a81ae68b32d9997fcd20baecb63b9b.1685887183.git.kai.huang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/23 07:27, Kai Huang wrote: > Certain SEAMCALL leaf functions may return error due to running out of > entropy, in which case the SEAMCALL should be retried as suggested by > the TDX spec. > > Handle this case in SEAMCALL common function. Mimic the existing > rdrand_long() to retry RDRAND_RETRY_LOOPS times. ... because who are we kidding? When the TDX module says it doesn't have enough entropy it means rdrand. Reviewed-by: Dave Hansen