From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E9B043DA2D for ; Wed, 8 Jul 2026 11:16:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783509408; cv=none; b=ZPOZOizZCwGvVFP3K/2OwplhWBgnzcvvt2McRY76c+g/VDOQJ5Vl1I6s7xFNzoIkmZBIasZog0nuZRMO7H3lCsVG4hN9aI/BvxJrqPY5+q8Rq6DwsbHVyk3OPQ5pXi39WDdkmpSHl/mnfjtJ4kt7+Th/Z1+0f7TUusU2GinhcNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783509408; c=relaxed/simple; bh=Yu1IpyuYYUzbf+7marfaBTnzx8BbEm2oTotGiN4NhcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nlNeTVGkt+yuUTKnPeeNsLO0dX49fqkPs36bnYsSmOWEZv35M2U9I8ekKeQEHglZLKZx2lKhtdYOfBWL8F0sUM0b725HV6AZ+NR81XZFu3aoaoLrmrJSX/y5bfwCulXr9f1I0xxo7fbKiJIVnf47zz7QG6HFGgSUnU+MA7OjR3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=PUaGX1ak; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="PUaGX1ak" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493c1950518so10805325e9.1 for ; Wed, 08 Jul 2026 04:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783509402; x=1784114202; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MG3FU7CU4B5nmUNJ9cOdrHELZIlUEf3pKuMQh8F7+AE=; b=PUaGX1aktrSfTZFF6mtBu4n/Vu2vygHIrloZLx93iz5V1nmkIXSZ3A3mbjFvCrSaQz ytHZzw8GLfydpyjAdBukaZLzMW4HzJKc80qg6VEwvzDEMHCT/5keYxEcQc1ClXVMGUeP 4C0vdsMIJuVSEtLAdsApIcWoQ7UXlXSzuIY3jJo/gr0qlubUI7oiiDPZ+/zgAhT/0WBj qnajftNo3Iqbf2rwNiAB0fPwJzpHdUmZdfYXgXPJqqHtgE8IPNx9kY9II+UeQxzRW6/p PUlRt5u6eXcJ8AmRKBo4NKSwD5fYuTs7vWbfdkyLPvkagzpj41vcpYubHJos1YzQeOeU eRxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783509402; x=1784114202; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MG3FU7CU4B5nmUNJ9cOdrHELZIlUEf3pKuMQh8F7+AE=; b=lDkSOePHLIbuFw/Da8V+dDpMNMSlrFMEUv1nh6MufMm35qtK7cAINtJbzy6xkRMJU9 D9ryvy4DoCBVopwq+y5g7qJetZudh8jEdq9YWBIuSyRVC8zbLUwHe6buT80GNyiDUspq oRHnc5C+JU/9kr3rbOCWTMVLJw0L4f2LWUfo2mCFdU7R5ODC/4t4QWf30tduZxki54nQ h0jE/yg/nO7X99vUjm4dtcicUgeDefMBn6MoGwuSPwcS6EyMXrPaapBPNR8LbzFFUipi uv4bzCHD4oTS8fuEvjn61Wl3hqDV4L1FJfPfhZ0w+g47+4Kw/wGchytrE5jpVEyx2p21 woQg== X-Forwarded-Encrypted: i=1; AHgh+Rrk12Ky/uuEfUCvIx7Xo274/qNvWSCfLor41lumj0t5lGFozEwS5gI/qkdoWEQ4EZC56KGbv22oOE9e+kc=@vger.kernel.org X-Gm-Message-State: AOJu0YwQmeAKi/eg1FwbAjSUcnStaFUtkDHT0cxohribn7c++i/95wvD Mjc9L0zh7/gCc6qBKS9slZ9XqrCS4TUqGmMcIDItdl+NYJTyMOQD2wTZXZTfL3DRvbc= X-Gm-Gg: AfdE7cnvHztNKksJeKuqi7lbjM1lo26wp73GyXYoYZLc2tJl4bH8UV16+Sc//EtBxx3 siFGM5cdtjrj6jcICzM4RzDF+WPD+Aooua1+9OFKIrexkKRaEnaHvgODjj6XAibD75cH5vNYf0v d04ZpuRAKFJ4//ZTeWq2Nvh3SOEagvmFXldRoBw8NpfnLMMk5+1Y7iGJnsL0UlFI6sSVWRXushS c5rhedtDNguHHrjhVAOl8Y8OFSH3oa+cyp+oM/iXlfjCLPFRXtzAn2AcS57nN4x3rKUHgEu7LYx 6wkML+HHG1n0+YSyEAEDcGGd54zK8x9FDDxkMop1vcA9yKOKuiwpWOu8lZ8d+UCnhNvP0My1Ga0 MG8EJnQ0AakJE6KAHJ7ZZSD3GrrNn6y2J5gcIvjsT3JWpDkc7sSJed82bN7iKSyrT631r+zXc3r PCFGdXuxN76+jZWO9eRfwzQ4H0Y3dnrDj3WGMq+T1zJWaCIdbiDNS26+R7FAdND2k2j0AY1XYVw dDBKpLQu3SA2LU= X-Received: by 2002:a05:600c:3f0f:b0:493:b698:9247 with SMTP id 5b1f17b1804b1-493e639ac57mr22213845e9.14.1783509402127; Wed, 08 Jul 2026 04:16:42 -0700 (PDT) Received: from localhost (p200300f65f47db04930dc5bd4534e1e5.dip0.t-ipconnect.de. [2003:f6:5f47:db04:930d:c5bd:4534:e1e5]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-493e0f3677asm117598505e9.4.2026.07.08.04.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 04:16:41 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Lee Jones Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/23] mfd: lp87565: Explicitly set driver data for the generic dt compatible Date: Wed, 8 Jul 2026 13:15:11 +0200 Message-ID: <1e596fe18a6bd2ea363be3615eb512dff9bd18a2.1783507945.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.55.0.11.g153666a7d9bb In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=1832; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=Yu1IpyuYYUzbf+7marfaBTnzx8BbEm2oTotGiN4NhcE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqTjFHXlx4zbiyHUGpu54qoXkdQvA4zDSLokcFY YZ8zdDsYEiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCak4xRwAKCRCPgPtYfRL+ Tia7B/4xXw75inKIMzDsPHwdqaJzz+1U/mpy8zjSpa6b7AJX8VvWZSLnP5VwNdpKapxrbFydSav E53QSn1pY0SyGOJFdYgWgYV+ZVyWB1a7FHeOGkqdOx2nsa+hsXS3ppy49Qt3hUYSckUx2AWxunc YMbuuqAqeyzTEN9ES1E/ZfOr2aBtDpvmAWQ7h6x7yuYJe5doGVX/ZQF3VVSCMezOUoA09bna9io FiWwtJ8lZbc3AnlrvA4NVZpMQhtgrSAHJvkjb9HSvdQk4wOj6SSBLmujuvova+mqU1W+wL6GfCa zASHiQXM4n3pUUtefd/fF9Mv60SnxVh5OD6w0FiW52NZQAHk X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit The driver relies on .data being (void *)LP87565_DEVICE_TYPE_UNKNOWN (i.e. NULL) for the generic device tree compatible. Make this explicit. Signed-off-by: Uwe Kleine-König (The Capable Hub) --- Hello, while I'm sure that the driver is improved by this patch, I'm unsure about the handling of the generic dt compatible. E.g. drivers/regulator/lp87565-regulator.c has: switch (lp87565->dev_type) { case LP87565_DEVICE_TYPE_LP87565_Q1: min_idx = LP87565_BUCK_10; max_idx = LP87565_BUCK_23; break; case LP87565_DEVICE_TYPE_LP87561_Q1: min_idx = LP87565_BUCK_3210; max_idx = LP87565_BUCK_3210; break; default: min_idx = LP87565_BUCK_0; max_idx = LP87565_BUCK_3; break; } so if "ti,lp87565" is used for a one of the explicitly handled types above, wrong/surprising things happen. I don't know enough about this driver and hardware to suggest a better handling (apart from maybe just dropping the generic compatible handling). Best regards Uwe --- drivers/mfd/lp87565.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c index b78ae79df5fa..efea1ba82811 100644 --- a/drivers/mfd/lp87565.c +++ b/drivers/mfd/lp87565.c @@ -26,7 +26,10 @@ static const struct mfd_cell lp87565_cells[] = { }; static const struct of_device_id of_lp87565_match_table[] = { - { .compatible = "ti,lp87565", }, + { + .compatible = "ti,lp87565", + .data = (void *)LP87565_DEVICE_TYPE_UNKNOWN, + }, { .compatible = "ti,lp87524-q1", .data = (void *)LP87565_DEVICE_TYPE_LP87524_Q1, -- 2.55.0.11.g153666a7d9bb