From: Luo Jie <quic_luoj@quicinc.com>
To: Markus Elfring <Markus.Elfring@web.de>, <cocci@inria.fr>,
Catalin Marinas <catalin.marinas@arm.com>,
Joey Gouly <joey.gouly@arm.com>,
Julia Lawall <Julia.Lawall@inria.fr>,
Marc Zyngier <maz@kernel.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
Oliver Upton <oliver.upton@linux.dev>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>, Yury Norov <yury.norov@gmail.com>,
Zenghui Yu <yuzenghui@huawei.com>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kvmarm@lists.linux.dev>,
Andrew Lunn <andrew@lunn.ch>,
Kiran Kumar C.S.K <quic_kkumarcs@quicinc.com>,
Lei Wei <quic_leiwei@quicinc.com>,
Pavithra R <quic_pavir@quicinc.com>,
Suruchi Agarwal <quic_suruchia@quicinc.com>,
<quic_linchen@quicinc.com>
Subject: Re: [PATCH v5] coccinelle: misc: Add field_modify script
Date: Wed, 25 Jun 2025 14:26:52 +0800 [thread overview]
Message-ID: <1e5c1c96-b76c-4e2a-ba50-f914e94b142d@quicinc.com> (raw)
In-Reply-To: <e694666a-ec94-4443-bae7-54ac2f0f0e7d@web.de>
On 6/24/2025 9:54 PM, Markus Elfring wrote:
>> +msg="WARNING: Consider using FIELD_MODIFY helper on %s" % (x)
>> +msg_safe=msg.replace("[","@(").replace("]",")")
>> +coccilib.org.print_todo(p[0], msg_safe)
>
> How do you think about to use the following code variant instead?
>
> msg = f"WARNING: Consider using FIELD_MODIFY helper on {x}"
> coccilib.org.print_todo(p[0], msg.replace("[","@(").replace("]",")"))
>
I think your proposed variant is a better alternative. I will adopt
it in the next revision. Thanks.
>
> Regards,
> Markus
prev parent reply other threads:[~2025-06-25 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 10:26 Luo Jie
2025-06-24 13:54 ` Markus Elfring
2025-06-25 6:26 ` Luo Jie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e5c1c96-b76c-4e2a-ba50-f914e94b142d@quicinc.com \
--to=quic_luoj@quicinc.com \
--cc=Julia.Lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=cocci@inria.fr \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=maz@kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=oliver.upton@linux.dev \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®