From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbdHOPjd (ORCPT ); Tue, 15 Aug 2017 11:39:33 -0400 Received: from mout.web.de ([212.227.15.14]:60343 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbdHOPjb (ORCPT ); Tue, 15 Aug 2017 11:39:31 -0400 Subject: [PATCH 3/3] fs-udf: Adjust two checks for null pointers From: SF Markus Elfring To: Jan Kara , kernel-janitors@vger.kernel.org Cc: LKML References: <6eedcf1a-57f0-2ba4-d1b8-47a8da945d87@users.sourceforge.net> Message-ID: <1e627b28-e9e6-44a1-e43c-4c32b106e11e@users.sourceforge.net> Date: Tue, 15 Aug 2017 17:38:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <6eedcf1a-57f0-2ba4-d1b8-47a8da945d87@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:is7J+hvkfEdh4DAT3OSo4HnpEc2cQYG3A1anfYvz/Zz7YzE1XGo erM44YKWBOetcVhLJsT7UFQo+lWAus91Rt/pI6SYGZPFy5jPo4KEovGC7URRUNV//S9wzub mA1z+EKSMQ2+rriZCeE6wT3jANvL46U4Y2KMmgZ7mSo9Pme10a9F8s1pfQn2Yv4TiQN0Mbz IHuUkcxXq+smL3bjHsAMA== X-UI-Out-Filterresults: notjunk:1;V01:K0:x2pC2ivH7Pc=:z/6yoCNM+uUZeP0VWYGaZT U7gIgdOf8wxaIyDW9B1ZaiSGAGkO8V4hu8lH/Nthc5zvzKgw+SJ4ScORpxSQ9qPPwOKV8iENY gtDDWHjx69aLqoBH14PROTriyvnW0lb7QQLEDvRjYCIuyL3l5GCYijm+pCehZ6p7/f2COFZSY EMEFzEt1G2xtWcav1s9RhrPX4I0K/2u7UyVgY+Jw6uI0C2fnoyxZ4kyHlzMPPrMI/JEyrmZXh tv+UJcYDIXA0EPLTsBbxY8YFjsBlNnttXG3kbSs6oAh4D8378O5d9krroVhNREnWsDFh+1CKh pQJNwS0+H6nJ7S+okZvfgNAEiiSvb2Dr8p12dM3BDkpeZyrx9w5vPLL0y0G2IWQ08P8LunA2Y Is+5NYA31XIcMI1pM61I6u03kZel8udLCjBUKJzA/ARYWgEST5vQQFPOr3LYrV716eBh8UFkQ cDIrYgj4Euu4V4cHlHX5UAEw/WpsVAsv7H6zgaVG4XQnEozNeiznfU2zyCtYRNDqL3CHnxqS/ a/erfCft1eFvsgtlB4EHRHV6/F74QB+TEPgnJ7DrIGldthukRMNhRunXmPAE7W4DajHSPnGac TxA3f1qXrTighvZJpJi8z0Mj4UQcNRXnF+TuOq8sbsMXaPZjoZ9CLwjtDSIruviEu5/As6rwi u/lsSqlAnX8KpGg9SRYhh9wuPCEoVdGb5qDhQ5fgRxH/AI0nIVaN3ljZLr2PodBZ43JCafeVA 14W4e9y5SGKWjfsMtZ3QY1bgOIcJV9XwMkxX77Huc5iWaOYh/xl0uoCq1mXqhxT1P3ivFZvh6 h8S7/f/z4nYoc7fC8BiXCIAyPcGoeTzp9No4JJPJRMD+swlpSo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 15 Aug 2017 17:03:06 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix affected source code places. Signed-off-by: Markus Elfring --- fs/udf/super.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c index 0dc7c2d9f0fa..93c59630512b 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -321,7 +321,8 @@ static void udf_sb_free_partitions(struct super_block *sb) { struct udf_sb_info *sbi = UDF_SB(sb); int i; - if (sbi->s_partmaps == NULL) + + if (!sbi->s_partmaps) return; for (i = 0; i < sbi->s_partitions; i++) udf_free_partition(&sbi->s_partmaps[i]); @@ -1068,7 +1069,7 @@ static struct udf_bitmap *udf_sb_alloc_bitmap(struct super_block *sb, u32 index) else bitmap = vzalloc(size); /* TODO: get rid of vzalloc */ - if (bitmap == NULL) + if (!bitmap) return NULL; bitmap->s_nr_groups = nr_groups; -- 2.14.0