From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "David Hildenbrand (Arm)" <david@kernel.org>,
Christoph Lameter <cl@gentwo.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Sarthak Sharma <sarthak.sharma@arm.com>
Subject: Re: [patch v3] mm: test_vmstat: add synthetic benchmark for vm stats
Date: Fri, 18 Sep 2026 13:20:45 -0700 (PDT) [thread overview]
Message-ID: <1e628c9c-47de-1552-7a04-11a1c6c46e60@google.com> (raw)
In-Reply-To: <20260911223728.dfceedb4135e0b758df0ddd6@linux-foundation.org>
On Fri, 11 Sep 2026, Andrew Morton wrote:
> > Add a synthetic benchmark that can be used to measure performance of VM
> > statistics. This is used to analyze any improvements or regressions in
> > functions that are frequently used in hot code paths.
> >
> > The test is run by KUnit or doing modprobe vmstat_kunit directly.
>
> Can you please quote some typical kernel output in the changelog? That
> will help others to review the proposed change.
>
Ack, will include the output in v4.
> Sashiko made what appear to be some good points:
> https://sashiko.dev/#/patchset/014ef68b-6312-bcdc-f432-34c31476fe77@google.com
>
Got it, I'll use NR_MLOCK instead of SLABS_SCANNED since it's display only
and won't have any side effects at runtime.
Instead of switching the type of the "rem" variable as suggested, we can
just remove it entirely.
prev parent reply other threads:[~2026-09-18 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 1:08 David Rientjes
2026-09-12 5:37 ` Andrew Morton
2026-09-18 20:20 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e628c9c-47de-1552-7a04-11a1c6c46e60@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=sarthak.sharma@arm.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®