From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBC792D781E for ; Wed, 18 Mar 2026 12:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773836298; cv=none; b=EZGxU5fdECEixivE/OPR3RRLjDcHIBleL6I4Tub9rpxOSVzBzuBZa5AmFaM0TXdYCX7UUUfwNusRUDWq51VxuU772rdljrrTiyFziK1ycQIy+2vuUMKwraqsJ7R/8I10wYLtzS1iuwmj3kexM6Hyk6yUeYQj6icN8qm1mAmUvu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773836298; c=relaxed/simple; bh=qFYVODBgW076nTnIyiRhEbso0ehT3TAq5qtnSxchToU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eR11e8UB8sR9KyKj9yJN1RFpSnSGKQHzgL6CWnVhVHbMSQdU8LD/ze28HTJo7ObeU1wj+iayf4Whr5v2Rri/TxPPtRmo26fOgSvW77mDnEmDxWbHqzJx0UOoNWLLjw8JhMwU0uGUfoHShvprUK6xo4zsAQ+7nu0hAjPhFjdldIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=lbnBDFQ+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zfr97DWD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=lbnBDFQ+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=zfr97DWD; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="lbnBDFQ+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zfr97DWD"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="lbnBDFQ+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zfr97DWD" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 25A894D3BE; Wed, 18 Mar 2026 12:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773836296; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wjzkAdsKqyzy2RAr0gJdbGGCQ8XMcqsw6IHKwaChdb0=; b=lbnBDFQ+UHtTDIzbiQKZ4oJsi5xPAkTzUe8jDJqd9okj9JYMwR+tSjp5PCures4HsKTOeO 8VP4ZUubh5UGqzGv16G/V3P9sdcpuEyjVRuoOnarL4THgXjuPOH3fDBH/6s5lMfOXV4HP6 wvYc2pxMzEffZIzuShN8FAgbnde9JD0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773836296; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wjzkAdsKqyzy2RAr0gJdbGGCQ8XMcqsw6IHKwaChdb0=; b=zfr97DWD5x8Vp55IKc+gJpmXm+dlGkG7RF9/8R5AF+uuJwvr9dWbJrVGhQAUrNnfAFmhVV 6cDSojStNEJGQfDQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773836296; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wjzkAdsKqyzy2RAr0gJdbGGCQ8XMcqsw6IHKwaChdb0=; b=lbnBDFQ+UHtTDIzbiQKZ4oJsi5xPAkTzUe8jDJqd9okj9JYMwR+tSjp5PCures4HsKTOeO 8VP4ZUubh5UGqzGv16G/V3P9sdcpuEyjVRuoOnarL4THgXjuPOH3fDBH/6s5lMfOXV4HP6 wvYc2pxMzEffZIzuShN8FAgbnde9JD0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773836296; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wjzkAdsKqyzy2RAr0gJdbGGCQ8XMcqsw6IHKwaChdb0=; b=zfr97DWD5x8Vp55IKc+gJpmXm+dlGkG7RF9/8R5AF+uuJwvr9dWbJrVGhQAUrNnfAFmhVV 6cDSojStNEJGQfDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2D0F54273B; Wed, 18 Mar 2026 12:18:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id IuvTBweYumkLVwAAD6G6ig (envelope-from ); Wed, 18 Mar 2026 12:18:15 +0000 Message-ID: <1e6a2a0e-db8d-4618-b253-cc07d576fe85@suse.de> Date: Wed, 18 Mar 2026 13:18:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10 net-next v3] netfilter: remove nf_ipv6_ops and use direct function calls To: Ido Schimmel Cc: netdev@vger.kernel.org, =?UTF-8?Q?Ricardo_B=2E_Marli=C3=A8re?= , Pablo Neira Ayuso , Florian Westphal , Phil Sutter , "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Nikolay Aleksandrov , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, bridge@lists.linux.dev References: <20260317140141.5723-1-fmancera@suse.de> <20260317140141.5723-11-fmancera@suse.de> <20260317201704.GB3581148@shredder> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <20260317201704.GB3581148@shredder> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.30 X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWELVE(0.00)[17]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO On 3/17/26 9:17 PM, Ido Schimmel wrote: > On Tue, Mar 17, 2026 at 03:01:06PM +0100, Fernando Fernandez Mancera wrote: >> -#if IS_MODULE(CONFIG_IPV6) >> -#define EXPORT_IPV6_MOD(X) EXPORT_SYMBOL(X) >> -#define EXPORT_IPV6_MOD_GPL(X) EXPORT_SYMBOL_GPL(X) >> -#else >> #define EXPORT_IPV6_MOD(X) >> #define EXPORT_IPV6_MOD_GPL(X) >> -#endif > > We have quite a lot of these throughout the kernel, remove them? Yes it should go away. It probably deserves its own patch. Thanks for pointing it out!