From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57858C433EF for ; Wed, 4 May 2022 16:17:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353304AbiEDQVc (ORCPT ); Wed, 4 May 2022 12:21:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353223AbiEDQVW (ORCPT ); Wed, 4 May 2022 12:21:22 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8183227B33 for ; Wed, 4 May 2022 09:17:46 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id e2so2710574wrh.7 for ; Wed, 04 May 2022 09:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod.ie; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=q1QS1h63jdwlMuyWNP8xmEDpzxKjGMK4DEb1a7HY6v8=; b=B5/wgTRM47Tl6PkYtUKKGOHAofL12q1D1XeQV2au8EsqDuKXxnhiEQ1NxmJNWAzdP2 3x4xdSeMWZUJQ+cV0ZMU+IeYQqTjTKcy168mCV6zySdGCVFpO5pgWlWaC5G3JLOGOmms vBeH+yOKH0ArVlnht8uegF3WR1oh1AfRINI8z2Iy/QvIl4OMwngm41/ddl3h18Ga+Zm/ Pe5WXPQ25sM2RmJwQqg/8XprcUfWZtCcvwPuUVHQLVeCXkpEM6GNMbteVBkz0N1d6BY1 ec9Ls/wwmM1dRLKpVWHS1mVSPryPH9WniYE24/zlS9edV9v3RgFvDj/us7VuKziCRZgn eC8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=q1QS1h63jdwlMuyWNP8xmEDpzxKjGMK4DEb1a7HY6v8=; b=aHLm3MPqny04Kjjvzmx3VPZy3LbzXJ+HUKNyFZjamxCoUvy7f9gXFo8OjAh8LQ1rme 42Hjuy9Xwm6tL5EXk6E2kw2fHVH2GqBYHe2MT3ubaiSbbS5ck2ZQY4h0kgXMhxx7cWil LPaYGlfOSmK7ME4k5atUwC8Jy4S/dbIkCdu78AHFHW1en+hkWU1yWAi/wEbktUsiLhzu j3Au20N9K+JJFxpqPpVNl47VOT1GQeiEEbMnaZhLGIrTKsit3v0ngF5tG/CP2FBtPLqI 8bmmXG86elsUxFMO/kT1JYQnhn/cdZDzyLDNLlpari4VzwU9n//XxHe26DVbBie2R1L2 zrYQ== X-Gm-Message-State: AOAM530KVK7AUP26tj0fxKnOz5bI7frlysZfXjLR9W4a+h0MINRWVI4U PIRDSMXgaml/0rvq0k62DzgECg== X-Google-Smtp-Source: ABdhPJwuSiqhD1Cyjq81kfirw20i4hiDQULPYQWg/PuvNNeMNt1Vngp/iBTK7LXsBJS82EKqd4hhDg== X-Received: by 2002:a5d:474f:0:b0:20a:cb5c:bbd7 with SMTP id o15-20020a5d474f000000b0020acb5cbbd7mr16610323wrs.21.1651681065007; Wed, 04 May 2022 09:17:45 -0700 (PDT) Received: from [192.168.2.222] ([109.77.36.132]) by smtp.gmail.com with ESMTPSA id p20-20020a7bcc94000000b003942a244f38sm4153161wma.17.2022.05.04.09.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 May 2022 09:17:44 -0700 (PDT) Message-ID: <1e6de466-eefc-c5f7-5db7-6a87ff1608ed@conchuod.ie> Date: Wed, 4 May 2022 17:17:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2] i2c: add support for microchip fpga i2c controllers Content-Language: en-US To: Conor.Dooley@microchip.com, wsa@kernel.org, linux-i2c@vger.kernel.org Cc: ben.dooks@codethink.co.uk, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Daire.McNamara@microchip.com, geert@linux-m68k.org References: <20220321125855.3227057-1-conor.dooley@microchip.com> From: Conor Dooley In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05/2022 09:40, Conor.Dooley@microchip.com wrote: > On 21/03/2022 12:58, Conor Dooley wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> Add Microchip CoreI2C i2c controller support. This driver supports the >> "hard" i2c controller on the Microchip PolarFire SoC & the basic feature >> set for "soft" i2c controller implemtations in the FPGA fabric. >> >> Co-developed-by: Daire McNamara >> Signed-off-by: Daire McNamara >> Signed-off-by: Conor Dooley >> --- >> Changes from v1: >> - Use byte write and read functions > > So it turns out that how I made this change, which worked in my > test app, has issues. > I will rework and send a v3. > Welp, as it turns out we can chalk the issues up to user error, aka me entirely forgetting what the correct i2cdetect options were - d'oh. Apologies for the noise & unless something else changes, don't expect a V3. Sorry, Conor.