mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: jitendra.vegiraju@broadcom.com
Cc: netdev@vger.kernel.org, alexandre.torgue@foss.st.com,
	joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com,
	bcm-kernel-feedback-list@broadcom.com, richardcochran@gmail.com,
	ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
	john.fastabend@gmail.com, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org,
	linux@armlinux.org.uk, horms@kernel.org,
	florian.fainelli@broadcom.com
Subject: Re: [PATCH net-next v3 2/3] net: stmmac: Integrate dwxgmac4 into stmmac hwif handling
Date: Sat, 3 Aug 2024 00:59:26 +0200	[thread overview]
Message-ID: <1e6e6eaa-3fd3-4820-bc1d-b1c722610e2f@lunn.ch> (raw)
In-Reply-To: <20240802031822.1862030-3-jitendra.vegiraju@broadcom.com>

> +	user_ver = stmmac_get_user_version(priv, GMAC4_VERSION);
> +	if (priv->synopsys_id == DWXGMAC_CORE_4_00 &&
> +	    user_ver == DWXGMAC_USER_VER_X22)
> +		mac->dma = &dwxgmac400_dma_ops;

I know nothing about this hardware....

Does priv->synopsys_id == DWXGMAC_CORE_4_0 not imply
dwxgmac400_dma_ops?

Could a user synthesise DWXGMAC_CORE_4_00 without using
dwxgmac400_dma_ops? Could dwxgmac500_dma_ops or dwxgmac100_dma_ops be
used?

	Andrew

  parent reply	other threads:[~2024-08-02 22:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-02  3:18 [PATCH net-next v3 0/3] net: stmmac: Add PCI driver support for BCM8958x jitendra.vegiraju
2024-08-02  3:18 ` [PATCH net-next v3 1/3] net: stmmac: Add basic dwxgmac4 support to stmmac core jitendra.vegiraju
2024-08-02  8:21   ` Russell King (Oracle)
2024-08-02 21:43     ` Jitendra Vegiraju
2024-08-02 14:38   ` Simon Horman
2024-08-02 21:45     ` Jitendra Vegiraju
2024-08-06 21:56   ` Serge Semin
2024-08-09  0:41     ` Jitendra Vegiraju
2024-08-02  3:18 ` [PATCH net-next v3 2/3] net: stmmac: Integrate dwxgmac4 into stmmac hwif handling jitendra.vegiraju
2024-08-02  8:23   ` Russell King (Oracle)
2024-08-02 21:49     ` Jitendra Vegiraju
2024-08-02 22:59   ` Andrew Lunn [this message]
2024-08-06  0:36     ` Jitendra Vegiraju
2024-08-06 23:13       ` Andrew Lunn
2024-08-09  1:49         ` Jitendra Vegiraju
2024-08-06 22:14   ` Serge Semin
2024-08-09  1:17     ` Jitendra Vegiraju
2024-08-02  3:18 ` [PATCH net-next v3 3/3] net: stmmac: Add PCI driver support for BCM8958x jitendra.vegiraju
2024-08-02 23:08   ` Andrew Lunn
2024-08-06  0:56     ` Jitendra Vegiraju
2024-08-06 23:15       ` Andrew Lunn
2024-08-09  1:54         ` Jitendra Vegiraju
2024-08-09 20:12           ` Andrew Lunn
2024-08-09 22:10             ` Jitendra Vegiraju
2024-08-09 22:17             ` Florian Fainelli
2024-08-10  0:53               ` Andrew Lunn
2024-08-02 10:02 ` [PATCH net-next v3 0/3] " Serge Semin
2024-08-02 22:06   ` Jitendra Vegiraju
2024-08-05 22:43     ` Serge Semin
2024-08-08 23:03       ` Jitendra Vegiraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e6e6eaa-3fd3-4820-bc1d-b1c722610e2f@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandre.torgue@foss.st.com \
    --cc=ast@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=jitendra.vegiraju@broadcom.com \
    --cc=joabreu@synopsys.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®