From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52ADBC433E0 for ; Tue, 12 Jan 2021 12:38:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D23023117 for ; Tue, 12 Jan 2021 12:38:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388049AbhALMh7 (ORCPT ); Tue, 12 Jan 2021 07:37:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732988AbhALMh6 (ORCPT ); Tue, 12 Jan 2021 07:37:58 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80DB0C061575; Tue, 12 Jan 2021 04:37:17 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id y187so1974011wmd.3; Tue, 12 Jan 2021 04:37:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zMd+XHnFId1Wgsed2jprrzroN/fiYe/FbbKUqXbc1O0=; b=aWA3DhcWQA4MMreD6ZpfYBr9Teauz1ija7KFv0t8RsCuZ3BgBrC4psZs8ddKqaLHB2 EO05spt+UYI/Qr+5fbAOB7i9a+iY7CV0ZJjLJzMQYYUPAJihDA0T3QC5Sbfz6lWBCzH/ /XAPI0j+Ozy2pTr9of7gGDBbkx0VAmByJleOS+Esmo5Ge8JaHy4ztwrCW64L4agiq/kN HYlBLDRW0h6CdZrfGdwC/3aXBcXuaJlarGOV2kNXaLricmUn+sSztl/+NxdnEA7rT7s2 o2f0OOpmiUjX3DPyR7Q18jfa43bLapYMzi7XObUWHV4bcY1GirEU6n2pbcgOn1Lx/mmm gw3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zMd+XHnFId1Wgsed2jprrzroN/fiYe/FbbKUqXbc1O0=; b=i/g/FnNZwdzOqreURI1ozo5qE5zXU3GlHXdfW78wlEfjTvui2HHnH0jTFXrwHaiiVF lkTQ0upMRV4YLgB4xBOEcK5hNtiTOkio5Uq3UTanU4D4dbZvg2fZ4+woDJ+EDAftf371 Xb5oAgtPCBFYSrrSRKPncejQnC2oziGHwInGW4CaYfKWTaP0iqoppHOZ0oA88xqWb3yD l3n0RA1OCLg39uUnhF/7DBflatBSRJNFXCi2OWnUFshLOFIS2bDXh/WlmCBSzlBT2XjV 7fLTTTXMKRW06BPT4CSdbY7rDmxT36lofENiljlzi5+p+HSjhULp63SjYwp7o4dnX+7k MKng== X-Gm-Message-State: AOAM533W5UWo3FXe+2iSZo7Nb05D5/adHP4wLJxrlmopdZUzUI4kMWyy 8JmJl/LBzIEzN1UL0utasO4= X-Google-Smtp-Source: ABdhPJzZkIBM3vrqBllD/XocErsVNCfAdadbHNNKk+/k3bsFTvdI16XOCSkzqQsfYYoGVSRaasxoaA== X-Received: by 2002:a05:600c:20f:: with SMTP id 15mr3446491wmi.36.1610455036332; Tue, 12 Jan 2021 04:37:16 -0800 (PST) Received: from ziggy.stardust ([213.195.126.134]) by smtp.gmail.com with ESMTPSA id o74sm4107446wme.36.2021.01.12.04.37.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jan 2021 04:37:15 -0800 (PST) Subject: Re: [PATCH v13 5/5] leds: mt6360: Add LED driver for MT6360 To: Gene Chen , jacek.anaszewski@gmail.com, pavel@ucw.cz, robh+dt@kernel.org Cc: dmurphy@ti.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com References: <1608547554-6602-1-git-send-email-gene.chen.richtek@gmail.com> <1608547554-6602-6-git-send-email-gene.chen.richtek@gmail.com> From: Matthias Brugger Message-ID: <1e752ae6-f973-11c3-1780-d11d2af497be@gmail.com> Date: Tue, 12 Jan 2021 13:37:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <1608547554-6602-6-git-send-email-gene.chen.richtek@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/12/2020 11:45, Gene Chen wrote: > From: Gene Chen [...] > + > +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = { > + { .compatible = "mediatek,mt6360-led", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, mt6360_led_of_id); > + I think we should fix MFD code to not need to use a DT binding here. See [1]. Regards, Matthias [1] https://lore.kernel.org/linux-mediatek/20210111164118.GE4728@sirena.org.uk/ > +static struct platform_driver mt6360_led_driver = { > + .driver = { > + .name = "mt6360-led", > + .of_match_table = mt6360_led_of_id, > + }, > + .probe = mt6360_led_probe, > + .remove = mt6360_led_remove, > +}; > +module_platform_driver(mt6360_led_driver); > + > +MODULE_AUTHOR("Gene Chen "); > +MODULE_DESCRIPTION("MT6360 LED Driver"); > +MODULE_LICENSE("GPL v2"); >