mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "beanhuo@micron.com" <beanhuo@micron.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
	"quic_cang@quicinc.com" <quic_cang@quicinc.com>,
	"quic_nitirawa@quicinc.com" <quic_nitirawa@quicinc.com>,
	"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
	"luca.weiss@fairphone.com" <luca.weiss@fairphone.com>,
	"konrad.dybcio@oss.qualcomm.com" <konrad.dybcio@oss.qualcomm.com>,
	"quic_rampraka@quicinc.com" <quic_rampraka@quicinc.com>,
	"junwoo80.lee@samsung.com" <junwoo80.lee@samsung.com>,
	"mani@kernel.org" <mani@kernel.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Tze-nan Wu (吳澤南)" <Tze-nan.Wu@mediatek.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"manivannan.sadhasivam@linaro.org"
	<manivannan.sadhasivam@linaro.org>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] scsi: ufs: core: Don't perform UFS clkscale if host asyn scan in progress
Date: Tue, 5 Aug 2025 07:39:28 +0000	[thread overview]
Message-ID: <1e7dcb2c31beb3ea884879235fb70270fb483731.camel@mediatek.com> (raw)
In-Reply-To: <81e403f0-51b4-4efd-a06c-c6d7b02802dd@quicinc.com>

On Tue, 2025-08-05 at 14:03 +0800, Ziqi Chen wrote:
> 
> Hi Peter,
> 
> I saw you raised a ACK change to revert this whole change on branch
> Android16-6.12. Without this change, you will meet stuck issue during
> stability reboot test due to request queue quiesce and unquiesce
> mismatch.
> 
> This lockdep print just a warning, and as per my analysis before,
> This
> is a misjudgment. But stuck/crash issue is a real issue which has
> real
> instance.
> 
> Can you abort your reverting change?
> 
> 
> BRs,
> Ziqi

Hi Ziqi,

The lockdep warning remains a problem that impacts the 
functionality of lockdep. Furthermore, the lockdep issue
is consistently reproducible, unlike the stuck/crash issue,
which is rare and only occurred after the clock scale code 
had been in use for several years.

Therefore, I recommend ACK reverting first and then merging 
the fixed patch together.

Thanks.
Peter


      reply	other threads:[~2025-08-05  7:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-22  8:12 Ziqi Chen
2025-05-27 21:24 ` Bart Van Assche
2025-05-28  1:58 ` Martin K. Petersen
2025-06-03  2:35 ` Martin K. Petersen
2025-07-25  9:13 ` Peter Wang (王信友)
2025-07-25 14:54   ` Bart Van Assche
2025-07-28  6:34     ` Peter Wang (王信友)
2025-07-29  3:02       ` Ziqi Chen
2025-07-30 12:55         ` Peter Wang (王信友)
2025-07-30 15:37           ` Bart Van Assche
2025-07-30 15:42             ` Bart Van Assche
2025-07-30 15:50           ` Bart Van Assche
2025-08-04  7:54             ` Ziqi Chen
2025-08-04  9:41               ` Peter Wang (王信友)
2025-08-04 12:43               ` Peter Wang (王信友)
2025-08-05  6:03                 ` Ziqi Chen
2025-08-05  7:39                   ` Peter Wang (王信友) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e7dcb2c31beb3ea884879235fb70270fb483731.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Tze-nan.Wu@mediatek.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=junwoo80.lee@samsung.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_rampraka@quicinc.com \
    --cc=quic_ziqichen@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®