mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
	"xianfengting221@163.com" <xianfengting221@163.com>,
	"leon@kernel.org" <leon@kernel.org>
Cc: "cai@lca.pw" <cai@lca.pw>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"stfrench@microsoft.com" <stfrench@microsoft.com>,
	"xiubli@redhat.com" <xiubli@redhat.com>,
	"guoren@kernel.org" <guoren@kernel.org>,
	"jeyu@kernel.org" <jeyu@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"wqu@suse.com" <wqu@suse.com>,
	"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
	"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5: improve some comments
Date: Fri, 3 Apr 2020 02:33:58 +0000	[thread overview]
Message-ID: <1e7e26f7ef453268b7662f96ad3772ca3bbd7cd2.camel@mellanox.com> (raw)
In-Reply-To: <16dea5e4-fb5b-d269-2dff-3349f260a13c@163.com>

On Wed, 2020-04-01 at 21:14 +0800, Hu Haowen wrote:
> On 2020/4/1 8:57 PM, Hu Haowen wrote:
> > Added a missing space character and replaced "its" with "it's".
> 
> Sorry, this patch does not include space character adding. Please
> ignore and delete that part of the commit message.
> 

Hi, 

Thanks for the patch I will apply and fix the commit message. BUT..
net-next is closed and the rules apply to everyone, even mlx5 branch,
so please for next time, let's wait for net-next to open.

Thanks,
Saeed.

> 
> > Signed-off-by: Hu Haowen <xianfengting221@163.com>
> > ---
> >   drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > index c9c9b479bda5..0a8adda073c2 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> > @@ -684,7 +684,7 @@ static void mlx5_fw_tracer_handle_traces(struct
> > work_struct *work)
> >   		get_block_timestamp(tracer,
> > &tmp_trace_block[TRACES_PER_BLOCK - 1]);
> >   
> >   	while (block_timestamp > tracer->last_timestamp) {
> > -		/* Check block override if its not the first block */
> > +		/* Check block override if it's not the first block */
> >   		if (!tracer->last_timestamp) {
> >   			u64 *ts_event;
> >   			/* To avoid block override be the HW in case of
> > buffer

      reply	other threads:[~2020-04-03  2:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01 12:57 Hu Haowen
2020-04-01 13:14 ` Hu Haowen
2020-04-03  2:33   ` Saeed Mahameed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e7e26f7ef453268b7662f96ad3772ca3bbd7cd2.camel@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=cai@lca.pw \
    --cc=chris@chris-wilson.co.uk \
    --cc=davem@davemloft.net \
    --cc=guoren@kernel.org \
    --cc=jeyu@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stfrench@microsoft.com \
    --cc=wqu@suse.com \
    --cc=xianfengting221@163.com \
    --cc=xiubli@redhat.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®