From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0277ECDFB0 for ; Fri, 13 Jul 2018 22:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93B4B2087A for ; Fri, 13 Jul 2018 22:35:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93B4B2087A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=iogearbox.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729769AbeGMWvx (ORCPT ); Fri, 13 Jul 2018 18:51:53 -0400 Received: from www62.your-server.de ([213.133.104.62]:39498 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727241AbeGMWvw (ORCPT ); Fri, 13 Jul 2018 18:51:52 -0400 Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1fe6eW-0002ws-HU; Sat, 14 Jul 2018 00:35:04 +0200 Received: from [62.203.87.61] (helo=linux.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1fe6eW-00055K-Au; Sat, 14 Jul 2018 00:35:04 +0200 Subject: Re: [PATCH bpf-next v5 0/3] bpf: btf: print bpftool map data with btf To: Okash Khawaja Cc: Jakub Kicinski , Martin KaFai Lau , Alexei Starovoitov , Yonghong Song , Quentin Monnet , "David S. Miller" , netdev@vger.kernel.org, kernel-team@fb.com, linux-kernel@vger.kernel.org References: <20180712030803.875913594@fb.com> <20180711203010.51bab0cf@cakuba.lan> <20180713213550.GA5667@w1t1fb> From: Daniel Borkmann Message-ID: <1e80f262-9b3f-e4ff-0e89-7a07098d1b50@iogearbox.net> Date: Sat, 14 Jul 2018 00:35:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180713213550.GA5667@w1t1fb> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.0/24750/Fri Jul 13 22:58:14 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2018 11:35 PM, Okash Khawaja wrote: > On Fri, Jul 13, 2018 at 10:49:01PM +0200, Daniel Borkmann wrote: >> On 07/12/2018 05:30 AM, Jakub Kicinski wrote: >>> On Wed, 11 Jul 2018 20:08:03 -0700, Okash Khawaja wrote: >>>> Hi, >>>> >>>> Here are the changes from v4: >>>> >>>> patch 2: >>>> >>>> - sort headers in btf_dumper.c >>>> - remove extra parentheses >>>> - include asm/byteorder.h >>>> - compile error when big and small endian bitfields macro undefined >>> >>> Reviewed-by: Jakub Kicinski >> >> Hmm, strange, by accident I just noticed that only your bpf fix ever made >> it to patchwork, Okash. >> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_project_netdev_list_-3Fsubmitter-3D74458-26state-3D-2A&d=DwICaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=4wHrS7MHHFLZe_WCJwRVhA&m=wkiBQFYWPyiN9WONHLY0WiZxcOwNRhXaMMLIE551mCA&s=RggQzClRdkwawboGLPgPXHOdUtYffxeOwlcBlFru-P4&e= >> >> Potentially because you've sent with attachments which got dropped on >> the list? > interesting because i send all patches using quilt mail, the same way i > sent bpf fix. i can try git-send-email. > > also i dropped Acked-by as i changed patch versions. is it common thing > to do? or should i keep the Acked-by? Depends on whether the pieces that have been ACKed changed in the meantime or not.