From: Shannon Nelson <shannon.nelson@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Matt Mackall <mpm@selenic.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe()
Date: Wed, 19 Apr 2017 08:24:33 -0700 [thread overview]
Message-ID: <1e83c451-4410-8f47-08b6-87f8f59ba5f1@oracle.com> (raw)
In-Reply-To: <38c41219-7e7f-3a3e-29dd-04ae2d57beaa@users.sourceforge.net>
On 4/19/2017 2:10 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 19 Apr 2017 10:30:47 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kcalloc".
>
> * Replace the specification of a data structure by a pointer dereference
> to make the corresponding size determination a bit safer according to
> the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Thanks Markus.
Acked-by: Shannon Nelson <shannon.nelson@oracle.com>
> ---
> drivers/char/hw_random/n2-drv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c
> index 31cbdbbaebfc..92dd4e925315 100644
> --- a/drivers/char/hw_random/n2-drv.c
> +++ b/drivers/char/hw_random/n2-drv.c
> @@ -748,9 +748,7 @@ static int n2rng_probe(struct platform_device *op)
>
> dev_info(&op->dev, "Registered RNG HVAPI major %lu minor %lu\n",
> np->hvapi_major, np->hvapi_minor);
> -
> - np->units = devm_kzalloc(&op->dev,
> - sizeof(struct n2rng_unit) * np->num_units,
> + np->units = devm_kcalloc(&op->dev, np->num_units, sizeof(*np->units),
> GFP_KERNEL);
> err = -ENOMEM;
> if (!np->units)
>
next prev parent reply other threads:[~2017-04-19 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 9:08 [PATCH 0/2] n2rng: Fine-tuning for n2rng_probe() SF Markus Elfring
2017-04-19 9:10 ` [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() SF Markus Elfring
2017-04-19 15:24 ` Shannon Nelson [this message]
2017-04-21 13:16 ` Herbert Xu
2017-04-19 9:11 ` [PATCH 2/2] n2rng: Combine substrings for two messages " SF Markus Elfring
2017-04-19 15:24 ` Shannon Nelson
2017-04-21 11:36 ` Herbert Xu
2017-04-21 14:53 ` David Miller
2017-04-21 18:22 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e83c451-4410-8f47-08b6-87f8f59ba5f1@oracle.com \
--to=shannon.nelson@oracle.com \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®