From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>, netdev@vger.kernel.org
Cc: Taras Chornyi <taras.chornyi@plvision.eu>,
Mickey Rachamim <mickeyr@marvell.com>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
Volodymyr Mytnyk <vmytnyk@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: prestera: flower template support
Date: Thu, 2 Dec 2021 12:26:03 -0500 [thread overview]
Message-ID: <1e86c2c7-eb84-4170-00f2-007bed67f93a@mojatatu.com> (raw)
In-Reply-To: <1638460259-12619-1-git-send-email-volodymyr.mytnyk@plvision.eu>
On 2021-12-02 10:50, Volodymyr Mytnyk wrote:
> From: Volodymyr Mytnyk<vmytnyk@marvell.com>
>
> Add user template explicit support. At this moment, max
> TCAM rule size is utilized for all rules, doesn't matter
> which and how much flower matches are provided by user. It
> means that some of TCAM space is wasted, which impacts
> the number of filters that can be offloaded.
>
> Introducing the template, allows to have more HW offloaded
> filters.
>
> Example:
> tc qd add dev PORT clsact
> tc chain add dev PORT ingress protocol ip \
> flower dst_ip 0.0.0.0/16
"chain" or "filter"?
> tc filter add dev PORT ingress protocol ip \
> flower skip_sw dst_ip 1.2.3.4/16 action drop
You are not using tc priority? Above will result in two priorities
(the 0.0.0.0 entry will be more important) and in classical flower
approach two different tables.
I am wondering how you map the table to the TCAM.
Is the priority sorting entirely based on masks in hardware?
cheers,
jamal
next prev parent reply other threads:[~2021-12-02 17:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 15:50 Volodymyr Mytnyk
2021-12-02 17:26 ` Jamal Hadi Salim [this message]
2021-12-02 17:39 ` Volodymyr Mytnyk
2021-12-02 18:03 ` Jamal Hadi Salim
2021-12-09 10:46 ` Volodymyr Mytnyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e86c2c7-eb84-4170-00f2-007bed67f93a@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=serhiy.pshyk@plvision.eu \
--cc=taras.chornyi@plvision.eu \
--cc=tchornyi@marvell.com \
--cc=vmytnyk@marvell.com \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®