From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Johan Hovold <johan+linaro@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] phy: qcom-qmp-combo: clean up common initialisation
Date: Sat, 12 Nov 2022 09:18:22 +0300 [thread overview]
Message-ID: <1e8f27c7-3848-38d7-e658-5f2578a28137@linaro.org> (raw)
In-Reply-To: <20221111084255.8963-7-johan+linaro@kernel.org>
On 11/11/2022 11:42, Johan Hovold wrote:
> Commit 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo
> phy") added support for the DisplayPort part of QMP PHYs but
> unfortunately did so by duplicating parts of the shared configuration,
> something which has lead to subtle bugs depending on probe order.
>
> As the resources have always been requested based on the USB
> configuration, make sure to not rely on fields from the DP configuration
> when using them (e.g. in case they get out of sync) and remove the now
> unused fields from the DP configurations.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 47 ++---------------------
> 1 file changed, 4 insertions(+), 43 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
prev parent reply other threads:[~2022-11-12 6:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 8:42 [PATCH 0/6] phy: qcom-qmp-combo: preparatory fixes (set 1/3) Johan Hovold
2022-11-11 8:42 ` [PATCH 1/6] phy: qcom-qmp-combo: fix out-of-bounds clock access Johan Hovold
2022-11-12 6:10 ` Dmitry Baryshkov
2022-11-11 8:42 ` [PATCH 2/6] phy: qcom-qmp-combo: fix sdm845 reset Johan Hovold
2022-11-12 6:11 ` Dmitry Baryshkov
2022-11-11 8:42 ` [PATCH 3/6] phy: qcom-qmp-combo: fix sc8180x reset Johan Hovold
2022-11-12 7:51 ` Dmitry Baryshkov
2022-11-11 8:42 ` [PATCH 4/6] phy: qcom-qmp-combo: fix broken power on Johan Hovold
2022-11-12 6:15 ` Dmitry Baryshkov
2022-11-14 7:48 ` Johan Hovold
2022-11-11 8:42 ` [PATCH 5/6] phy: qcom-qmp-combo: fix runtime suspend Johan Hovold
2022-11-12 6:17 ` Dmitry Baryshkov
2022-11-14 8:01 ` Johan Hovold
2022-11-11 8:42 ` [PATCH 6/6] phy: qcom-qmp-combo: clean up common initialisation Johan Hovold
2022-11-12 6:18 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e8f27c7-3848-38d7-e658-5f2578a28137@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®