From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f45.google.com (mail-dl1-f45.google.com [74.125.82.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F2C632B98A for ; Fri, 20 Feb 2026 04:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771562028; cv=none; b=JyuCgzgfpjrFfGJsjC14igvCftW7dmkCz+Dtan4IwSembKBhnuQVlXnClhAd3xMreYT1S12Aex/HxmBLcz56D6tzJzxq9p2g9laTDUNbQyl1aAkzr8gv1koIOrlca5G6QLvhKgsegJXf7NQ9TiiSCEWCKlxe7FtnhY60pjbHWLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771562028; c=relaxed/simple; bh=cqQX4otJwlu/EBzCiT+EMmNhTOOeWS2QSPRS41i3ge4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ut7FMUNrV0qc/kjs+JKQ/YGIXqGw9YJhQQXCSObg8eiqJWACCOkfb6Bo2QRcn2ZisomP3n8C0WG6AhG5caZk7nnCNjtvZNrEm5qo9t3kyiTVyiNhp4eOqxPpsbeZNt2AxOSqWElcqULDOBxi75ixseCd33T26e4diH1SHZqAn3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JiSu46Pk; arc=none smtp.client-ip=74.125.82.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JiSu46Pk" Received: by mail-dl1-f45.google.com with SMTP id a92af1059eb24-1275910b930so1314764c88.0 for ; Thu, 19 Feb 2026 20:33:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771562025; x=1772166825; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vNvTcmQCYkNV3OvuP9WNSN7cpBfsnIcgezoEmqNLxoI=; b=JiSu46Pkj6G4vnhbM69k/5pC7eHg/djAItnoqwQuQ6AKlvPB1cNg39kANI4csVLpTS LLGZE1tRFWaj4AVh2FPq89e++l1eJ/D4ll9gah/Ky7BklBhcLVnvgBgZ9Xg8QIHm+6ur RbdvjsBQCIkorc3zUcvye6Vo5gKYGYEh17ryV3kBvJpy8SDvTIYlKdTrBxcSvGVeqRZi we/j2mnwaR4z0zB9elTunG2Uxytcy4oMOTF2aktynK7ez/o2dax7wowThRfpRuWdw+Cb sMWmQy3Dkf/ry2pP0yKTpNaUwVIxTSW3L4Ult4r9vGOoKJINjTd+F0m/cffjP8l2+ByI qVjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771562025; x=1772166825; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vNvTcmQCYkNV3OvuP9WNSN7cpBfsnIcgezoEmqNLxoI=; b=GXGRzTpfeKzAhZeJVjVFGO7debK9FBaku08ZXVPQnyobV9mntCqGXrfmoiWbz9UlmY hu5ECi+6K3eol/oVjd2/MjOcY0qFqqS7BOyuzDIErhegGggFuoz6pMiLep0FkW0vhlqn tqv9VWN5eVkgjLr5dL5uKpqIU/ir7CzfS659wGLwklv2D0j2uVyLCqGtofKkh4c6y7sb M9W3DAvfhxIHmPHgl79Qy/aZeIrY/GTkaDbrjh3im+Lb5YqceXSRcM9+FUv8JrvsqX1k 0vV4OKZMmaCYKxS6XsaWeu7z5diFisN6E1TaRKBEgTfrbzbYHVK3Q59tLglAmdlq1W7e zexg== X-Forwarded-Encrypted: i=1; AJvYcCXR1oGkQ2GdN6Wzy9Uxp5jUKYPfaS1mYWpX7TIKue+xg13B123aCz4WZCrOaEPC3JAB0hWHq8W2rB3P2/k=@vger.kernel.org X-Gm-Message-State: AOJu0YxyBgsEoACGE66vsp8rinQ6WNQonM49Wg9xlgCXG96/6NJn7Ky+ EbwpYWEYN8WtBKkmUAIcmL8gBlOLgUoJ3Q28UMQTNps3mzB4R5LeEf4T X-Gm-Gg: AZuq6aLQyObDErCRgRbQWuOfq44Cn0Kx5BV30BoloZ/3DmGnqPF1+e16T28Jk5ArUzx hzCH7kDlwIAAHC0Uq/GXWBdSuYDo2xpMp5naRBorbzCN1mBYk+CSdQgSM35HOmF2rsulZOKF1sS NprQPsrzfxNNFjXlDO0nxaPvc467HPQTX6mr9/GqTfHFIkoVjRCXQr6Tz3hFo+PdxN+Ytml9Xo9 b70NbAqzMyhQZQAQrlmp3GShzWEO+363RX54orPlycI3gqkygUYsZfxfxDSnYeOBR8XYENyV/C8 bdPRQN7cpZ006CeLXKigULaPJsX6yBhDEdQcbyGR59ipdtG5zU3nZZCHpB+9XXIqVoiNL3YwYwJ RitHEDenl0Eft9p7cb5IgdFUQbsS/YIutHiCKMSJwKsBS2zTRoWaPJ9yyGrbd5o/s2mPNoG853q MI245CtPDvkuY/5p4fw0r9XM1MbjKxl9wseTGAXlyDteNeUC1E44NQkhoBT8V9Evs8mqsPYRlsr fZ7iQ== X-Received: by 2002:a05:7022:1602:b0:11f:1e5b:2dd6 with SMTP id a92af1059eb24-1275faa7f90mr1954175c88.17.1771562025308; Thu, 19 Feb 2026 20:33:45 -0800 (PST) Received: from [192.168.68.65] (104-12-136-65.lightspeed.irvnca.sbcglobal.net. [104.12.136.65]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742cc83e6sm24382881c88.15.2026.02.19.20.33.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 20:33:44 -0800 (PST) Message-ID: <1ebc2e1b-f1aa-4559-90a0-feb628d5bfe1@gmail.com> Date: Thu, 19 Feb 2026 20:33:43 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: qcom: msm8960: expressatt: Add coreriver,tc360-touchkey To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, beomho.seo@samsung.com, jcsing.lee@samsung.com, dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, nick.reitemeyer@web.de References: <20251205-expressatt-touchkey-v1-1-1444b927c9f3@gmail.com> <532531d2-8f26-4ffa-9355-7821a4d64200@oss.qualcomm.com> <1e74b956-a45a-4d3e-b7fa-e4d5dc0390db@gmail.com> <97d9d942-236c-4f8a-902e-0ad2ab684a76@oss.qualcomm.com> Content-Language: en-US From: Rudraksha Gupta In-Reply-To: <97d9d942-236c-4f8a-902e-0ad2ab684a76@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello all, Top posting for once (context below). Not too sure what the next steps are to get the tm2 touchkey in. Should I resend the patch, contact someone else that can help provide guidance, or something else? Adding Dmitry Torokhov (official maintainer) and Nick Reitemeyer (person who introduced this variant). Thanks, Rudraksha On 12/16/25 04:59, Konrad Dybcio wrote: > On 12/9/25 8:10 AM, Rudraksha Gupta wrote: >>>> Add the tc360 touchkey. It's unknown if this is the actual model of the >>>> touchkey, as downstream doesn't mention a variant, but this works. >>>> >>>> Link: >>>> https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm-12.0-YNG4N/drivers/input/keyboard/cypress_touchkey_236/Makefile#L5 >>> This driver mentions a register called CYPRESS_MODULE_VER - maybe >>> it could help confirm the model? >>> >>> Konrad > [...] > >> When run on mainline, this is what was outputted: >> >> samsung-expressatt:~$ cat /sys/bus/i2c/devices/0-0020/module_version >> 0x06 >> samsung-expressatt:~$ cat /sys/bus/i2c/devices/0-0020/fw_version >> 0x09 >> >> >> fw_version matches downstream ClockworkMod Recovery dmesg: >> >> ~ # dmesg | grep "FW Ver" >> <3>[    2.201312] cypress_touchkey 16-0020: Touchkey FW Version: 0x09 >> <3>[    2.206317] cypress_touchkey 16-0020: Touchkey FW Version: 0x09, system_rev: 8 >> >> >> Unfortunately, I'm not to sure what the other variant versions are, so I will CC the driver's maintainers: >> >> MODULE_AUTHOR("Beomho Seo "); >> MODULE_AUTHOR("Jaechul Lee "); > Sounds like the best idea, I have no clue either > > Konrad >