From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753495AbdLMQN3 (ORCPT ); Wed, 13 Dec 2017 11:13:29 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:29969 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbdLMQN0 (ORCPT ); Wed, 13 Dec 2017 11:13:26 -0500 Subject: Re: [PATCH 01/10] ASoC: tlv320aic32x4: Remove filename from header and switch to SPDX To: Mark Brown CC: Liam Girdwood , , References: <20171212224311.24045-1-afd@ti.com> <20171213122824.GI6416@sirena.org.uk> From: "Andrew F. Davis" Message-ID: <1ec05e88-b605-7ab4-ee5d-b3b73c562a0c@ti.com> Date: Wed, 13 Dec 2017 10:13:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171213122824.GI6416@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/2017 06:28 AM, Mark Brown wrote: > On Tue, Dec 12, 2017 at 04:43:02PM -0600, Andrew F. Davis wrote: > >> @@ -1,21 +1,10 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> /* >> - * linux/sound/soc/codecs/tlv320aic32x4-i2c.c >> - * >> * Copyright 2011 NW Digital Radio >> * > > Having the C++ comment next to a C comment is very ugly, if you're going > to do this convert the entire comment block to C++ style. > Any C++ comments in non-C99 code is ugly.. Or whatever C standard the kernel claims to use these days. My regex is a bit too rusty right now to handle searching for multi-line examples, do you know of anyone else converting the whole block to C++ style? Things will look a lot uglier if we do this inconsistently, if it is now the law of the land we do this for the first line, then we should have it be the only exception. Everywhere else remaining old style comments, IMHO.