mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-arm-msm@vger.kernel.org, andersson@kernel.org,
	agross@kernel.org
Cc: marijn.suijten@somainline.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@somainline.org>,
	Stephan Gerhold <stephan@gerhold.net>,
	Loic Poulain <loic.poulain@linaro.org>
Subject: Re: [PATCH v3 3/3] dt-bindings: firmware: qcom: scm: Separate VMIDs from header to bindings
Date: Mon, 9 Jan 2023 11:16:39 +0100	[thread overview]
Message-ID: <1ec4b446-b195-0277-90ba-4a8398fcd729@linaro.org> (raw)
In-Reply-To: <e64d22eb-4c42-b279-b493-972e4a1af1cd@linaro.org>



On 9.01.2023 10:54, Krzysztof Kozlowski wrote:
> On 09/01/2023 10:39, Konrad Dybcio wrote:
>> With changes to the rmtfs binding, secure VMIDs will become useful to
>> have in device trees. Separate them out and add to include/dt-bindings.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> v2 -> v3:
>> New patch
>>
>>  include/dt-bindings/firmware/qcom/scm.h | 16 ++++++++++++++++
>>  include/linux/qcom_scm.h                |  7 ++-----
>>  2 files changed, 18 insertions(+), 5 deletions(-)
>>  create mode 100644 include/dt-bindings/firmware/qcom/scm.h
>>
>> diff --git a/include/dt-bindings/firmware/qcom/scm.h b/include/dt-bindings/firmware/qcom/scm.h
>> new file mode 100644
>> index 000000000000..d66818cd57a8
>> --- /dev/null
>> +++ b/include/dt-bindings/firmware/qcom/scm.h
>> @@ -0,0 +1,16 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
> 
> Only Codeaurora folks contributed these numbers, thus we can relicense
> it to dual-license, I believe.
> 
> The other topic is what do these numbers represent: hardware interface?
> registers? offsets? firmware?
Arguments for a SCM call, so firmware interface.

IOW, why bindings is the place for them?
> (usefulness for DTS is not the reason)
These defines correspond to mappings in a hardcoded, irreplaceable
and un-omittable firmware which is (unless you steal engineering
samples from the factory) always shipped with these SoCs and they
help clarify some otherwise totally magic numbers.

Konrad

> 
> 
> Best regards,
> Krzysztof
> 

  reply	other threads:[~2023-01-09 10:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09  9:39 [PATCH v3 1/3] dt-bindings: reserved-memory: rmtfs: Make qcom,vmid an array Konrad Dybcio
2023-01-09  9:39 ` [PATCH v3 2/3] soc: qcom: rmtfs: Optionally map RMTFS to more VMs Konrad Dybcio
2023-01-09  9:39 ` [PATCH v3 3/3] dt-bindings: firmware: qcom: scm: Separate VMIDs from header to bindings Konrad Dybcio
2023-01-09  9:54   ` Krzysztof Kozlowski
2023-01-09 10:16     ` Konrad Dybcio [this message]
2023-01-09 10:31       ` Krzysztof Kozlowski
2023-01-09  9:56   ` Krzysztof Kozlowski
2023-01-09  9:51 ` [PATCH v3 1/3] dt-bindings: reserved-memory: rmtfs: Make qcom,vmid an array Krzysztof Kozlowski
2023-01-09 11:41   ` Konrad Dybcio
2023-01-09 12:13     ` Krzysztof Kozlowski
2023-01-09 17:14     ` Marijn Suijten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ec4b446-b195-0277-90ba-4a8398fcd729@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@linaro.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=stephan@gerhold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®