From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8002921CC71 for ; Tue, 10 Jun 2025 10:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749551884; cv=none; b=Xy3ESESNbJaQUkMqC8/UE0jAsp2vudyfeahRhl/nGXBN09MKmNx9Wk1h+tuCZtXwyl+O7qj8TkPZTKP7rsn0XwVgvtCOIy5sBHuSBeOeM/5+U5x9Np9LFdxq+Y1/O7pMylYr1U7hTtmpP1DxBtWo3BXLg6jekDdPWnolbFfQU9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749551884; c=relaxed/simple; bh=FNEmqsYSzqQNL2ctku6Xdf+zy0bm24rFz/Em8TnfG40=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UAO4Rpaof/X1Nqy7NxcrLvs4m9gViMQw5uZRhQdvRQ9UfRu3JiabhEHe9NPqTBGmqmp5RQ3o90EJ3y1Gu9JrI4CdizLJtbaYrAXe0zkQ0ljE6mUBsQ7W7A74ZwUC3QMdIgGyls2MEVDmxUwtKP7oz9L0QaqBheaqObRWByMYSmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VVDSCKHR; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VVDSCKHR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749551881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aI6UmbgwdlVAnCc78+kA++Zeb+kmoiPB+fmNOOceC0w=; b=VVDSCKHRpVkmLpLgFD1gfMlvDsMgTTeTeIBYsaN5PbC9QM/+V82eiEgE9T9cvr/Fcx09/z q+ngo8vYlmC9Iv8jbfIPBhdJaBxK0kWVcayhTt8s0gqBhwyijQ89zaGpKjTDP0O2MQKsvC IR1RcD+WSvxiVz0l5HG4rFSl32vUZsI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-85-JYQr6pEQOq-8-DT4_NaeHA-1; Tue, 10 Jun 2025 06:38:00 -0400 X-MC-Unique: JYQr6pEQOq-8-DT4_NaeHA-1 X-Mimecast-MFC-AGG-ID: JYQr6pEQOq-8-DT4_NaeHA_1749551879 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4eec544c6so2184819f8f.0 for ; Tue, 10 Jun 2025 03:37:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749551879; x=1750156679; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aI6UmbgwdlVAnCc78+kA++Zeb+kmoiPB+fmNOOceC0w=; b=fC+STsqFRfcHRy6eH9tT8MgCFEAM8MRHpHkuISfACNjtNqS46dFrsMOHgw5UunNz+P P87h8MhCwGPCYrZB6H4vsO9Ia4VvGSTr30uOPI3zot0GxBESUMacW9+2PySSLxaQhGSz qOrYvJyILcxZV0P9jQqTDEkS2lcurzp5yJ9SQZMkpzZ1f9Y+w3o6YPXDH7b5Yhwafmwt b5rSFKjbonByulhio3xCee933Xv7rGLbg2Wx4aFi7tVem+1RkafgqOgsIme4Z5Pr4ApO 5KGvbqMYLiiiARcp2H2f3Ma2dJDyfWY4Y92ILg8IvhfuFOMv7QeRekzEoRyw8A88+TpY lz7A== X-Forwarded-Encrypted: i=1; AJvYcCXQ1m/a8Ex+w+yR3tTviSfa4VOtp9aMkz735ohGdN88eLJqzEqERUDJPjwONBpX4Mdz1cyX0d54p4A/+Mg=@vger.kernel.org X-Gm-Message-State: AOJu0YzhdfJkA1waUONJp3etf/KF9JN1gzIFwpM2sqY255K2VVlJTXCP +sFBie43eWjnRNft8nbqweNXVVp8w3tm5I4LiTGd9bUs4tlXxhpZfa7lmH8vyLqZv0BwaICqeYp 3Y63UwkLXX91xuzOi3qUimnxdx4l1QpyzCn/fccrI7AJUrBl0eSFnCDv3cqRiiLZO3Q== X-Gm-Gg: ASbGncukUziXE1Epk2nmQcD9cWBLn7Ie2apuozZM+ie1EBJ9Vi5nxq/vRsX0LhbNqaF JaH2rd5pCQUCzRhmcDTHi/X9vilApD3wtFUvfgfy8+0IBd5fDBOZHuUfVvSgISKN7dyN15jd8SD MwWffgVbcXMP8jd5W0ho0uynwbXUphZxdE2K19kblJhXTVokxCpGvDj0anRIOZrClfDI0yO2wE6 E2J4L+upSAwaD9lxiDOpp1w7X9T5oY6euakkBO30JJL27lKzF0i+f+Qc4nIkWNahxs/qY++3vFb TnKsFrBIYwrPdhs6PZtRRzILuxmlg6IXUwwaSpCLL15Hl6ureIyH2vs= X-Received: by 2002:a05:6000:26c5:b0:3a4:f7f3:2d02 with SMTP id ffacd0b85a97d-3a5522716a9mr1608123f8f.17.1749551878764; Tue, 10 Jun 2025 03:37:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6jkrSTQLJlhMrYdllOzIW6Ete/JGJLtTiYCIoUWXSkxb/sdVLs38Feted1QX/mOtzl90MWQ== X-Received: by 2002:a05:6000:26c5:b0:3a4:f7f3:2d02 with SMTP id ffacd0b85a97d-3a5522716a9mr1608088f8f.17.1749551878384; Tue, 10 Jun 2025 03:37:58 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320b16657sm9031205e9.8.2025.06.10.03.37.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 03:37:57 -0700 (PDT) Message-ID: <1ec55f0b-991f-4ea0-869e-5fc0be719c8f@redhat.com> Date: Tue, 10 Jun 2025 12:37:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: Remove arch_flush_tlb_batched_pending() arch helper To: Ryan Roberts , Andrew Morton , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Lorenzo Stoakes , Rik van Riel , "Liam R. Howlett" , Vlastimil Babka , Harry Yoo Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org References: <20250609103132.447370-1-ryan.roberts@arm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250609103132.447370-1-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09.06.25 12:31, Ryan Roberts wrote: > Since commit 4b634918384c ("arm64/mm: Close theoretical race where stale > TLB entry remains valid"), all arches that use tlbbatch for reclaim > (arm64, riscv, x86) implement arch_flush_tlb_batched_pending() with a > flush_tlb_mm(). > > So let's simplify by removing the unnecessary abstraction and doing the > flush_tlb_mm() directly in flush_tlb_batched_pending(). This effectively > reverts commit db6c1f6f236d ("mm/tlbbatch: introduce > arch_flush_tlb_batched_pending()"). > > Suggested-by: Will Deacon > Signed-off-by: Ryan Roberts > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb