From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC1DC7EE2E for ; Tue, 13 Jun 2023 10:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240050AbjFMKGM (ORCPT ); Tue, 13 Jun 2023 06:06:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242074AbjFMKGA (ORCPT ); Tue, 13 Jun 2023 06:06:00 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 887708E; Tue, 13 Jun 2023 03:05:58 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35DA4NpX000354; Tue, 13 Jun 2023 12:05:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=cRX+auEkIEZ1xY8U2wyEZt0TGCmMuO7kC2MF/5cWd/M=; b=DX2MIeJP2wYVKOV/Ib9YUiFVxLuweMCh5S5XG883IheVH9jsQwCdrDWJr3b7OyEx9BYw r2+qcOjLUJThmE56Y4RjyjoxcOM3Lk4cg0wX31b4p1WMw2V4EPPOeQl+mxs+VRuNC7KM KvmmMNUQffmNZdvR9jWafmKltWAxDMz0X3h7/jM8ejsX3g5k+5GuZQIBEYJYdcJdOYYO EDkU0aIIWHqTY/Apv2Aq3Ae+1g6XzTS6OMRaM0eLTS49fYlEz1IW36QPfoLFsr2YgPb6 Sy90IUJdY5kDeHlvErdGaLDaqoUaVsQu2x3K9burj91ZKZs30d3hViQothSwECLtH/ry Uw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3r6pcrr07t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jun 2023 12:05:30 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id BF893100045; Tue, 13 Jun 2023 12:05:26 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id B3E6721ADD8; Tue, 13 Jun 2023 12:05:26 +0200 (CEST) Received: from [10.252.6.14] (10.252.6.14) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 13 Jun 2023 12:05:24 +0200 Message-ID: <1ec74263-085c-68ab-3490-56172f11b7c1@foss.st.com> Date: Tue, 13 Jun 2023 12:05:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] remoteproc: stm32: use correct format strings on 64-bit Content-Language: en-US To: Arnd Bergmann , Arnd Bergmann , Bjorn Andersson , Mathieu Poirier , Maxime Coquelin , Alexandre Torgue CC: Ben Levinsky , Tanmay Shah , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Dan Carpenter , , , , References: <20230609120546.3937821-1-arnd@kernel.org> <7846c69b-5c2d-16d3-6079-d11a60171a69@foss.st.com> From: Arnaud POULIQUEN Organization: STMicroelectronics In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.252.6.14] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-13_04,2023-06-12_02,2023-05-22_02 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/12/23 16:17, Arnd Bergmann wrote: > On Mon, Jun 12, 2023, at 16:10, Arnaud POULIQUEN wrote: > >>> ddata->rsc_va = devm_ioremap_wc(dev, rsc_pa, RSC_TBL_SIZE); >>> if (IS_ERR_OR_NULL(ddata->rsc_va)) { >>> - dev_err(dev, "Unable to map memory region: %pa+%zx\n", >>> + dev_err(dev, "Unable to map memory region: %pa+%x\n", >>> &rsc_pa, RSC_TBL_SIZE); >> >> What about cast the RSC_TBL_SIZE define instead to ensure to be independent from >> the arch and to match with the use of RSC_TBL_SIZE? >> >> #define RSC_TBL_SIZE ((size_t)1024) > > I have no objection to that, but I don't see it doing anything good either, > as this is a constant value that will always work. > > Arnd It was just to avoid to have the constant used with different types in the code But that's nitpicking, let's keep your proposal. Thanks, Arnaud