From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 209A2390229 for ; Mon, 16 Mar 2026 10:54:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658442; cv=none; b=iNOQ8H9pMFaeZdCAFjn+2+NF0VdISgLDh8NhxsCIYuBb4CrsPV8SEjAVkhRL/1nbYDZOrDePm/sX7iZO0qlQDw8HQHAH6fr05uhs2BlIdr13rFzPweDhQMVJv9G1A2kCFAVfSmFVweexyCT/5UqoPG+JtfE0Xr0aPMwvizTY6hY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658442; c=relaxed/simple; bh=1yrviHqSXF9T5Z9ErzIMR0ycwVWDFN96Rk4c4WHPAwM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tJvSFdYow3gr/r1fuqcJZu5ch+W7Yr5lZGVHN3MblD0vsi38RMb47IPJyURzqSCqM7gzPoPXgETQK8EYVFZpkbfQn5LdCtDLXzhygSd+vNvodMQibAOvohFEZiBlZxDUsgdT/UX3FkuBX+M0eHO3GA7gMzfb2eySGqJOEPqVfMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Iqf51xuC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=grAHcqYg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Iqf51xuC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="grAHcqYg" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G7n2Hb041951 for ; Mon, 16 Mar 2026 10:54:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DaOxGyMwlbRynP3B6fbAvTN3ZnEyIcBJwKLT8kR8si0=; b=Iqf51xuCV7nhrfUw UWpjTb8AxqXJN9QX1fyl1mEbetOOkjUTp92pNXZMdVSypF2hSLB9uFGYWMP69o2N adhhAHy+fLyWflJfDvc5q6u3PZNqDUIgw5hequBHBuL3G17DZSge7siHDlgoEBPe yxq75r5dkBCakA0B2kB7CX59quxaE7rgO+cr0FkeX6rJjaXAbh2s3NCTWusgsona GAV82cDiEQor5xZ199JLUK6BxkMPTOlJKyceDqBsfGFsP/kqw80SWSjDnEGryEUv pFH+YqCLYVt9xw7uWEO0MmLW7X19+4ZdSmQY+lXOWRM2pHijhXUZSt3gFf7mjShR 3F9uPw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxdt80nn3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 10:54:00 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5090f7cee3eso27558551cf.1 for ; Mon, 16 Mar 2026 03:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773658439; x=1774263239; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DaOxGyMwlbRynP3B6fbAvTN3ZnEyIcBJwKLT8kR8si0=; b=grAHcqYgF2KT8xWfnudbCf9EsoE6uzhq2g4RBb3S64EyWtL3gY4b5zMZtEDZGrEmut eAvLpHYbwX0YxAi4ay8E1ytpF0LDA3efOI7tjmW46VhUk9DH1K0qpi3YumCKirE1hZ6s yf5//qt7yYkbmsHY1U6KyNs9a9iDWltF5hBigl7gmSlrcdWYAmq8em4R06090P2vTJqX P3EtV4rllAjejbnKTCRm328u7Hi04+rAxd2ZzWhMZEGYmzKmnSCkFQxPq7CNrRHsgeqg 4pLY4ioSQcsCTylHZyyYnTyM99rpoizaU02XUFTOyhpolG+1xZkjKFXbMWrHBDC0BsWC zjeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773658439; x=1774263239; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DaOxGyMwlbRynP3B6fbAvTN3ZnEyIcBJwKLT8kR8si0=; b=dpYa5Cb8Hy1S+/cx82P4BYSwsf19pQSmBbWSYel7kyhs1YKobf4S4HJBlTzL7bXuCc Wo19juIQTGOK1SCqUDegA06Q63ddYKrFykMDhBYbHixf8Bwm7kNxTS+Us4zE75ydua9u j+dU65JCNvN/RkCCUhEmH3GBpuYxBduU72xkmqHTuwBnJXJXrvaMwILBj09+19TAzZr2 de1RoSZuqekVQ//3vjKa3xUneZBKGstzO8hL4hL5Fx62vUH/qfn4LQD74Pv1JuzmWFHc GdpBk6PmsnI5pwUr5OnSPevyEYEaFBrGNOfdFvCxZWApCY2ZIdoemEvZqY1hmRV1Hr1a FeGA== X-Forwarded-Encrypted: i=1; AJvYcCUzQvzg6eAS0PJW+Po0AXVRKuHHohJH/2hCBbKpT5qijFHVb9zZdKofRqESS233zLwl1rYqPN3Fg20RxU8=@vger.kernel.org X-Gm-Message-State: AOJu0YwiGPtIsqm8XCe1xsVnxoE4hmkr4Fof73Uu3fdLY98dSxsJxtbS X0AzHdqGyfYnW+w58UlzYKwi9jEhfWWA86/SBGDszGjcNJ1jLUtQkHyf5aNGXvDDLq0KyIEscLM ZOf5i4jnoR/VWUq3LxqTzvXcj13ACM4QwVCbV2+bjQ49oFCFCHZrHDINrSHrxnYNclxQ= X-Gm-Gg: ATEYQzzWCRZCaK2FHfypD3oqxfsDE3J0147NiIfs53Xnm8H6Fd+A1POD7IUYAb+V1bR EBuDmI9t/I0vu8EvK2EaULHhp/fNsb06Dy8MVK6YBa4BpdrDm8zDS11Pp75OM2Xz/m1swz10JIm 2jNFDRtBGGX43XHQvzo/aoMCaMWDTrbA6t1KjJQR0ozQcPrW6fwnF59MkH4ijKuBuVcvomq8OuR kQGz6C6KUMgpj+1Vg6fyXi/KOUI8FntY95h5LeC/FZ9Mv93rJz733xJsNf8I941QlPkTUwt0JUt lQ65CqKQ011t3ZNE6jypyk/Io25OXDdY3hSWBZLcitYCMEp3+Hd54wfad3y/0OajxGTSQ6PYJh0 dK4jLqArAsODLotuDA6ZGoJIlhwSPKgabFT01s8/XOUsAnb0TqLPXfXXLJxzWdR1sJuNpfcuaMV 0R6NI= X-Received: by 2002:ac8:5a90:0:b0:509:a3c:e390 with SMTP id d75a77b69052e-50957d1b684mr128665831cf.4.1773658439389; Mon, 16 Mar 2026 03:53:59 -0700 (PDT) X-Received: by 2002:ac8:5a90:0:b0:509:a3c:e390 with SMTP id d75a77b69052e-50957d1b684mr128665601cf.4.1773658438915; Mon, 16 Mar 2026 03:53:58 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6634fdb6225sm4986109a12.9.2026.03.16.03.53.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:53:58 -0700 (PDT) Message-ID: <1ec935ce-2023-450b-901b-a287b9d1f486@oss.qualcomm.com> Date: Mon, 16 Mar 2026 11:53:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: typec: ps883x: Fix Oops at unbind To: Mostafa Saleh , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org, jack.pham@oss.qualcomm.com References: <20260313155534.1916773-1-smostafa@google.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260313155534.1916773-1-smostafa@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: y2I6OHAmEWbTnfpydwcbLEf-QXYjRRzB X-Authority-Analysis: v=2.4 cv=CKInnBrD c=1 sm=1 tr=0 ts=69b7e148 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=1XWaLZrsAAAA:8 a=hMhAVbCCx7uGpyVcq4oA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: y2I6OHAmEWbTnfpydwcbLEf-QXYjRRzB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA4MiBTYWx0ZWRfX1Sx0AwFHaT5j MjR4jPlOReicpJIeUEuh16oszWysN4Qy76ZjITr57lzhaSAmGxC+4J8OH9HpEtOOer+o1KxJjEr Gd2X1UHR8xXVHKgM4rE97q/FFmzt8C6u9jULsjyJnH7je4+15L9fm3P6AxOrMeO/LZgJddnYUyM Xzd2XUbn3yRKl4+0c8foojVZu/2M/h3aWQa5wbkp0eDAvr998GeQR68PTWURldDKCGXENXh+don VnkNm4Ha0c7PsysLNVwAid2Rwmt/BzomOhOw4r7wBpul9MoJGgOrnQvqvgdvqSgkxGeJRX3U9y2 9wR7Bh8+IuwY3HBFdRivRdzm9N2h3R0OBhRn7pfzVT3+sRzN3U0NgphPO8scZ59HfvPJzuJ6Foa L60QrYo9hAGGGdxuXxJdOvM6IbSGEheJak8Tyi2HrGbysx7Nmc6ubmyUK/7m2jDUYCtx2yx4nkD wGsLIKnFjJiD6ONjA1A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160082 On 3/13/26 4:55 PM, Mostafa Saleh wrote: > When trying to unbind a device in order to bind to it vfio-platform as: > > echo bc0000.geniqup > /sys/bus/platform/devices/bc0000.geniqup/driver/unbind > > I get the following Oops: > > [ 436.478639] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020 > [ 436.487762] Mem abort info: > [ 436.490716] ESR = 0x0000000096000004 > [ 436.494595] EC = 0x25: DABT (current EL), IL = 32 bits > [ 436.500071] SET = 0, FnV = 0 > [ 436.503250] EA = 0, S1PTW = 0 > [ 436.506505] FSC = 0x04: level 0 translation fault > [ 436.511533] Data abort info: > [ 436.514558] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 > [ 436.520215] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 > [ 436.525436] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 > [ 436.530918] user pgtable: 4k pages, 48-bit VAs, pgdp=00000008861a9000 > [ 436.537554] [0000000000000020] pgd=0000000000000000, p4d=0000000000000000 > [ 436.544548] Internal error: Oops: 0000000096000004 [#1] SMP > [ 436.550374] Modules linked in: > [ 436.553542] CPU: 2 UID: 0 PID: 671 Comm: bash Tainted: G W 7.0.0-rc3-g56fcdd0911a5-dirty #2 PREEMPT > [ 436.564440] Tainted: [W]=WARN > [ 436.567515] Hardware name: LENOVO 91B6CTO1WW/3796, BIOS O6NKT3BA 05/02/2025 > [ 436.574675] pstate: 21400005 (nzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--) > [ 436.581841] pc : ps883x_retimer_remove+0x14/0x94 > [ 436.586605] lr : i2c_device_remove+0x28/0x84 > [ 436.591017] sp : ffff8000847137c0 > > That's because the ps883x_retimer_remove() retrieves the driver data > from i2c_get_clientdata() which was never set at probe. So, add > i2c_set_clientdata() at the end of the probe. > > Signed-off-by: Mostafa Saleh > --- Fixes: 257a087c8b52 ("usb: typec: Add support for Parade PS8830 Type-C Retimer") Konrad