From: Joe Perches <joe@perches.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Guido Günther" <agx@sigxcpu.org>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Johan Hovold <johan@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel
Date: Wed, 03 Apr 2019 10:11:00 -0700 [thread overview]
Message-ID: <1ed5eb3af4df6b2dd1544c7b696e034ed5c94f06.camel@perches.com> (raw)
In-Reply-To: <20190403161735.GN5238@ulmo>
On Wed, 2019-04-03 at 18:17 +0200, Thierry Reding wrote:
> On Mon, Apr 01, 2019 at 12:35:32PM +0200, Guido Günther wrote:
> > v4 fixes up the DT binding example and uses a wider cc list since I
> > failed to extend that when touching more files.
[]
> Applied, thanks.
>
> checkpatch does complain about the dsi_generic_write_seq() macro
> definition, because it uses flow control statements, but there are
> already similar macros in other drivers, so I let this slide. We may
> want to eventually come up with something better and then replace these
> macros for the other drivers as well.
Dunno about the other drivers, but the mechanism isn't
particularly nice as it separates the init identifier
from the data being written.
It might be better to use something like a struct for
each command and a for loop for each block of commands.
Also the 0xBF value used in one of the init sequence
writes does not have an identifier #define in the
'Manufacturer specific Commands send via DSI' block
which is odd.
next prev parent reply other threads:[~2019-04-03 17:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:35 Guido Günther
2019-04-01 10:35 ` [PATCH v5 1/3] dt-bindings: Add vendor prefix for ROCKTECH DISPLAYS LIMITED Guido Günther
2019-04-01 10:35 ` [PATCH v5 2/3] dt-bindings: Add Rocktech jh057n00900 panel bindings Guido Günther
2019-04-01 10:35 ` [PATCH v5 3/3] drm/panel: Add Rocktech jh057n00900 panel driver Guido Günther
2019-04-03 16:17 ` [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel Thierry Reding
2019-04-03 17:11 ` Joe Perches [this message]
2019-04-03 20:09 ` Joe Perches
2019-04-03 21:07 ` Sam Ravnborg
2019-04-04 5:02 ` Joe Perches
2019-04-04 10:53 ` Guido Günther
2019-04-04 15:06 ` [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging Joe Perches
2019-04-04 15:48 ` Guido Günther
2019-04-04 16:19 ` Joe Perches
2019-04-04 17:09 ` Thierry Reding
2019-04-04 17:00 ` Sam Ravnborg
2019-04-04 18:55 ` Joe Perches
2019-04-04 19:08 ` Sam Ravnborg
2019-04-04 17:08 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ed5eb3af4df6b2dd1544c7b696e034ed5c94f06.camel@perches.com \
--to=joe@perches.com \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jagan@amarulasolutions.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®