From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 588552566E3 for ; Fri, 18 Apr 2025 10:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744973533; cv=none; b=AfYC/zZYJLOOiUVPBdlUNJ/3pdIsojr9cyUYZ/q2Q9MXY6Q9DKf8cVcGjYxX6MAN5XnerfnmRZw7btlAAEloJ7EIcDi6uvxAIwwhm3aAE/EzWKF5F977xXn83LXB9cKkv0t+sINMN3N2nmOyZStIQzejhLJ1EozH9xOFaaJnqDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744973533; c=relaxed/simple; bh=voNiiQ0sBtVjA8KbSlLVpp0QyfC0hIIaYiQE+5E4M4c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jrv4h1pqNFugfjUXEUsvS73nAw2FLutWKbwGNpMZe3yn+QE5R/8LWWSGlq3F2abinPoJFDXNbugob7F0/MI2ubhJvrhcZObwipjga7jdQLKM2IBAdw6zVWRoFM3wEsCP4IJHtMpewoIt8kOwncs7Hvf9awf07Dy/r65eeJY0HF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bceo/nnd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bceo/nnd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744973530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VkQeTK0Osg/+gnKBUiLYBnAJGjHxbf8m0YFBFQjNQb4=; b=Bceo/nndoQyAzIIYQfWuD35wf+IIMd9KrqpAeSgVqDegCacfhhLjknBITJ57fsOi5/OGsJ +m1D0cVkC6rmvWEfP7PYvMzQltjJBGENxhRvc3mzWma2F9ciq0RziPGzpXgYUYTwTxgA/z cSq8Hkn8kXYNbIu7fWngGCzHRCc3fqA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-sAd3ZPiZM7ufEk3Gptn-Og-1; Fri, 18 Apr 2025 06:52:08 -0400 X-MC-Unique: sAd3ZPiZM7ufEk3Gptn-Og-1 X-Mimecast-MFC-AGG-ID: sAd3ZPiZM7ufEk3Gptn-Og_1744973527 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3913aaf1e32so819724f8f.0 for ; Fri, 18 Apr 2025 03:52:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744973527; x=1745578327; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VkQeTK0Osg/+gnKBUiLYBnAJGjHxbf8m0YFBFQjNQb4=; b=kL5x4008V65oQhL5+bEdYCs0a1v5Y1YUkqicny9lCjdpQjcVyIsDdVTJ/D0FMnI7hl qIRP5o2+6O/WmLCqz/fN1iUwU2XoEKOaT05U85LRkeMNf5K5LQh7gJpcIGqBLyekwc1W Pj48tpHdMB0zBNLxTUF7NUsh2Fkdx6kphKLsscRYOi37+xpXWA5KNL0c2zAJJAY2xy4j w/Vk3O5QAa1NOOB3nIiwDz8ccEGbCRjz8M0AAYU7JTXM2FkGPaSQ+VNAm9iCx8nU/MpU LtsRq1c63EfCH2+zrhRfLOX6uFiM++LdkRi3K30VQhzZuhQplyRuGW7tLT/WB4+tlun+ QMOg== X-Forwarded-Encrypted: i=1; AJvYcCUPDFRNH1ZS42aMjr30/yLPAFmdldLee8AE97rVgl0vlxmtRTpakm+RLeR8thIkGqphuuGGUw9BMO5UffM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5nwXPNsWaiWkxY95KN5JgkQAVSUiOfLVz2FAKJ2ixh9AYFGk0 8PxAJHjF2X7Vhr3bnce1L+pNT4zCqSgoLTNefI6so9oVtsyd3OIoIQtAGBoDkKVYFrZu6ariJEl 43m+jjB0bj3v/8LmPpoea3fOv6O5DaRZAiTsRezN6z/1n2YhBoQMTlXe0p35+JA== X-Gm-Gg: ASbGncuY4NMx9v82qusKiiXklrlvQXOV5dkNE2gbj8ggTiiG9/qaGZ5VTUJBMTVsnLB ctP1P1TJF+Oyd96+HkMsmTCqeET1a8CYrgTl4tcpoyT3wY4mg73JCwfvSWxSQzktpPP2g5CGavp VYm8s7zw/c39mVK+XUJINupzrE29aBqVn9vfNWMb8uOEI6+sH1i5Rm2FBrJ5wy7madGL5ZqtPvk mR4rxJbK4hQMkUBlji3Osm1fOTpoa+6qu5tooq123i/a3q/exaJ1ajkaoouqDoPBENx/+oZDdAo nxu4XUs0M7+9VVd+4tM+d0LQj9pJxFFZBe61e9+dVxEp0CKdKEXy5a/lF1AFNt+bVuxSowtnjsT bPxRaYWb+yqAl8hbBMIUGybRxPTOWi3MRX78jC5g= X-Received: by 2002:a05:6000:402b:b0:38b:d7d2:12f6 with SMTP id ffacd0b85a97d-39efba2c999mr1692895f8f.2.1744973527487; Fri, 18 Apr 2025 03:52:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhcvLbsU9H37fV4GPewg1icxIKI6LTUrTHeLEmRYvRgt6g8jAb0T9lKbbro2n7huJC9W/kSQ== X-Received: by 2002:a05:6000:402b:b0:38b:d7d2:12f6 with SMTP id ffacd0b85a97d-39efba2c999mr1692875f8f.2.1744973527105; Fri, 18 Apr 2025 03:52:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6700:cada:5396:a4f8:1434? (p200300cbc70e6700cada5396a4f81434.dip0.t-ipconnect.de. [2003:cb:c70e:6700:cada:5396:a4f8:1434]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa43c079sm2447037f8f.50.2025.04.18.03.52.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 03:52:06 -0700 (PDT) Message-ID: <1ed925bd-897e-44b6-ad20-7d61c8c57aa8@redhat.com> Date: Fri, 18 Apr 2025 12:52:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] mm: add zblock allocator To: Johannes Weiner , Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Nhat Pham , Shakeel Butt , Igor Belousov References: <20250412154207.2152667-1-vitaly.wool@konsulko.se> <20250416120912.GC741145@cmpxchg.org> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250416120912.GC741145@cmpxchg.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16.04.25 14:09, Johannes Weiner wrote: > On Sat, Apr 12, 2025 at 05:42:07PM +0200, Vitaly Wool wrote: >> zblock is a special purpose allocator for storing compressed pages. >> It stores integer number of same size objects per its block. These >> blocks consist of several physical pages (2**n, i. e. 1/2/4/8). >> >> With zblock, it is possible to densely arrange objects of various sizes >> resulting in low internal fragmentation. Also this allocator tries to >> fill incomplete blocks instead of adding new ones, in many cases >> providing a compression ratio comparable to zmalloc's. >> >> zblock is also in most cases superior to zsmalloc with regard to >> average performance and worst execution times, thus allowing for better >> response time and real-time characteristics of the whole system. > > Is there a reason not to use this allocation scheme in zsmalloc then? > > I'm curious what others think, but I'm still not convinced a second > allocator makes sense. It's maintenance overhead, a permanent struggle > to match feature parity, and it fragments development and testing base. > > Not long ago several slab allocators were removed for those > reasons. Likewise, we just deleted zbud and z3fold because they didn't > get any attention and bitrotted, but not before years of inflicting > pain through the zpool interface, users accidentally making very > suboptimal choices, reporting the same bugs over and over again etc. > > If you discovered a better allocation scheme, that's excellent. But I > don't see why it warrants forking the entire allocator. Just curious, I see a review on v4 happening on something that was nacked by two people in v2 [1]. Do these nack's still apply or were something clarified and they no longer apply? [1] https://lore.kernel.org/linux-mm/CAKEwX=Ma9phmURz5nyJm0MQrWmXGFLFBPwr8-Cx=zbc473rx9A@mail.gmail.com/ -- Cheers, David / dhildenb