From: Jonathan Cameron <jic23@kernel.org>
To: Nizam Haider <nizamhaider786@gmail.com>, pmeerw@pmeerw.net
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Nizam Haider <nijam.h@hcl.com>
Subject: Re: [PATCH] Staging: iio: impedance-analyzer: ad5933: fix wrong comments
Date: Sat, 10 Dec 2016 17:51:07 +0000 [thread overview]
Message-ID: <1eda9a06-063e-e865-9032-2883b4d26584@kernel.org> (raw)
In-Reply-To: <20161207174447.24128-1-nizamhaider786@gmail.com>
On 07/12/16 17:44, Nizam Haider wrote:
> according to datasheet complete control register is of 2 bytes.
> http://www.analog.com/media/en/technical-documentation/data-sheets/AD5933.pdf
>
> Signed-off-by: Nizam Haider <nijam.h@hcl.com>
Applied to the togreg branch of iio.git - initially pushed out as testing so the
autobuilders can completely ignore this patch ;)
Jonathan
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 3892a74..f39e03a 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -23,8 +23,8 @@
> #include <linux/iio/kfifo_buf.h>
>
> /* AD5933/AD5934 Registers */
> -#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 2 bytes */
> -#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 2 bytes */
> +#define AD5933_REG_CONTROL_HB 0x80 /* R/W, 1 byte */
> +#define AD5933_REG_CONTROL_LB 0x81 /* R/W, 1 byte */
> #define AD5933_REG_FREQ_START 0x82 /* R/W, 3 bytes */
> #define AD5933_REG_FREQ_INC 0x85 /* R/W, 3 bytes */
> #define AD5933_REG_INC_NUM 0x88 /* R/W, 2 bytes, 9 bit */
>
prev parent reply other threads:[~2016-12-10 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 17:44 Nizam Haider
2016-12-10 17:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eda9a06-063e-e865-9032-2883b4d26584@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nijam.h@hcl.com \
--cc=nizamhaider786@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®