From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E754B35C1AC for ; Thu, 5 Feb 2026 07:24:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770276298; cv=none; b=o3XIOJ/lJ3/16YvLy+VX6be77WooRJeUftarERUlhl1tIW56dSZmuGb8XuaFTN+sVraOwyrGRoJfUvt9KXhm/K7/KeKy2aqn9D/+nqWhyvLEmqxSm66F6kpoZJd3c+5hNocuD7CgTLG4LNqSPbSYgic5bSLzyLXYMEiPGXK6Wuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770276298; c=relaxed/simple; bh=PGSAGvdhlkgfPjsh/ctVb6oEPolu8O6RDCCuvZv7cgY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=InlLXa8HmoN47KhlMmyZiPgt4fyX4+dJ2So48Ob2aImV5xrecdNs/Zl8mE6ApexcrDMAHDNC0GgXXctuseqrmwbhVQvZZQ9vqwSG+A1aX3js2oCa+Eynt56af2HItvla8KjOBuXEXd2YQhpVwg6z7xRm09ocKryRYZpoO5CJtKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e3JyqN2s; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bc891LEz; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e3JyqN2s"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bc891LEz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770276297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tK4FZC418zNNLTLQpI+yuB0hOA+LANd8dFsFLw6h/Bo=; b=e3JyqN2s3B9SVWIRC8OxxHd9NoNvVxZSMmlcq0um8/wwx1urfShv0cbsNVDfFAPU1J1Qmk lSrUsKjbM8WCfSJgohzRme7RHSBwK6DGBsP3pY93p3CjRWspzz70hPxSu3j0eaguIM2x5L 3yT88SV2/hUjopBadOxnLo7sIY9yvXE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-7zs3SHd8PImY891Qw7H4jg-1; Thu, 05 Feb 2026 02:24:43 -0500 X-MC-Unique: 7zs3SHd8PImY891Qw7H4jg-1 X-Mimecast-MFC-AGG-ID: 7zs3SHd8PImY891Qw7H4jg_1770276282 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-435ab907109so550593f8f.3 for ; Wed, 04 Feb 2026 23:24:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770276282; x=1770881082; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=tK4FZC418zNNLTLQpI+yuB0hOA+LANd8dFsFLw6h/Bo=; b=Bc891LEz7mUZ+p4PSLOIgC8IZwRgzyeJjC6/xVwmD5BDJrxrQGTej6xEn9JUi6wGd/ MCh2LBlmnAO0Wi5UvDqXrdmCNdXE5sDf7L3W+CcFM0x6+WidXAgM3hLPRFTZG9hlqvX2 A8Ucv6qWaWtvFB3Ij8Lh+NnzmyuUQ5pAgbBee9aeqmHK+qE1Nm7EthtiivRjnqjRg93q ol6dHhvkZsFkdXkTZ3SCRoY9zDFUjmVnyj7rnR0eTGTDqQK6ISe09XqU+5+oZnEpgLip 9k8EkZvm3dxCpWQGAbyf3yPItzVFwpFSdAbR4FflL9Xg/dJ33x8ebOGF+HzQ7fI1k7/4 lByA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770276282; x=1770881082; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tK4FZC418zNNLTLQpI+yuB0hOA+LANd8dFsFLw6h/Bo=; b=HXdwP6+1KP6yFMWE/YSLhTFmSRcKOe2pEe+E6aVSCBYEVXNJr37La6finJ3wW+q4Gy 3ylIsqRotJMQRaMCbHwbU36B9dykI0ymnPSe/0Y8AeEXX6MAAF0VtmmAZbhKSK09esLF ElB8PEUfJwsGUJbibP46+V+p4ZdLdUtegoAC/ZWOXTI+04e2ANl4eGj6SVSoadKV2+Go x9E+uR1TfwbyPxgcuQiJfM0MXMvqQrGu41M5S/kFRQB+/Af0RZfQnpGHAirEF1ePLPzB xLSwkNaN7IZ9GYqdwAJ/6zs9b562z2XdjAxlBAyFigSjiMlSEfv2rhIcnhUyL1tGsK0P YBiA== X-Forwarded-Encrypted: i=1; AJvYcCUUzbM0PrRPsnRTHR1/Gl55i6dcJ62SzrrrCgayDSET3uGxFFHS66PqT1o8kOOddZkwNWzqHmchlrBAM98=@vger.kernel.org X-Gm-Message-State: AOJu0YwMimZDGYc5X1w+Ui2YfkdQE47qkv4AsCy2VWj9kGWBdUxm0PRd QNLtW68tzox2clVBSEBvqQXSqtIfxBWqALleOLji6OZofxUVvzIUy3IpQYFxxERrJ+KeyLGJ5ZP G9rmQIU7kKKc2Uwpickc9RJpVFeqnVivfuVDZJt9r0y79nssCS812Kamw4ggVOaRvSwAPhVe91i rO X-Gm-Gg: AZuq6aIzcngkMq7WqprkB5MPV34KYNA2+tpENxZHlGAkXkIWh2tjonkXx7QK95NYdT3 HHG4aGLBmN0ycB8JmM68unm9q7fdWMQGTX+GibkAa2+Mw/7Y5c2Z3AxPqUO+KHrdd7Ne5f1Xg/T yBgDFfaZ2mV/3nUsYy07wAnQHqivU/gN+fCIvXBEQlKx0kCuWWZQdGmQyGQJl3tqPUbxwiM96GG Y6iO7n4ibsBUEL0xwCft8MLnXLzvuSLg0fpB8jJMs/ZOuDhmuhV3FuKMpVu/OwkitY8EhLoPPeq fWBn1KtUzoExFCYeSS5IKSVKujdTyPW7iP+CddUjXUOad2/UTWTkaNGSEdxy/rXSaZFJ4awu7V9 DRwy8XPz1yrHgC8VNxZaK1yaYc7u8lluIN/II0fuyGB6MoxCWf0oy49OmpdoFKV5BfrbaiQZeJC gL/sERHiXl X-Received: by 2002:a05:6000:1841:b0:432:5b81:48b with SMTP id ffacd0b85a97d-43618061687mr7957492f8f.61.1770276282032; Wed, 04 Feb 2026 23:24:42 -0800 (PST) X-Received: by 2002:a05:6000:1841:b0:432:5b81:48b with SMTP id ffacd0b85a97d-43618061687mr7957465f8f.61.1770276281680; Wed, 04 Feb 2026 23:24:41 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e250bdsm12447503f8f.2.2026.02.04.23.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 23:24:41 -0800 (PST) Message-ID: <1edfc4451310645ffe89a60e461682eb49ff6006.camel@redhat.com> Subject: Re: [PATCH v2 20/20] rv/rvgen: add missing return type annotations From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , "open list:RUNTIME VERIFICATION (RV)" , open list Date: Thu, 05 Feb 2026 08:24:40 +0100 In-Reply-To: <20260204144914.104028-21-wander@redhat.com> References: <20260204144914.104028-1-wander@redhat.com> <20260204144914.104028-21-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-02-04 at 11:42 -0300, Wander Lairson Costa wrote: > Add missing `-> str` return type annotations to code generation > methods in RVGenerator. These methods return strings, and the missing > hints caused errors with static analysis tools. >=20 > Signed-off-by: Wander Lairson Costa > --- > =C2=A0tools/verification/rvgen/rvgen/generator.py | 16 ++++++++-------- > =C2=A01 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/generator.py > b/tools/verification/rvgen/rvgen/generator.py > index ef6c9150f50c6..4b984869a7b3d 100644 > --- a/tools/verification/rvgen/rvgen/generator.py > +++ b/tools/verification/rvgen/rvgen/generator.py > @@ -73,13 +73,13 @@ class RVGenerator: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = return f"#include \n" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "" > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def fill_tracepoint_handlers_skel(self): > +=C2=A0=C2=A0=C2=A0 def fill_tracepoint_handlers_skel(self) -> str: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "NotImplemented" Those are the ones that will raise an exception in a later iteration of thi= s, right? I wonder if we really need to touch them now. Anyway I'm fine with this if it pleases your tools, thanks. Reviewed-by: Gabriele Monaco > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def fill_tracepoint_attach_probe(self): > +=C2=A0=C2=A0=C2=A0 def fill_tracepoint_attach_probe(self) -> str: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "NotImplemented" > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def fill_tracepoint_detach_helper(self): > +=C2=A0=C2=A0=C2=A0 def fill_tracepoint_detach_helper(self) -> str: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "NotImplemented" > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0 def fill_main_c(self): > @@ -100,19 +100,19 @@ class RVGenerator: > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return main_c > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def fill_model_h(self): > +=C2=A0=C2=A0=C2=A0 def fill_model_h(self) -> str: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "NotImplemented" > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def fill_monitor_class_type(self): > +=C2=A0=C2=A0=C2=A0 def fill_monitor_class_type(self) -> str: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "NotImplemented" > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def fill_monitor_class(self): > +=C2=A0=C2=A0=C2=A0 def fill_monitor_class(self) -> str: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "NotImplemented" > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def fill_tracepoint_args_skel(self, tp_type): > +=C2=A0=C2=A0=C2=A0 def fill_tracepoint_args_skel(self, tp_type) -> str: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "NotImplemented" > =C2=A0 > -=C2=A0=C2=A0=C2=A0 def fill_monitor_deps(self): > +=C2=A0=C2=A0=C2=A0 def fill_monitor_deps(self) -> str: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 buff =3D [] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 buff.append(" # XXX: add= dependencies if there") > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if self.parent: