From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1B35C64E7A for ; Tue, 1 Dec 2020 21:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56E86208C3 for ; Tue, 1 Dec 2020 21:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388390AbgLAV3T (ORCPT ); Tue, 1 Dec 2020 16:29:19 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2187 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388128AbgLAV3T (ORCPT ); Tue, 1 Dec 2020 16:29:19 -0500 Received: from fraeml740-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ClwB83t30z67FYd; Wed, 2 Dec 2020 05:25:36 +0800 (CST) Received: from lhreml741-chm.china.huawei.com (10.201.108.191) by fraeml740-chm.china.huawei.com (10.206.15.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 1 Dec 2020 22:28:32 +0100 Received: from [10.47.199.27] (10.47.199.27) by lhreml741-chm.china.huawei.com (10.201.108.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Tue, 1 Dec 2020 21:28:25 +0000 Subject: Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records" To: Jiri Olsa , Petr Malat , CC: , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Adrian Hunter , Kan Liang , References: <20201124095923.3683-1-oss@malat.biz> <20201124102919.15312-1-oss@malat.biz> <20201124143645.GD2088148@krava> <20201124181519.GA29264@ntb.petris.klfree.czf> <20201130114020.GA29476@ntb.petris.klfree.czf> <20201201190928.GB3169083@krava> <90d5469d-2591-44bf-70c4-edc1b2750935@huawei.com> From: Alexei Budankov Message-ID: <1ee1c9b6-516f-cee1-1b37-388fb5507cd3@huawei.com> Date: Wed, 2 Dec 2020 00:28:18 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <90d5469d-2591-44bf-70c4-edc1b2750935@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.47.199.27] X-ClientProxiedBy: braeml703-chm.china.huawei.com (10.226.71.47) To lhreml741-chm.china.huawei.com (10.201.108.191) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eventually sending to the proper Alexey's address. On 02.12.2020 0:04, Alexei Budankov wrote: > > On 01.12.2020 22:09, Jiri Olsa wrote: >> On Mon, Nov 30, 2020 at 12:40:20PM +0100, Petr Malat wrote: >>> Hi Jiří, >>> were you able to reproduce the issue? I may also upload perf-archive >>> if that would help. >> >> oh yea ;-) seems like those 2 commits you reverted broke 32 bits >> perf for data files > 32MB >> >> but the fix you did does not work for Alexey's test he mentioned >> in the commit: >> >> $ perf record -z -- some_long_running_workload >> $ perf report --stdio -vv >> >> it's failing for me with: >> >> # ./perf report >> Couldn't allocate memory for decompression >> 0xfe6f3a [0x60]: failed to process type: 81 [Operation not permitted] >> Error: >> failed to process sample >> # To display the perf.data header info, please use --header/--header-only options. >> # >> >> I think that's why here's special handling for compressed >> events, but I'll need to check on that in more detail, >> I was hoping for Alexey to answer ;-) > > Sorry for delay. Alexey Bayduraev could possibly help with that sooner. > Alexey, could you please follow up. > > Thanks, > Alexei