From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Peng Fan <peng.fan@nxp.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Abel Vesa <abelvesa@kernel.org>
Cc: "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/4] dt-bindings: clock: support i.MX95 BLK CTL module
Date: Sun, 31 Mar 2024 21:54:49 +0200 [thread overview]
Message-ID: <1ee97afd-2d64-469b-b85c-58a1f1fd59ea@linaro.org> (raw)
In-Reply-To: <DU0PR04MB94171DDC725D52E66DF3A77F88382@DU0PR04MB9417.eurprd04.prod.outlook.com>
On 31/03/2024 13:58, Peng Fan wrote:
>>> + const: 1
>>> + description:
>>> + The clock consumer should specify the desired clock by having the
>> clock
>>> + ID in its "clocks" phandle cell. See
>>> + include/dt-bindings/clock/nxp,imx95-clock.h
>>
>> In such case, put header as your first patch in the patchset. I don't understand
>> why it was split in the first place...
>
> Rob gave a comment in v4, so I split the headers.
> "
> If this number can change, then it is not ABI and doesn't go in this
> header. With that dropped,
> "
Nothing here speaks about splitting headers. Absolutely NOTHING. Rob
commented that you added number which can change, thus this is not a
binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-31 19:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 7:51 [PATCH v5 0/4] Add support i.MX95 BLK CTL module clock features Peng Fan (OSS)
2024-03-24 7:52 ` [PATCH v5 1/4] dt-bindings: clock: support i.MX95 BLK CTL module Peng Fan (OSS)
2024-03-25 19:24 ` Krzysztof Kozlowski
2024-03-31 11:58 ` Peng Fan
2024-03-31 19:54 ` Krzysztof Kozlowski [this message]
2024-03-24 7:52 ` [PATCH v5 2/4] dt-bindings: clock: support i.MX95 Display Master CSR module Peng Fan (OSS)
2024-03-25 19:23 ` Krzysztof Kozlowski
2024-03-24 7:52 ` [PATCH v5 3/4] dt-bindings: clock: add i.MX95 clock header Peng Fan (OSS)
2024-03-25 19:22 ` Krzysztof Kozlowski
2024-04-01 7:26 ` Peng Fan
2024-04-01 9:51 ` Krzysztof Kozlowski
2024-03-24 7:52 ` [PATCH v5 4/4] clk: imx: add i.MX95 BLK CTL clk driver Peng Fan (OSS)
2024-03-25 19:25 ` Krzysztof Kozlowski
2024-03-31 12:01 ` Peng Fan
2024-03-31 19:52 ` Krzysztof Kozlowski
2024-03-25 19:21 ` [PATCH v5 0/4] Add support i.MX95 BLK CTL module clock features Krzysztof Kozlowski
2024-03-31 12:00 ` Peng Fan
2024-03-31 19:53 ` Krzysztof Kozlowski
2024-04-01 1:32 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ee97afd-2d64-469b-b85c-58a1f1fd59ea@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abelvesa@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®