From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751142AbdAQP5W (ORCPT ); Tue, 17 Jan 2017 10:57:22 -0500 Received: from userp1050.oracle.com ([156.151.31.82]:19293 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbdAQP5O (ORCPT ); Tue, 17 Jan 2017 10:57:14 -0500 Subject: Re: [PATCH v4 3/4] sparc64: Add support for ADI register fields, ASIs and traps To: David Miller References: <20170116.232359.2135717859694837287.davem@davemloft.net> Cc: chris.hyser@oracle.com, sowmini.varadhan@oracle.com, tushar.n.dave@oracle.com, akpm@linux-foundation.org, nitin.m.gupta@oracle.com, gerald.schaefer@de.ibm.com, hughd@google.com, kirill.shutemov@linux.intel.com, adam.buchbinder@gmail.com, minchan@kernel.org, allen.pais@oracle.com, viro@zeniv.linux.org.uk, aryabinin@virtuozzo.com, paul.gortmaker@windriver.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, khalid@gonehiking.org From: Khalid Aziz Organization: Oracle Corp Message-ID: <1ef18343-ea2c-73ad-b495-411b94122ca5@oracle.com> Date: Tue, 17 Jan 2017 08:55:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170116.232359.2135717859694837287.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/16/2017 09:23 PM, David Miller wrote: > From: Khalid Aziz > Date: Wed, 11 Jan 2017 09:12:53 -0700 > >> +#define SUN4V_MCD_PRECISE \ >> + ldxa [%g0] ASI_SCRATCHPAD, %g2; \ >> + ldx [%g2 + HV_FAULT_D_ADDR_OFFSET], %g4; \ >> + ldx [%g2 + HV_FAULT_D_CTX_OFFSET], %g5; \ >> + ba,pt %xcc, etrap; \ >> + rd %pc, %g7; \ >> + ba,pt %xcc, sun4v_mcd_detect_precise; \ >> + nop; \ >> + nop; > > Always indent instructions which sit in the delay slot of a non-annulled > branch, call, or jmpl by one extra space. For example: > > ba,pt %xcc, 1f > nop > >> +sun4v_mcd_detect_precise: >> + or %l4, %g0, %o1 >> + or %l5, %g0, %o2 >> + call sun4v_mem_corrupt_detect_precise >> + add %sp, PTREGS_OFF, %o0 > > Likewise. > > Also, just do a normal "mov x, y" instead of the "or x, %g0, y" thing. Thanks, David. I will fix it in the next version of this patch. -- Khalid