From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 414F6192D8B for ; Thu, 2 Jan 2025 21:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735855192; cv=none; b=as2ZJyYZDo0j1tEOsPTzyhnAxQl7dr4HiUYQUV4LH/YL7abjH5IolKucapJLaqXIYOE8XvdrlO7k0/XVJEgHoxcS6SYeEjhRmqj6RxQqqCMJncvpTpP+hJi5RDgyx4ZYyAAH0UzMNi8BhnqwcsLftoM3XWomR8MiAIhP92SeuCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735855192; c=relaxed/simple; bh=2ONAg5rW+7GxAccAVZaJwyFiplkQV9714dnAlJasR1g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rX1rIgh9EhjYZEZgk1zRJ9WuWwMT1zMi0CUI+b4I4kZytpUobhZaylkVwBKpo3oBNftLCFEWJq+x5Uj0bt/mByxdQaTJOTg5n/7CfJZVHBpmTPNFeJA8r5jR1ywbKsFNkarU3qR7z0ngAcZa3HTfwmBDHmY8u0w3/cFl+f48TOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net; spf=none smtp.mailfrom=ursulin.net; dkim=pass (2048-bit key) header.d=ursulin-net.20230601.gappssmtp.com header.i=@ursulin-net.20230601.gappssmtp.com header.b=A8EI3n1B; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ursulin.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ursulin-net.20230601.gappssmtp.com header.i=@ursulin-net.20230601.gappssmtp.com header.b="A8EI3n1B" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3863494591bso6202412f8f.1 for ; Thu, 02 Jan 2025 13:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin-net.20230601.gappssmtp.com; s=20230601; t=1735855188; x=1736459988; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QI0rsiVIVNC3X6LP1G5i9CgFjiv5pDr5qolFlOVRm7A=; b=A8EI3n1BTdtcoKJFwZDlG37dnqotlv+foLx2jrxrBepWwFkTMgCluaUkJEPLva1Ayx Y+ocz/Vf1U8hemLVDJllmBoOjJuS/EQvTut1NFSbhGyV5pC2sfUMaUswKVRkhYqvZBMd lk6ssxL/tQOAvFfR0ZtbjpgvoqUUO7Jk9HZeZVsK+Banu6lkrKQ9d+SKr6rd3i121uVp jiP+T7EQ2OIMEXsSrBjkKU5wHff7d2IciVuBhss3BdvwPLC4ccexYQcyhN7B981HuHgO elFXyVoF+bhesnxY6+Y1sbPc8A75yDPZQsTnAkgerrqx0HVpJcSfBSorWnhH/+3QFJWY NySw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735855188; x=1736459988; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QI0rsiVIVNC3X6LP1G5i9CgFjiv5pDr5qolFlOVRm7A=; b=i+MwYqoAjVS+T026BL7mc0Ycek2ZzhFT4hGOnpq+6EuKdzSiL2vDf+3lT/457aH9tM J2Jzpj6D6LtOiyDv5pJI6wQnzi6nVN+m4wjbLc8OiEWAVMTro+RRFWCU2USsKDhpVLMR pAjxY/wNHXMtzTZLMFVORD3294wHHwUfMlCpWALtSK5LfoPwKivabTxFnn+TLS57N+QM vCIoJmDn97mnOhadFXh/c3BuT8CB1TunhnLKSYqUly4uWOT/lZq8dcG3dpQFfIwU4gP2 FRfSYxJ7a/9FwC6BF4s8WPd8tHdONDuYG5KIhmPQPERUit3j1/cYHgl6laS0PfVS7Srl yl2Q== X-Forwarded-Encrypted: i=1; AJvYcCVfEH1c8AfNvGbZEr07swCwwjFGfQbLxQ2hwdNLYiubpmwUdsi9ofFauPff7R6EoC5dLnKXJEqZj8rnLak=@vger.kernel.org X-Gm-Message-State: AOJu0YzCjQmCzD8xSVymIi6mkG+0R0DTxjtCUbpkbkUCzYIvauI8WBBF OqAJDu3iGILD1jY0eJYY0rWeYK4ke4CZ/PZe1kaVjdfzXKWVkqCByVULv2EbZ3E= X-Gm-Gg: ASbGncuiHYScOg2BljThVCeoNj3AtOCgi4cO+6QZbBOtZHM0TyihgssQTrY1qF0VAkP RSH/aUgb1huY86h3f8KhizdKUcs3uKfTbXmsRvQ2i9IKSgTRCisdkpxtacUyWxlAO1R6qPRVCki jaArmn481XzQq7g9pLZtLmnIjONT2NMsfhamvk2Qln5O2yw6GMgDTl5leEejBvigwKD+z2TtG0N pXdKaKGP2jri8C3e86OEzzn9yQl2kdnR8D3wGTog+HKXKm8kvHTq/LSZ9D+ZJgccrZAXgE7 X-Google-Smtp-Source: AGHT+IHI+VWiQc3LIBTfZtIZkqRJi5K+ChWSLg0X8bgtas0QRLYkfOuqmXVhHJEVxATrmc0Zib46vQ== X-Received: by 2002:a05:6000:4010:b0:382:51ae:7569 with SMTP id ffacd0b85a97d-38a221fae45mr38328694f8f.18.1735855188381; Thu, 02 Jan 2025 13:59:48 -0800 (PST) Received: from [192.168.0.101] ([90.241.98.187]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c832e1bsm38869782f8f.31.2025.01.02.13.59.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 13:59:47 -0800 (PST) Message-ID: <1ef1d07b-bfa9-4e52-bfa0-20f569752701@ursulin.net> Date: Thu, 2 Jan 2025 21:59:47 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] Documentation/gpu: Add fdinfo meanings of drm-*-internal memory tags To: =?UTF-8?Q?Adri=C3=A1n_Mart=C3=ADnez_Larumbe?= , Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mihail Atanassov References: <20241218181844.886043-1-adrian.larumbe@collabora.com> <20241218181844.886043-3-adrian.larumbe@collabora.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <20241218181844.886043-3-adrian.larumbe@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/12/2024 18:18, Adrián Martínez Larumbe wrote: > From: Adrián Larumbe > > A previous commit enabled display of driver-internal kernel BO sizes > through the device file's fdinfo interface. > > Expand the description of the relevant driver-specific key:value pairs > with the definitions of the new drm-*-internal ones. > > Signed-off-by: Adrián Larumbe > Reviewed-by: Mihail Atanassov > --- > Documentation/gpu/panthor.rst | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/gpu/panthor.rst b/Documentation/gpu/panthor.rst > index 3f8979fa2b86..23aa3d67c9d2 100644 > --- a/Documentation/gpu/panthor.rst > +++ b/Documentation/gpu/panthor.rst > @@ -26,6 +26,10 @@ the currently possible format options: > drm-cycles-panthor: 94439687187 > drm-maxfreq-panthor: 1000000000 Hz > drm-curfreq-panthor: 1000000000 Hz > + drm-total-internal: 10396 KiB > + drm-shared-internal: 0 > + drm-active-internal: 10396 KiB > + drm-resident-internal: 10396 KiB > drm-total-memory: 16480 KiB > drm-shared-memory: 0 > drm-active-memory: 16200 KiB > @@ -44,3 +48,13 @@ driver by writing into the appropriate sysfs node:: > > Where `N` is a bit mask where cycle and timestamp sampling are respectively > enabled by the first and second bits. > + > +Possible `drm-*-internal` keys are: `total`, `active`, `resident` and `shared`. > +These values convey the sizes of the internal driver-owned shmem BO's that > +aren't exposed to user-space through a DRM handle, like queue ring buffers, > +sync object arrays and heap chunks. Because they are all allocated and pinned > +at creation time, `drm-resident-internal` and `drm-total-internal` should always > +be equal. `drm-active-internal` shows the size of kernel BO's associated with > +VM's and groups currently being scheduled for execution by the GPU. > +`drm-shared-internal` is unused at present, but in the future it might stand for > +the size of executable FW regions, since they do not belong to an open file context. The description is way too specific, too tied to some of the implementations. I also don't remember that you ever explained why totting up the internal objects into existing regions isn't good enough. I keep asking, you keep not explaining. Or I missed your emails somehow. And you keep not copying me on the thread. Copying people who expressed interest, gave past feedback, etc should be the norm. Until we can clarify the above points I don't think this can go in. Regards, Tvrtko