From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C64A46EC65 for ; Tue, 18 Aug 2026 12:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787056888; cv=none; b=pPo/NpUXcmCgSqCJpq6S53THOHbzBZ10OlEVRrEnHjcpb7tx5ik5GDsVzqJXwOxFNrAStbohDDhGC1i+FddxTmaCUJdOwMpf4C2v9jNkbpMenWC1oxY8AHeTmDS0uSGrJhNaBOiSJo6SOkjiyz3VtyugFS8oMTK4JH9sDH6/oeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787056888; c=relaxed/simple; bh=6QSkho6K6D4RepOlHx3goC1YGgDnUBI/Uahfbn4C2C4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Usqj3ghddeItXRh/hRdOlK99XdxGXQplOZ58kYSfBVcwZsMlAyoexqvKtpBcXhr3ikvjiFPPLHzNlflSAhwPu+ab33CyduwA5GB3vC3AyvfWFLo/ZW4+4pzV4JZs/C2mW03tJLO35t/oW4PZ1OUNcHfh9hKKWBU65qAMZgPtZf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KhvHLXgn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YXqfMmCH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KhvHLXgn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YXqfMmCH" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IBgEum1196457 for ; Tue, 18 Aug 2026 12:41:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lfFYp5KxQ32tNseOFClbJYn6i0Vk+UFQrS6NM45qp7Y=; b=KhvHLXgneagenG7a TJl2JpqPHsu5Z/eDKgyCRQbfOeg12kT/Twe9rQZNkq0LmAvE1MumCePkthFm3joP UWYMd7x5bMKH0gYSDBUl2aB0s4rpvV1g/6ObFBjlA0xXR7LzeNx5wGTK7VRzAGre bAynitKFD11n8EKTmlr7gFlTQBap31wCvuua6f8HPxoilviRQJwa7DyRXZyyvIbS XJLduckqkE2daAJfZh+rpZB+EjoKiP2J9UqLwVCYRIN707KlGZ0xLr4nHz77vIdG /YyPgOpwpUtQToYmndD/NtDBBI6hnhfs/jDIYP9VQfnqS+WyWwUBtiSzKmZ3JgyP JxlmLQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4prn06yv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 12:41:25 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-936bd9b045fso6747385a.2 for ; Tue, 18 Aug 2026 05:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787056885; x=1787661685; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lfFYp5KxQ32tNseOFClbJYn6i0Vk+UFQrS6NM45qp7Y=; b=YXqfMmCH3SzT/OZls/daNAkvYXsDpyG+Z/kNXFXYJdRJ3drNYVXhIAWCgRU/A/OAno lO5GzDBUGVLuLIUcc8WOocr048tYwuyzH2dBMRV0Hua21yiwmS97CguwN8KD+V9fR379 odDAEw8nkuG5J+4cA+FW9wI3JL8CWV8kSFkG/UGnTDFg6j9A5h40klPSRw1rwefXMJXz uNomuIHqs4EBrnwzOxBD1R4TGV9hW/4s1Ps2ZvRnDyvlVntB/hQ1Umikwf+cWPlBljum 8YOYKC1vgAPG4cfaE2hyT3bXcE0c3CHwIdR10kKiKlnIhNS0TTbeyn4k1vgfE270qQVq zBDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787056885; x=1787661685; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lfFYp5KxQ32tNseOFClbJYn6i0Vk+UFQrS6NM45qp7Y=; b=abUnsl5mKxfHPA9ZVA7S4JhXdWDJWaNCk4wMzMceRyoWiL+hpB6/pe4RpYiArMFQVA C+FM88i5mc7gr6bpheVLEA3HD9G5TARt0AUpsaErjwuO27S/uReTmsH8jxkKEei/JHC7 kVmIBRgXR47URC1Zp1XP39mpooXWKNpRgqTqlpP2zwgOlTLPHuQNnyIali8bTsu1/3L0 9sYM5i7Eb4gxTQYSRJRkl9Hf69fYw3tYatvbLd+XbPRWqi5CBSIM9rTel6xhrd5cL7jQ z0zmfE8RxsFm08HyMpIZWurdY49GVWGFf2LlKbqd7V74K9uuEXAhKYJ9L8Mp+TryQsLR 7V1A== X-Forwarded-Encrypted: i=1; AHgh+RqU21eh9vtNSRA26VQPAEreW03g5y65ZMxDNBYDtoxVKdIg1CbsoHcHYAvi2SCHBtE03o5n+4UnNGMwM2w=@vger.kernel.org X-Gm-Message-State: AOJu0YzYNjsXJwhw5PHhgRjy/sKv9eVUTsIS3OOtH6IPJ9WedC/8EgtK O5IRyscUTmIsbQLssnVx/Yb2QTjip/dmyv3t3ObyJXfr6sVHMIyr1vp3owaiPRZICQNBTUi49R+ Y5801eVlIDLx0uMAPPhUjA7fv1Ve/d4DL45Xl1DtiQPA053dzvAi2flKFLSg1H2Tf+iA= X-Gm-Gg: AR+sD10ce4/2y/SXwvUbgRWsP21A2QHjptbQ7OYMcgnhzqc8PdQO8eJwHhMFOpAyA+H V/IXmX8IQKJvZlq3A5MAX6y2w5Dt0yXWI+uDTsP06HHoRtLmViFErV8JXS5wVEcGUCgUL3MVpU/ Ujk9THxYiJrGsCl6HClZ6W2Z9f8x2ntMCMHvszM4rsyaHEt3cqwviYccn3kzLusOOPmGVeKOFqx eaaK10PMCqyZGpdjPq2E+cseUYxlwKkbyNi1Y7qJ6nbhlCHzsboERBDXD2tz7sSUNH+YywCjQCy AxVu5U6AzsmeIRTYxpEsirYaGF1ol9iYMboBUDVm3bDateLoBdFb09P6CiXfalNy/52/Ic543ZF wCqBg4QTSPsRQyfDsbtSBMkgM X-Received: by 2002:a05:620a:600f:b0:931:23a:83ca with SMTP id af79cd13be357-936d23849admr2611790385a.4.1787056884546; Tue, 18 Aug 2026 05:41:24 -0700 (PDT) X-Received: by 2002:a05:620a:600f:b0:931:23a:83ca with SMTP id af79cd13be357-936d23849admr2611783085a.4.1787056884066; Tue, 18 Aug 2026 05:41:24 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2185b97a22sm140036766b.42.2026.08.18.05.41.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 05:41:23 -0700 (PDT) Message-ID: <1ef41a49-dcf8-4252-acdd-f7f3c1210c55@oss.qualcomm.com> Date: Tue, 18 Aug 2026 14:41:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: qcs6490-rubikpi3: Add IMX219 camera overlays To: Hongyang Zhao , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Bryan O'Donoghue , Roger Shimizu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20260812-rubikpi-next-20260615-v3-0-06e21232d8e4@thundersoft.com> <20260812-rubikpi-next-20260615-v3-2-06e21232d8e4@thundersoft.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260812-rubikpi-next-20260615-v3-2-06e21232d8e4@thundersoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDA5MyBTYWx0ZWRfX23ljOAmLJuRv rfoH5HZILJqth42aa+HX4cBjdafTEkDQxHglnD7ZR7Rdc/A2BGDMMZ+3I8DvbKOw7aRcgFkSCJ9 Wjj9QfcpSSe8D4tnoKnN86QHhfr/PXM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDA5MyBTYWx0ZWRfX18WvRe8BgtgL xK+CvsIfmnzLX4IZl/UpK3JnzO2fkiHZUtni+8EJVBouDpxh/D/9QZpTAOYB1IJzD/WWAajyKEg qDe06/W2YFw8eOVj/ugDegUsFCia2wqgoURNWIjqive3F05vNyuegqLAlX1+1fOESwoEHXH28YS webNPr2NAcgKwbdVTAn81cxyMMsk07d+lvOpDg/61YGQPraBtbRAbizJ4aKjktIZbyftj79SOEx on6DV+zzgH/CzaiR4yNumAafedFOz2975MMIjLKdQLE/WPrkkwfwJrQrvSa3rlkOeW+d9tsPC5O FJXSB2k/WGyBjZ5R553NDycrdqY/3eHJLDQF4Z+2gB/hZrCiEB/7YaWThDqjnOTi9ORCLLtQODu dUkWAY4A00vGlTbGR8p6jUMDJ8jZ/yAK1nsw6pmPydVc1DqqJutR/YXrnNUHz6BIujxkrVHVK/a pjQGaNr9Yr4H6Kgly5Q== X-Proofpoint-ORIG-GUID: H8HRtjuj1kSZPn_qmHTnnat_9dBMmRQt X-Authority-Analysis: v=2.4 cv=HNrz0Itv c=1 sm=1 tr=0 ts=6a8452f5 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=Wdb1h0LgAAAA:8 a=UnzNPPs-tNYotgR03joA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 a=j5gyrzqu0rbr1vhfHjzO:22 X-Proofpoint-GUID: H8HRtjuj1kSZPn_qmHTnnat_9dBMmRQt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-18_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180093 On 8/12/26 4:22 AM, Hongyang Zhao wrote: > RUBIK Pi 3 ships without camera sensors, and its two connectors support > multiple modules. Keep module-specific nodes out of the base board DTS > and add per-connector overlays for Raspberry Pi Camera Module V2 IMX219 > sensors. > > CAM1 uses CCI1 and CSIPHY1, while CAM2 uses CCI0 and CSIPHY4. Each > overlay describes the 24 MHz sensor input clock and models the module > power domain controlled through the connector PWR_EN signal. The > baseboard supplies VCC3V3_OUTPUT separately and has no per-camera > regulator. > > Describe each connector CAMERA_GPIO signal as a privacy indicator LED > and associate it with the corresponding sensor. This lets the V4L2 core > control the LED while the sensor is streaming. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Hongyang Zhao > --- [...] > + camera@10 { > + compatible = "sony,imx219"; > + reg = <0x10>; > + > + clocks = <&cam1_imx219_clk>; > + > + VANA-supply = <&vreg_cam1_pwr>; > + VDIG-supply = <&vreg_cam1_pwr>; > + VDDL-supply = <&vreg_cam1_pwr>; > + > + leds = <&cam1_privacy_led>; > + led-names = "privacy"; No reset GPIOs? You should also have a reference to the mclk pin state to make sure the correct pin function kicks in Konrad