From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-kernel@vger.kernel.org, kbingham@kernel.org
Subject: Re: [PATCH] MAINTAINERS: Associate GDB scripts with their subsystems
Date: Wed, 25 Jun 2025 14:17:50 -0700 [thread overview]
Message-ID: <1efcc990-957f-4b33-9fe8-59cb2c36fed4@broadcom.com> (raw)
In-Reply-To: <20250625132228.b072618317afd2fbaaa3aaef@linux-foundation.org>
On 6/25/25 13:22, Andrew Morton wrote:
> On Wed, 25 Jun 2025 21:38:20 +0200 Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
>> On 25.06.25 19:52, Florian Fainelli wrote:
>>> The GDB scripts under scripts/gdb/linux are very useful for inspecting
>>> kernel data structures however they depend upon the internal APIs and
>>> data structures which are updated without much consideration for those
>>> scripts. This results in a near constant catching up with fixing the
>>> scripts so they continue to work.
>>>
>>> Associate the GDB scripts with their subsystems in the hope that they
>>> get more love and attention.
>>>
>>
>> ...
>>
>> I will surely support any proposal that helps connecting the scripts
>> with subsystems they address. However, you should likely break up this
>> one here into per-subsystem patches and address each affected
>> maintainer. They should have a chance to accept or reject this potential
>> extension of their responsibility.
>
> I agree - this proposal doesn't seem very practical, really.
Yes, that's a good point it should be on a per-subsystem basis to decide
whether they are willing to take on the maintenance, if nothing else the
reporting.
>
> It might actually be harmful - if someone has an issue with a gdb script
> they'll report that to the subsystem maintainer rather than to the GDB
> script maintainers who are better equipped to address the issue.
If they run scripts/get_maintainer.pl they will get both subsystems to
be listed as recipients to reach out to, so that should help cross
pollinate and ease the pain of fixing.
>
> And I'm not sure there's really a problem to fix here. I'm seeing 13
> commits to scripts/gdb this year and afaict only one (e0349c46cb4f
> ("scripts/gdb/linux/symbols.py: address changes to module_sect_attrs"))
> looks like it is fixing up such a problem.
There are a few more that result from breakage that could have been avoided:
https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/
https://lore.kernel.org/all/20250619225105.320729-1-florian.fainelli@broadcom.com/
and the recent ones for interrupts.py.
--
Florian
prev parent reply other threads:[~2025-06-25 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 17:52 Florian Fainelli
2025-06-25 19:38 ` Jan Kiszka
2025-06-25 20:22 ` Andrew Morton
2025-06-25 21:17 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1efcc990-957f-4b33-9fe8-59cb2c36fed4@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®