From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A55C4321D for ; Fri, 17 Aug 2018 07:53:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FD062187A for ; Fri, 17 Aug 2018 07:53:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FD062187A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbeHQKz7 (ORCPT ); Fri, 17 Aug 2018 06:55:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:45430 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726321AbeHQKz7 (ORCPT ); Fri, 17 Aug 2018 06:55:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0ADB7AE4C; Fri, 17 Aug 2018 07:53:36 +0000 (UTC) Subject: Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups To: "hch@lst.de" , Bart Van Assche Cc: "axboe@kernel.dk" , "linux-kernel@vger.kernel.org" , "keith.busch@intel.com" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "hare@suse.com" , "sagi@grimberg.me" References: <20180814073305.87255-1-hare@suse.de> <20180814073305.87255-3-hare@suse.de> <5a4aab8b5f509d8090ad10107b01d11285fe1528.camel@wdc.com> <20180817070013.GD11170@lst.de> From: Hannes Reinecke Message-ID: <1efe41bd-41f7-127f-994e-da51b02ead41@suse.de> Date: Fri, 17 Aug 2018 09:53:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180817070013.GD11170@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2018 09:00 AM, hch@lst.de wrote: > On Tue, Aug 14, 2018 at 03:44:57PM +0000, Bart Van Assche wrote: >> On Tue, 2018-08-14 at 17:39 +0200, Hannes Reinecke wrote: >>> While I have considered having nvme_nvm_register_sysfs() returning a >>> pointer I would then have to remove the 'static' declaration from the >>> nvm_dev_attr_group_12/20. >>> Which I didn't really like, either. >> >> Hmm ... I don't see why the static declaration would have to be removed from >> nvm_dev_attr_group_12/20 if nvme_nvm_register_sysfs() would return a pointer? >> Am I perhaps missing something? > > No, I think that would be the preferable approach IFF patching the global > table of groups would be viable. I don't think it is, though - we can > have both normal NVMe and LightNVM devices in the same system, so we > can't just patch it over. > > So we'll need three different attribut group arrays: > > const struct attribute_group *nvme_ns_id_attr_groups[] = { > &nvme_ns_id_attr_group, > NULL, > }; > > const struct attribute_group *lightnvm12_ns_id_attr_groups[] = { > &nvme_ns_id_attr_group, > &nvm_dev_attr_group_12, > NULL, > }; > > const struct attribute_group *lightnvm20_ns_id_attr_groups[] = { > &nvme_ns_id_attr_group, > &nvm_dev_attr_group_20, > NULL, > }; > > and a function to select which one to use. > Yeah, I figured the same thing. I'll be redoing the patchset. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)