From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C82FF262D20 for ; Mon, 24 Feb 2025 16:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740414016; cv=none; b=PuHAhEskuvBWDpxPFUc1gvGMLY6YCAFQloIEi9l/aGXGGj5cCfcJjWfXoarSI3rIzURiN6hG9v8k6sJjFncDfYyLTFe1M8A/kb8VvoWF9vXwb1gUqPw9OfUTn6DNAFN7gFSYSRUohqzF86XrPzb1dTqeqqqfsyAGvmcbayc/+Us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740414016; c=relaxed/simple; bh=R5v6YkbR2bjn50laEMUSMIkldHPgeN3Nn5C5qQxsC4g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NDL4Q9C17hHw+fAeJIQZDUTHg/t4AvSnK2wgxScO1GE6Pjf+AOf5Q68BfBQg8D/Wjcvn6k48w+moOMlZcBDPQEMfGmQQ9uF+tCTywdVtG9raWj9HmkUxrf48i7FJ0wzIEJK7DEOfin9eEqpkG3z8QC3rcfLyr6CjkLU3FJCYfnw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=haOdQ4a/; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="haOdQ4a/" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7273f35b201so2451885a34.1 for ; Mon, 24 Feb 2025 08:20:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1740414014; x=1741018814; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eOHYLBWiYUxKQTat7RFgoLjOJELf3Cnpr9Bivlggoe0=; b=haOdQ4a/rlL2TQdmNIW0FYKISrlpw94EqxCX3uZ/R8IM/pw/l2dyCZ2Q2pNfjNLOSy sl322ESNArKVHzngL76wXDklKcDv2qhU5r1554HxoHU6Y4vX6N5/HmN7B7S7a/smrkhX PG0DUZuYdGXYiumrgaOBrJ1ZshTsbuI+E5GkOdQ8dK96hpc7kRSNM9CEOvmYzDMUwkd/ 6GJ/0bSDVEkbyzE0cntnE6YgHtwHJFF6kRKPw95MITHd3kGTaPT+0AYVgbjqSb806ILl kXPrVTKow5p2DULbPIgdJitKpKpdMGgo+sgwDAmNUr9uSVenhdPiQ6ydNh7zzGGaVr9D eXRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740414014; x=1741018814; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eOHYLBWiYUxKQTat7RFgoLjOJELf3Cnpr9Bivlggoe0=; b=I4sauN4O060SwrZ1ZOgzufcGQnhmM0h75mUsfdX22hQCsGEM7x5b4Jkrs6f/sGcluB y8Xna5Z7la6zIGz7K86FVPTStLTMFv0O608pbJbGo6JrWE/cOjpOaR8iMesYEt/bKE6U BF7bOpNDkTDl661iV7LlSm0KPSzhlM754g4kzpAM8k1CekB19jrRQ0GI0r8g3DY1vtmW u+/yeN6igf7usaZjftP9zxdRnICWNTh+mTtEi4EY/Wh3874jrAQqil1sUp0ulDH9b6jb spQm/Qz8uylxG8U89TNepAtauW2FHw02MOH5ncLTTi8oKuvcHCW0wHUpKDpec9t18XoM TYfQ== X-Forwarded-Encrypted: i=1; AJvYcCVusB0xqnB+cdpjL6a4oEbXqrWVw/rpLzL/g8/HupUf7OyKnpgNxriyRBI+faK21NBD7Pw4O5wkoyzmE8I=@vger.kernel.org X-Gm-Message-State: AOJu0YwA2S+veC7qtLmtsc5sROEGTtn+SctbDTEtUQtLSvt8rjuQ3FEu pZLr0GE9EQ5jg3iWOGc18ndk5TDgh1D6dfoPJiGFZqtZigmAcC123ehsFVHYPRI= X-Gm-Gg: ASbGncuq4zxYYsr6F/NnSiWnFJOrDsq9CLF5fOTfk2iyYaGjgsp6lm/EvVS4UX3RM1q BZrBritswB2J95nXLpUxUqwl2F2E5ExZQlM4HLfc2IfTK9/jh6fMubAy07eNVeYpQF57EwkB1kb Wpe5q68mC8M3lk+RMzRjAcGJ+RhOw9kxBM/ZmZ38ehIvFWoORE+zzVA7+8jIvm92b1k2vm4kaZR griyme/RNYoEfmOMwOkmNRL/d6hY1B0pcdmmtSVgDWSY3eeogEEU4WWYHSTNF0U0e047LbF61P1 abfkg+ANU6X6TJ1HEyKNpalZuUFvunsmXeQPV/J6gKvjShLXOPU2alB58oRgHemwSg== X-Google-Smtp-Source: AGHT+IHSwDG2ie/f4N9Ahbr7XlPERMnwlDlbUwaJ7is0FQ2FtRKqXqhYc8M1ZvWovuYYQTgGyn3vKA== X-Received: by 2002:a05:6830:71a2:b0:71f:c1df:121e with SMTP id 46e09a7af769-7274c1a1a0dmr13046254a34.8.1740414013917; Mon, 24 Feb 2025 08:20:13 -0800 (PST) Received: from [172.22.22.28] (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-727378237e4sm2656892a34.47.2025.02.24.08.20.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 08:20:13 -0800 (PST) Message-ID: <1efee202-7b25-4d4a-b9a4-9fb5bdeaf542@riscstar.com> Date: Mon, 24 Feb 2025 10:20:12 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 2/5] clk: bcm: kona: Add support for bus clocks To: Artur Weber , Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Alex Elder , Stanislav Jakubek , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20250216-kona-bus-clock-v1-0-e8779d77a6f2@gmail.com> <20250216-kona-bus-clock-v1-2-e8779d77a6f2@gmail.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20250216-kona-bus-clock-v1-2-e8779d77a6f2@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/16/25 10:12 AM, Artur Weber wrote: > Introduce support for bus clocks into the Broadcom Kona common clock > driver. Most of these functions have been adapted from their peripheral > clock counterparts, as they are nearly identical (bus clocks are just > much more limited in terms of allowed operations). > > Signed-off-by: Artur Weber Seems like this was easy to add. This looks good to me. Reviewed-by: Alex Elder > --- > drivers/clk/bcm/clk-kona-setup.c | 116 +++++++++++++++++++++++++++++++++++++++ > drivers/clk/bcm/clk-kona.c | 62 ++++++++++++++++++++- > drivers/clk/bcm/clk-kona.h | 10 ++++ > 3 files changed, 187 insertions(+), 1 deletion(-) > . . .