From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754607AbdK2LhW (ORCPT ); Wed, 29 Nov 2017 06:37:22 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:48174 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbdK2LhT (ORCPT ); Wed, 29 Nov 2017 06:37:19 -0500 Authentication-Results: ppops.net; spf=none smtp.mailfrom=rf@opensource.wolfsonmicro.com Subject: Re: [PATCH v6 03/17] mfd: madera: Add common support for Cirrus Logic Madera codecs To: Linus Walleij CC: Lee Jones , Mark Brown , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , , "open list:WOLFSON MICROELECTRONICS DRIVERS" , , , "linux-kernel@vger.kernel.org" , Charles Keepax , Nikesh Oswal References: <20171123171316.10868-1-rf@opensource.wolfsonmicro.com> From: Richard Fitzgerald Date: Wed, 29 Nov 2017 11:36:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-ID: <1eff5a38-cff3-449b-bda4-047f50a9f1d4@EX17.ad.cirrus.com> X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711290150 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/11/17 10:18, Linus Walleij wrote: > On Thu, Nov 23, 2017 at 6:13 PM, Richard Fitzgerald > wrote: > >> +config MFD_MADERA_I2C >> + bool "Cirrus Logic Madera codecs with I2C" >> + select MFD_MADERA >> + select REGMAP_I2C >> + depends on I2C >> + depends on PINCTRL >> + help >> + Support for the Cirrus Logic Madera platform audio SoC >> + core functionality controlled via I2C. >> + >> +config MFD_MADERA_SPI >> + bool "Cirrus Logic Madera codecs with SPI" >> + select MFD_MADERA >> + select REGMAP_SPI >> + depends on SPI_MASTER >> + depends on PINCTRL >> + help >> + Support for the Cirrus Logic Madera platform audio SoC >> + core functionality controlled via SPI. > > Why do the I2C and SPI subdrivers depend on PINCTRL? > > They sure don't seem to be using any pinctrl-specific APIs. > They require PINCTRL even if they don't call any functions on it because the chip won't work correctly if there isn't a PINCTRL driver to apply the correct pinmux configuration. > Yours, > Linus Walleij >