From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0FECD3447 for ; Tue, 19 Sep 2023 07:23:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbjISHXT (ORCPT ); Tue, 19 Sep 2023 03:23:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231678AbjISHXQ (ORCPT ); Tue, 19 Sep 2023 03:23:16 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DAE5114; Tue, 19 Sep 2023 00:23:11 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38J5TApo011746; Tue, 19 Sep 2023 07:23:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=1axQKYzgGNibBdr5sOU/LQTgOxZZBZlrX9xQ+g6prr0=; b=lYxw6qcn1EzxQ0LRQtpBv0NjrVwFunrTpcPjtPVjUDsTL1Y+HtxFEICtaMAys6bJVfsJ 5M6sG6tqWBjn6YY3zqEkjYXSgb3c58Q3AMkn0TZalVvl0mmbWyllVx6btf3/NpF+vMa3 r/ncwwYABiZCa/qhqRw/Az1Qujf/tqN+mu8i/0SuizQwlmLwXmCSstFqSoaL4yH2X8XJ V33yPw1Wf3+X8K9DNIVtQ5+BHFwJL3BigaBSjj87OdXQsoaU09hYjzTmy9gCGGrPZ9yx +uo7vOoK9xb4vmQgGAqApMVWULo7vNTXIl0dNyR/DXHKg6D2ETCmUZjiuWgOGnrokyO0 WA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t6trqh9bk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 07:23:06 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38J7N5da031608 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 07:23:05 GMT Received: from [10.201.203.60] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 19 Sep 2023 00:23:00 -0700 Message-ID: <1f09339e-b3b5-874c-4874-199e8c7ae890@quicinc.com> Date: Tue, 19 Sep 2023 12:52:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH V2 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible Content-Language: en-US To: Krzysztof Kozlowski , , , , , , , , , , , , , , , References: <20230915121504.806672-1-quic_srichara@quicinc.com> <20230915121504.806672-2-quic_srichara@quicinc.com> <03b0cafa-49c7-8838-b116-927c9649cbd3@linaro.org> From: Sricharan Ramabadhran In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: HAT-kVeSbg6KpHgw7vELdsYJF40YIKBI X-Proofpoint-ORIG-GUID: HAT-kVeSbg6KpHgw7vELdsYJF40YIKBI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-19_01,2023-09-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 mlxlogscore=537 priorityscore=1501 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309190060 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/15/2023 6:15 PM, Krzysztof Kozlowski wrote: > On 15/09/2023 14:43, Krzysztof Kozlowski wrote: >> On 15/09/2023 14:15, Sricharan Ramabadhran wrote: >>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>> >>> Signed-off-by: Sricharan Ramabadhran >>> --- >>> [v2] Sorted the compatible and removed example >>> >> >> Reviewed-by: Krzysztof Kozlowski > > No, unreviewed. Your driver says it is not compatible with > qcom,tsens-v1. This does not look right :/ > Yes it is V1 IP, but since there is no RPM, to enable the IP/SENSORS have to do those steps after calling init_common. Similar reason added a new feat as well in patch #2 as well. Hence for this, new compatible was required. Regards, Sricharan